From patchwork Thu Apr 19 21:25:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeroen Hofstee X-Patchwork-Id: 153877 X-Patchwork-Delegate: wd@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 13ECBB6FD2 for ; Fri, 20 Apr 2012 08:26:43 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id EE444281D3; Fri, 20 Apr 2012 00:26:40 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xy8g2ulawR8j; Fri, 20 Apr 2012 00:26:40 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 177292819F; Fri, 20 Apr 2012 00:26:39 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 22EBC2817E for ; Thu, 19 Apr 2012 23:32:09 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cb3dcvOFCWQy for ; Thu, 19 Apr 2012 23:32:08 +0200 (CEST) X-Greylist: delayed 395 seconds by postgrey-1.27 at theia; Thu, 19 Apr 2012 23:32:05 CEST X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from smtp8.versatel.nl (smtp8.versatel.nl [62.58.50.100]) by theia.denx.de (Postfix) with ESMTPS id B0F9F2817C for ; Thu, 19 Apr 2012 23:32:04 +0200 (CEST) Received: (qmail 29696 invoked by uid 0); 19 Apr 2012 21:25:23 -0000 Received: from ip120-12-208-87.adsl2.static.versatel.nl (HELO router.myspectrum.nl) ([87.208.12.120]) (envelope-sender ) by smtp8.versatel.nl (qmail-ldap-1.03) with SMTP for < >; 19 Apr 2012 21:25:23 -0000 Received: from laptop-xubunutu (unknown [10.0.0.110]) by router.myspectrum.nl (Postfix) with ESMTP id 8D3531BDA7 for ; Tue, 17 Apr 2012 17:20:29 +0200 (CEST) Received: by laptop-xubunutu (Postfix, from userid 1000) id CF4DB7F2393; Thu, 19 Apr 2012 23:25:22 +0200 (CEST) From: Jeroen Hofstee To: u-boot@lists.denx.de Date: Thu, 19 Apr 2012 23:25:18 +0200 Message-Id: <1334870718-24065-1-git-send-email-jeroen@myspectrum.nl> X-Mailer: git-send-email 1.7.5.4 X-Mailman-Approved-At: Fri, 20 Apr 2012 00:26:37 +0200 Cc: Jeroen Hofstee Subject: [U-Boot] [PATCH] ehci-omap: fix for enabling the correct usb port X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de This is just a patch for the problem reported here: http://lists.denx.de/pipermail/u-boot/2012-February/117580.html originally reported by Igor. "Looks like this is copy paste error from my side,(for port2/3 it should have been bypass for port2/3 rather its port1 set in bypass mode)" I only submit the patch since it is missing in 2012.04-rc3 while the twister board depends on it. Maybe it is already somewhere in the reposistory, but I cannot find it. note: the twister boards still needs an additional `usb reset`, don't know why. U-Boot 2012.04-rc3-dirty (Apr 19 2012 - 21:38:38) AM35XX-GP ES1.0, CPU-OPP2, L3-165MHz, Max CPU Clock 600 Mhz TAM3517 TWISTER Board + LPDDR/NAND I2C: ready DRAM: 256 MiB NAND: 512 MiB MMC: OMAP SD/MMC: 0 In: serial Out: serial Err: serial Die ID #746c0000000000000155dc1405011024 Net: DaVinci-EMAC, smc911x-0 Hit any key to stop autoboot: 0 twister => usb start (Re)start USB... USB: Register 1313 NbrPorts 3 USB EHCI 1.00 scanning bus for devices... 1 USB Device(s) found scanning bus for storage devices... 0 Storage Device(s) found twister => usb reset (Re)start USB... USB: Register 1313 NbrPorts 3 USB EHCI 1.00 scanning bus for devices... 1 USB Device(s) found scanning bus for storage devices... 0 Storage Device(s) found twister => usb reset (Re)start USB... USB: Register 1313 NbrPorts 3 USB EHCI 1.00 scanning bus for devices... 1 USB Device(s) found scanning bus for storage devices... 0 Storage Device(s) found twister => usb reset (Re)start USB... USB: Register 1313 NbrPorts 3 USB EHCI 1.00 scanning bus for devices... 1 USB Device(s) found scanning bus for storage devices... 0 Storage Device(s) found Signed-off-by: Jeroen Hofstee Acked-by: Govindraj.R ti.com> Acked-by: Tom Rini --- drivers/usb/host/ehci-omap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c index 00f787f..1ed7710 100644 --- a/drivers/usb/host/ehci-omap.c +++ b/drivers/usb/host/ehci-omap.c @@ -200,12 +200,12 @@ int omap_ehci_hcd_init(struct omap_usbhs_board_data *usbhs_pdata) if (is_ehci_phy_mode(usbhs_pdata->port_mode[1])) clrbits_le32(®, OMAP_UHH_HOSTCONFIG_ULPI_P2_BYPASS); else - setbits_le32(®, OMAP_UHH_HOSTCONFIG_ULPI_P1_BYPASS); + setbits_le32(®, OMAP_UHH_HOSTCONFIG_ULPI_P2_BYPASS); if (is_ehci_phy_mode(usbhs_pdata->port_mode[2])) clrbits_le32(®, OMAP_UHH_HOSTCONFIG_ULPI_P3_BYPASS); else - setbits_le32(®, OMAP_UHH_HOSTCONFIG_ULPI_P1_BYPASS); + setbits_le32(®, OMAP_UHH_HOSTCONFIG_ULPI_P3_BYPASS); } else if (rev == OMAP_USBHS_REV2) { clrsetbits_le32(®, (OMAP_P1_MODE_CLEAR | OMAP_P2_MODE_CLEAR), OMAP4_UHH_HOSTCONFIG_APP_START_CLK);