Message ID | 1331555152-28911-19-git-send-email-r.sricharan@ti.com |
---|---|
State | Superseded, archived |
Delegated to: | Tom Rini |
Headers | show |
Hi, oops. The subject has to be omap3+ instead of omap2+. Will resend correcting this. Thanks, Sricharan On Mon, Mar 12, 2012 at 5:55 PM, R Sricharan <r.sricharan@ti.com> wrote: > The reset.S has the function to do a warm reset on OMAP > based socs. Moving this to a reset.c file so that this > acts a common layer to add any reset related functionality > for the future. > > Signed-off-by: R Sricharan <r.sricharan@ti.com> > --- > [v3] > Implemented Nishant's idea of having a seperate reset.c file > with weak functions and allowing the arch specific layers > to override it if nessecary. > > .../arm/cpu/armv7/omap-common/{reset.S => reset.c} | 31 +++++++++---------- > arch/arm/include/asm/arch-omap3/cpu.h | 5 +-- > arch/arm/include/asm/arch-omap4/cpu.h | 11 +++++++ > arch/arm/include/asm/arch-omap4/omap.h | 11 ------- > arch/arm/include/asm/arch-omap5/cpu.h | 11 +++++++ > arch/arm/include/asm/arch-omap5/omap.h | 11 ------- > 6 files changed, 39 insertions(+), 41 deletions(-) > rename arch/arm/cpu/armv7/omap-common/{reset.S => reset.c} (67%) > > diff --git a/arch/arm/cpu/armv7/omap-common/reset.S b/arch/arm/cpu/armv7/omap-common/reset.c > similarity index 67% > rename from arch/arm/cpu/armv7/omap-common/reset.S > rename to arch/arm/cpu/armv7/omap-common/reset.c > index 838b122..1b2e2e0 100644 > --- a/arch/arm/cpu/armv7/omap-common/reset.S > +++ b/arch/arm/cpu/armv7/omap-common/reset.c > @@ -1,6 +1,11 @@ > /* > - * Copyright (c) 2009 Samsung Electronics. > - * Minkyu Kang <mk7.kang@samsung.com> > + * > + * Common layer for reset related functionality of OMAP based socs. > + * > + * (C) Copyright 2012 > + * Texas Instruments, <www.ti.com> > + * > + * Sricharan R <r.sricharan@ti.com> > * > * See file CREDITS for list of people who contributed to this > * project. > @@ -20,19 +25,13 @@ > * Foundation, Inc., 59 Temple Place, Suite 330, Boston, > * MA 02111-1307 USA > */ > - > #include <config.h> > +#include <asm/io.h> > +#include <asm/arch/cpu.h> > > -.global reset_cpu > -reset_cpu: > - ldr r1, rstctl @ get addr for global reset > - @ reg > - ldr r3, rstbit @ sw reset bit > - str r3, [r1] @ force reset > - mov r0, r0 > -_loop_forever: > - b _loop_forever > -rstctl: > - .word PRM_RSTCTRL > -rstbit: > - .word PRM_RSTCTRL_RESET > +static void omap_reset_cpu(unsigned long ignored) > +{ > + writel(PRM_RSTCTRL_RESET, PRM_RSTCTRL); > +} > +void reset_cpu(unsigned long ignored) > + __attribute__((weak, alias("omap_reset_cpu"))); > diff --git a/arch/arm/include/asm/arch-omap3/cpu.h b/arch/arm/include/asm/arch-omap3/cpu.h > index 84308e0..457f99d 100644 > --- a/arch/arm/include/asm/arch-omap3/cpu.h > +++ b/arch/arm/include/asm/arch-omap3/cpu.h > @@ -474,12 +474,11 @@ struct prm { > u8 res3[0x1c]; > u32 clksrc_ctrl; /* 0x1270 */ > }; > -#else /* __ASSEMBLY__ */ > -#define PRM_RSTCTRL 0x48307250 > -#define PRM_RSTCTRL_RESET 0x04 > #endif /* __ASSEMBLY__ */ > #endif /* __KERNEL_STRICT_NAMES */ > > +#define PRM_RSTCTRL 0x48307250 > +#define PRM_RSTCTRL_RESET 0x04 > #define SYSCLKDIV_1 (0x1 << 6) > #define SYSCLKDIV_2 (0x1 << 7) > > diff --git a/arch/arm/include/asm/arch-omap4/cpu.h b/arch/arm/include/asm/arch-omap4/cpu.h > index 08b9c99..feddb7d 100644 > --- a/arch/arm/include/asm/arch-omap4/cpu.h > +++ b/arch/arm/include/asm/arch-omap4/cpu.h > @@ -168,4 +168,15 @@ struct watchdog { > #define OMAP_GPIO_CLEARDATAOUT 0x0190 > #define OMAP_GPIO_SETDATAOUT 0x0194 > > +/* > + * PRCM > + */ > + > +/* PRM */ > +#define PRM_BASE 0x4A306000 > +#define PRM_DEVICE_BASE (PRM_BASE + 0x1B00) > + > +#define PRM_RSTCTRL PRM_DEVICE_BASE > +#define PRM_RSTCTRL_RESET 0x01 > + > #endif /* _CPU_H */ > diff --git a/arch/arm/include/asm/arch-omap4/omap.h b/arch/arm/include/asm/arch-omap4/omap.h > index 3a39787..47c5883 100644 > --- a/arch/arm/include/asm/arch-omap4/omap.h > +++ b/arch/arm/include/asm/arch-omap4/omap.h > @@ -101,17 +101,6 @@ > #define TCLR_AR (0x1 << 1) > #define TCLR_PRE (0x1 << 5) > > -/* > - * PRCM > - */ > - > -/* PRM */ > -#define PRM_BASE 0x4A306000 > -#define PRM_DEVICE_BASE (PRM_BASE + 0x1B00) > - > -#define PRM_RSTCTRL PRM_DEVICE_BASE > -#define PRM_RSTCTRL_RESET 0x01 > - > /* Control Module */ > #define LDOSRAM_ACTMODE_VSET_IN_MASK (0x1F << 5) > #define LDOSRAM_VOLT_CTRL_OVERRIDE 0x0401040f > diff --git a/arch/arm/include/asm/arch-omap5/cpu.h b/arch/arm/include/asm/arch-omap5/cpu.h > index 0697a73..8ef17c9 100644 > --- a/arch/arm/include/asm/arch-omap5/cpu.h > +++ b/arch/arm/include/asm/arch-omap5/cpu.h > @@ -172,4 +172,15 @@ struct watchdog { > #define OMAP_GPIO_CLEARDATAOUT 0x0190 > #define OMAP_GPIO_SETDATAOUT 0x0194 > > +/* > + * PRCM > + */ > + > +/* PRM */ > +#define PRM_BASE 0x4AE06000 > +#define PRM_DEVICE_BASE (PRM_BASE + 0x1B00) > + > +#define PRM_RSTCTRL PRM_DEVICE_BASE > +#define PRM_RSTCTRL_RESET 0x01 > + > #endif /* _CPU_H */ > diff --git a/arch/arm/include/asm/arch-omap5/omap.h b/arch/arm/include/asm/arch-omap5/omap.h > index d672b6f..e3f55d2 100644 > --- a/arch/arm/include/asm/arch-omap5/omap.h > +++ b/arch/arm/include/asm/arch-omap5/omap.h > @@ -98,17 +98,6 @@ > #define TCLR_AR (0x1 << 1) > #define TCLR_PRE (0x1 << 5) > > -/* > - * PRCM > - */ > - > -/* PRM */ > -#define PRM_BASE 0x4AE06000 > -#define PRM_DEVICE_BASE (PRM_BASE + 0x1B00) > - > -#define PRM_RSTCTRL PRM_DEVICE_BASE > -#define PRM_RSTCTRL_RESET 0x01 > - > /* Control Module */ > #define LDOSRAM_ACTMODE_VSET_IN_MASK (0x1F << 5) > #define LDOSRAM_VOLT_CTRL_OVERRIDE 0x0401040f > -- > 1.7.1 >
diff --git a/arch/arm/cpu/armv7/omap-common/reset.S b/arch/arm/cpu/armv7/omap-common/reset.c similarity index 67% rename from arch/arm/cpu/armv7/omap-common/reset.S rename to arch/arm/cpu/armv7/omap-common/reset.c index 838b122..1b2e2e0 100644 --- a/arch/arm/cpu/armv7/omap-common/reset.S +++ b/arch/arm/cpu/armv7/omap-common/reset.c @@ -1,6 +1,11 @@ /* - * Copyright (c) 2009 Samsung Electronics. - * Minkyu Kang <mk7.kang@samsung.com> + * + * Common layer for reset related functionality of OMAP based socs. + * + * (C) Copyright 2012 + * Texas Instruments, <www.ti.com> + * + * Sricharan R <r.sricharan@ti.com> * * See file CREDITS for list of people who contributed to this * project. @@ -20,19 +25,13 @@ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, * MA 02111-1307 USA */ - #include <config.h> +#include <asm/io.h> +#include <asm/arch/cpu.h> -.global reset_cpu -reset_cpu: - ldr r1, rstctl @ get addr for global reset - @ reg - ldr r3, rstbit @ sw reset bit - str r3, [r1] @ force reset - mov r0, r0 -_loop_forever: - b _loop_forever -rstctl: - .word PRM_RSTCTRL -rstbit: - .word PRM_RSTCTRL_RESET +static void omap_reset_cpu(unsigned long ignored) +{ + writel(PRM_RSTCTRL_RESET, PRM_RSTCTRL); +} +void reset_cpu(unsigned long ignored) + __attribute__((weak, alias("omap_reset_cpu"))); diff --git a/arch/arm/include/asm/arch-omap3/cpu.h b/arch/arm/include/asm/arch-omap3/cpu.h index 84308e0..457f99d 100644 --- a/arch/arm/include/asm/arch-omap3/cpu.h +++ b/arch/arm/include/asm/arch-omap3/cpu.h @@ -474,12 +474,11 @@ struct prm { u8 res3[0x1c]; u32 clksrc_ctrl; /* 0x1270 */ }; -#else /* __ASSEMBLY__ */ -#define PRM_RSTCTRL 0x48307250 -#define PRM_RSTCTRL_RESET 0x04 #endif /* __ASSEMBLY__ */ #endif /* __KERNEL_STRICT_NAMES */ +#define PRM_RSTCTRL 0x48307250 +#define PRM_RSTCTRL_RESET 0x04 #define SYSCLKDIV_1 (0x1 << 6) #define SYSCLKDIV_2 (0x1 << 7) diff --git a/arch/arm/include/asm/arch-omap4/cpu.h b/arch/arm/include/asm/arch-omap4/cpu.h index 08b9c99..feddb7d 100644 --- a/arch/arm/include/asm/arch-omap4/cpu.h +++ b/arch/arm/include/asm/arch-omap4/cpu.h @@ -168,4 +168,15 @@ struct watchdog { #define OMAP_GPIO_CLEARDATAOUT 0x0190 #define OMAP_GPIO_SETDATAOUT 0x0194 +/* + * PRCM + */ + +/* PRM */ +#define PRM_BASE 0x4A306000 +#define PRM_DEVICE_BASE (PRM_BASE + 0x1B00) + +#define PRM_RSTCTRL PRM_DEVICE_BASE +#define PRM_RSTCTRL_RESET 0x01 + #endif /* _CPU_H */ diff --git a/arch/arm/include/asm/arch-omap4/omap.h b/arch/arm/include/asm/arch-omap4/omap.h index 3a39787..47c5883 100644 --- a/arch/arm/include/asm/arch-omap4/omap.h +++ b/arch/arm/include/asm/arch-omap4/omap.h @@ -101,17 +101,6 @@ #define TCLR_AR (0x1 << 1) #define TCLR_PRE (0x1 << 5) -/* - * PRCM - */ - -/* PRM */ -#define PRM_BASE 0x4A306000 -#define PRM_DEVICE_BASE (PRM_BASE + 0x1B00) - -#define PRM_RSTCTRL PRM_DEVICE_BASE -#define PRM_RSTCTRL_RESET 0x01 - /* Control Module */ #define LDOSRAM_ACTMODE_VSET_IN_MASK (0x1F << 5) #define LDOSRAM_VOLT_CTRL_OVERRIDE 0x0401040f diff --git a/arch/arm/include/asm/arch-omap5/cpu.h b/arch/arm/include/asm/arch-omap5/cpu.h index 0697a73..8ef17c9 100644 --- a/arch/arm/include/asm/arch-omap5/cpu.h +++ b/arch/arm/include/asm/arch-omap5/cpu.h @@ -172,4 +172,15 @@ struct watchdog { #define OMAP_GPIO_CLEARDATAOUT 0x0190 #define OMAP_GPIO_SETDATAOUT 0x0194 +/* + * PRCM + */ + +/* PRM */ +#define PRM_BASE 0x4AE06000 +#define PRM_DEVICE_BASE (PRM_BASE + 0x1B00) + +#define PRM_RSTCTRL PRM_DEVICE_BASE +#define PRM_RSTCTRL_RESET 0x01 + #endif /* _CPU_H */ diff --git a/arch/arm/include/asm/arch-omap5/omap.h b/arch/arm/include/asm/arch-omap5/omap.h index d672b6f..e3f55d2 100644 --- a/arch/arm/include/asm/arch-omap5/omap.h +++ b/arch/arm/include/asm/arch-omap5/omap.h @@ -98,17 +98,6 @@ #define TCLR_AR (0x1 << 1) #define TCLR_PRE (0x1 << 5) -/* - * PRCM - */ - -/* PRM */ -#define PRM_BASE 0x4AE06000 -#define PRM_DEVICE_BASE (PRM_BASE + 0x1B00) - -#define PRM_RSTCTRL PRM_DEVICE_BASE -#define PRM_RSTCTRL_RESET 0x01 - /* Control Module */ #define LDOSRAM_ACTMODE_VSET_IN_MASK (0x1F << 5) #define LDOSRAM_VOLT_CTRL_OVERRIDE 0x0401040f
The reset.S has the function to do a warm reset on OMAP based socs. Moving this to a reset.c file so that this acts a common layer to add any reset related functionality for the future. Signed-off-by: R Sricharan <r.sricharan@ti.com> --- [v3] Implemented Nishant's idea of having a seperate reset.c file with weak functions and allowing the arch specific layers to override it if nessecary. .../arm/cpu/armv7/omap-common/{reset.S => reset.c} | 31 +++++++++---------- arch/arm/include/asm/arch-omap3/cpu.h | 5 +-- arch/arm/include/asm/arch-omap4/cpu.h | 11 +++++++ arch/arm/include/asm/arch-omap4/omap.h | 11 ------- arch/arm/include/asm/arch-omap5/cpu.h | 11 +++++++ arch/arm/include/asm/arch-omap5/omap.h | 11 ------- 6 files changed, 39 insertions(+), 41 deletions(-) rename arch/arm/cpu/armv7/omap-common/{reset.S => reset.c} (67%)