Message ID | 1315897821-23049-12-git-send-email-monstr@monstr.eu |
---|---|
State | Rejected |
Headers | show |
On Tuesday, September 13, 2011 03:10:06 Michal Simek wrote: > Signed-off-by: Michal Simek <monstr@monstr.eu> > --- > arch/microblaze/lib/board.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/microblaze/lib/board.c b/arch/microblaze/lib/board.c > index d97543b..5510c12 100644 > --- a/arch/microblaze/lib/board.c > +++ b/arch/microblaze/lib/board.c > @@ -68,6 +68,7 @@ typedef int (init_fnc_t) (void); > init_fnc_t *init_sequence[] = { > env_init, > serial_init, > + console_init_f, > #ifdef CONFIG_SYS_GPIO_0 > gpio_init, > #endif the summary/changelog is still confusing here. what i'd use is: microblaze: call common console_init_f initialization function All arches are supposed to call the common console_init_f func when setting things up. If we don't, code like tftp and netconsole don't operate correctly. -mike
On Tuesday, September 13, 2011 13:33:57 Mike Frysinger wrote:
> the summary/changelog is still confusing here
sorry, i was thinking of "microblaze: Initialize jumptable and console". but
my suggestion mostly still stands.
-mike
Mike Frysinger wrote: > On Tuesday, September 13, 2011 03:10:06 Michal Simek wrote: >> Signed-off-by: Michal Simek <monstr@monstr.eu> >> --- >> arch/microblaze/lib/board.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/arch/microblaze/lib/board.c b/arch/microblaze/lib/board.c >> index d97543b..5510c12 100644 >> --- a/arch/microblaze/lib/board.c >> +++ b/arch/microblaze/lib/board.c >> @@ -68,6 +68,7 @@ typedef int (init_fnc_t) (void); >> init_fnc_t *init_sequence[] = { >> env_init, >> serial_init, >> + console_init_f, >> #ifdef CONFIG_SYS_GPIO_0 >> gpio_init, >> #endif > > the summary/changelog is still confusing here. what i'd use is: > microblaze: call common console_init_f initialization function Fixed Thanks, Michal
diff --git a/arch/microblaze/lib/board.c b/arch/microblaze/lib/board.c index d97543b..5510c12 100644 --- a/arch/microblaze/lib/board.c +++ b/arch/microblaze/lib/board.c @@ -68,6 +68,7 @@ typedef int (init_fnc_t) (void); init_fnc_t *init_sequence[] = { env_init, serial_init, + console_init_f, #ifdef CONFIG_SYS_GPIO_0 gpio_init, #endif
Signed-off-by: Michal Simek <monstr@monstr.eu> --- arch/microblaze/lib/board.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)