From patchwork Tue Aug 16 02:42:04 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 110128 X-Patchwork-Delegate: s-paulraj@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 41EF9B6F77 for ; Tue, 16 Aug 2011 12:44:26 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C5A90280AF; Tue, 16 Aug 2011 04:44:24 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DWaItQjRFnTS; Tue, 16 Aug 2011 04:44:24 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 360D828091; Tue, 16 Aug 2011 04:44:22 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D005128091 for ; Tue, 16 Aug 2011 04:44:20 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id owaKRZfps6ni for ; Tue, 16 Aug 2011 04:44:20 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-gw0-f44.google.com (mail-gw0-f44.google.com [74.125.83.44]) by theia.denx.de (Postfix) with ESMTPS id 7435B28086 for ; Tue, 16 Aug 2011 04:44:12 +0200 (CEST) Received: by gwb20 with SMTP id 20so3319423gwb.3 for ; Mon, 15 Aug 2011 19:44:11 -0700 (PDT) Received: by 10.90.219.11 with SMTP id r11mr4487958agg.180.1313462651635; Mon, 15 Aug 2011 19:44:11 -0700 (PDT) Received: from localhost.localdomain (ip65-46-142-190.z142-46-65.customer.algx.net [65.46.142.190]) by mx.google.com with ESMTPS id t11sm2208874and.3.2011.08.15.19.44.07 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 15 Aug 2011 19:44:11 -0700 (PDT) From: Joel A Fernandes To: u-boot@lists.denx.de Date: Mon, 15 Aug 2011 21:42:04 -0500 Message-Id: <1313462527-3876-4-git-send-email-agnel.joel@gmail.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1313462527-3876-1-git-send-email-agnel.joel@gmail.com> References: <1313462527-3876-1-git-send-email-agnel.joel@gmail.com> Cc: Koen Kooi , Syed Mohammed Khasim , k-kooi@ti.com, jdk@ti.com Subject: [U-Boot] [PATCH 4/7] led: correct off/on locations in structure X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de From: Jason Kridner Although the initialization should probably be done with names, the existing implementation has these structures filled in the opposite order. Signed-off-by: Jason Kridner Signed-off-by: Koen Kooi Signed-off-by: Joel A Fernandes --- common/cmd_led.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common/cmd_led.c b/common/cmd_led.c index 8b46848..d14dd5a 100644 --- a/common/cmd_led.c +++ b/common/cmd_led.c @@ -34,8 +34,8 @@ struct led_tbl_s { char *string; /* String for use in the command */ led_id_t mask; /* Mask used for calling __led_set() */ - void (*on)(void); /* Optional fucntion for turning LED on */ - void (*off)(void); /* Optional fucntion for turning LED on */ + void (*off)(void); /* Optional function for turning LED off */ + void (*on)(void); /* Optional function for turning LED on */ }; typedef struct led_tbl_s led_tbl_t;