| Message ID | 1303121323-22997-1-git-send-email-chander.kashyap@linaro.org |
|---|---|
| State | Accepted |
| Delegated to: | Minkyu Kang |
| Headers | show |
Dear Chander Kashyap, On 18 April 2011 19:08, Chander Kashyap <chander.kashyap@linaro.org> wrote: > S5PC2XX: Macro values for Pull Up and Driver Strength were wrong. > S5PC1XX: Macro values for Driver Strength were wrong. > > Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> > --- > > Changes for V2: > - Macro value order fixed. > - Added Changes for S5PC1XX. > > arch/arm/include/asm/arch-s5pc1xx/gpio.h | 4 ++-- > arch/arm/include/asm/arch-s5pc2xx/gpio.h | 7 +++---- > 2 files changed, 5 insertions(+), 6 deletions(-) > applied to u-boot-samsung Thanks Minkyu Kang.
diff --git a/arch/arm/include/asm/arch-s5pc1xx/gpio.h b/arch/arm/include/asm/arch-s5pc1xx/gpio.h index 2df33a6..485b9bf 100644 --- a/arch/arm/include/asm/arch-s5pc1xx/gpio.h +++ b/arch/arm/include/asm/arch-s5pc1xx/gpio.h @@ -149,8 +149,8 @@ void gpio_set_rate(struct s5p_gpio_bank *bank, int gpio, int mode); /* Drive Strength level */ #define GPIO_DRV_1X 0x0 -#define GPIO_DRV_2X 0x1 -#define GPIO_DRV_3X 0x2 +#define GPIO_DRV_3X 0x1 +#define GPIO_DRV_2X 0x2 #define GPIO_DRV_4X 0x3 #define GPIO_DRV_FAST 0x0 #define GPIO_DRV_SLOW 0x1 diff --git a/arch/arm/include/asm/arch-s5pc2xx/gpio.h b/arch/arm/include/asm/arch-s5pc2xx/gpio.h index 05e5b3e..38303e4 100644 --- a/arch/arm/include/asm/arch-s5pc2xx/gpio.h +++ b/arch/arm/include/asm/arch-s5pc2xx/gpio.h @@ -99,14 +99,13 @@ void gpio_set_rate(struct s5p_gpio_bank *bank, int gpio, int mode); /* Pull mode */ #define GPIO_PULL_NONE 0x0 #define GPIO_PULL_DOWN 0x1 -#define GPIO_PULL_UP 0x2 +#define GPIO_PULL_UP 0x3 /* Drive Strength level */ #define GPIO_DRV_1X 0x0 -#define GPIO_DRV_2X 0x1 -#define GPIO_DRV_3X 0x2 +#define GPIO_DRV_3X 0x1 +#define GPIO_DRV_2X 0x2 #define GPIO_DRV_4X 0x3 #define GPIO_DRV_FAST 0x0 #define GPIO_DRV_SLOW 0x1 - #endif
S5PC2XX: Macro values for Pull Up and Driver Strength were wrong. S5PC1XX: Macro values for Driver Strength were wrong. Signed-off-by: Chander Kashyap <chander.kashyap@linaro.org> --- Changes for V2: - Macro value order fixed. - Added Changes for S5PC1XX. arch/arm/include/asm/arch-s5pc1xx/gpio.h | 4 ++-- arch/arm/include/asm/arch-s5pc2xx/gpio.h | 7 +++---- 2 files changed, 5 insertions(+), 6 deletions(-) -- 1.7.1