From patchwork Sat Dec 18 06:40:28 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dirk Behme X-Patchwork-Id: 76057 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id B6E8CB7093 for ; Sat, 18 Dec 2010 17:41:06 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A2075280D2; Sat, 18 Dec 2010 07:41:02 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q79LkoyrmGSC; Sat, 18 Dec 2010 07:41:02 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 03A52280D6; Sat, 18 Dec 2010 07:41:00 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1C633280D6 for ; Sat, 18 Dec 2010 07:40:58 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DZXggv-xQZb1 for ; Sat, 18 Dec 2010 07:40:56 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-bw0-f46.google.com (mail-bw0-f46.google.com [209.85.214.46]) by theia.denx.de (Postfix) with ESMTP id 071B9280D2 for ; Sat, 18 Dec 2010 07:40:54 +0100 (CET) Received: by bwz15 with SMTP id 15so1639111bwz.33 for ; Fri, 17 Dec 2010 22:40:54 -0800 (PST) Received: by 10.204.101.81 with SMTP id b17mr1186358bko.126.1292654452787; Fri, 17 Dec 2010 22:40:52 -0800 (PST) Received: from linux.local (p5B0421D2.dip0.t-ipconnect.de [91.4.33.210]) by mx.google.com with ESMTPS id x38sm1020604bkj.1.2010.12.17.22.40.51 (version=SSLv3 cipher=RC4-MD5); Fri, 17 Dec 2010 22:40:52 -0800 (PST) From: Dirk Behme To: u-boot@lists.denx.de Date: Sat, 18 Dec 2010 07:40:28 +0100 Message-Id: <1292654428-19095-1-git-send-email-dirk.behme@gmail.com> X-Mailer: git-send-email 1.7.3.2 Subject: [U-Boot] [PATCH] OMAP3: EVM: Convert omap3_evm_version to u32 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Convert the variable omap3_evm_version to u32 to work around some broken linkers from older tool chains. E.g. CodeSourcery's 2009q1-203 ld 2.19.51.20090205. Without this, these linkers stop linking 'omap3_evm' or at least issue a warning. Like arm-none-linux-gnueabi-ld: section .bss [8003f5e0 -> 8007e337] overlaps section .rel.dyn [8003f5e0 -> 80044e57] arm-none-linux-gnueabi-ld: section .dynsym [80044e58 -> 80044ef7] overlaps section.bss [8003f5e0 -> 8007e337] arm-none-linux-gnueabi-ld: u-boot: section .bss vma 0x8003f5e0 overlaps previous sections CC: Sanjeev Premi Signed-off-by: Dirk Behme --- For a discussion of this see http://lists.denx.de/pipermail/u-boot/2010-December/083706.html board/ti/evm/evm.c | 4 ++-- board/ti/evm/evm.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) Index: u-boot.git/board/ti/evm/evm.c =================================================================== --- u-boot.git.orig/board/ti/evm/evm.c +++ u-boot.git/board/ti/evm/evm.c @@ -37,9 +37,9 @@ #include #include "evm.h" -static u8 omap3_evm_version; +static u32 omap3_evm_version; -u8 get_omap3_evm_rev(void) +u32 get_omap3_evm_rev(void) { return omap3_evm_version; } Index: u-boot.git/board/ti/evm/evm.h =================================================================== --- u-boot.git.orig/board/ti/evm/evm.h +++ u-boot.git/board/ti/evm/evm.h @@ -45,7 +45,7 @@ enum { OMAP3EVM_BOARD_GEN_2, /* EVM Rev >= Rev E */ }; -u8 get_omap3_evm_rev(void); +u32 get_omap3_evm_rev(void); #if defined(CONFIG_CMD_NET) static void setup_net_chip(void);