From patchwork Tue Oct 19 05:03:40 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nobuhiro Iwamatsu X-Patchwork-Id: 71874 Return-Path: X-Original-To: wd@gemini.denx.de Delivered-To: wd@gemini.denx.de Received: from diddl.denx.de (diddl.denx.de [10.0.0.6]) by gemini.denx.de (Postfix) with ESMTP id 29356136320 for ; Tue, 19 Oct 2010 07:03:16 +0200 (CEST) Received: from diddl.denx.de (localhost.localdomain [127.0.0.1]) by diddl.denx.de (Postfix) with ESMTP id 13F1E348C9D1 for ; Tue, 19 Oct 2010 07:03:16 +0200 (CEST) Received: from pop.mnet-online.de by diddl.denx.de with POP3 (fetchmail-6.3.17) for (single-drop); Tue, 19 Oct 2010 07:03:16 +0200 (CEST) Received: from murder ([192.168.8.180]) by backend2 (Cyrus v2.2.12) with LMTPA; Tue, 19 Oct 2010 07:01:21 +0200 X-Sieve: CMU Sieve 2.2 Received: from mail.m-online.net (localhost [127.0.0.1]) by frontend1.mail.m-online.net (Cyrus v2.2.12) with LMTPA; Tue, 19 Oct 2010 07:01:20 +0200 Received: from scanner-3.m-online.net (unknown [192.168.6.168]) by mail.m-online.net (Postfix) with ESMTP id B70F91C001B3; Tue, 19 Oct 2010 07:01:20 +0200 (CEST) Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by mxin-1.m-online.net (Postfix) with ESMTP id C3DA346C0A0; Tue, 19 Oct 2010 07:01:18 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 9F8EB28086; Tue, 19 Oct 2010 07:00:45 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I-elNDT0Ipt0; Tue, 19 Oct 2010 07:00:45 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 3F104280CF; Tue, 19 Oct 2010 07:00:15 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 17A5328083 for ; Tue, 19 Oct 2010 07:00:09 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K9Yas5pH+w93 for ; Tue, 19 Oct 2010 07:00:07 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pw0-f44.google.com (mail-pw0-f44.google.com [209.85.160.44]) by theia.denx.de (Postfix) with ESMTP id 06D8128087 for ; Tue, 19 Oct 2010 07:00:03 +0200 (CEST) Received: by pwj8 with SMTP id 8so387518pwj.3 for ; Mon, 18 Oct 2010 22:00:03 -0700 (PDT) Received: by 10.142.133.10 with SMTP id g10mr4212559wfd.416.1287464402977; Mon, 18 Oct 2010 22:00:02 -0700 (PDT) Received: from chimagu (49.14.32.202.bf.2iij.net [202.32.14.49]) by mx.google.com with ESMTPS id x35sm16784944wfd.13.2010.10.18.22.00.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 18 Oct 2010 22:00:02 -0700 (PDT) Received: from iwamatsu by chimagu with local (Exim 4.72) (envelope-from ) id 1P84MZ-0003D1-RN; Tue, 19 Oct 2010 14:03:51 +0900 From: Nobuhiro Iwamatsu To: u-boot@lists.denx.de Date: Tue, 19 Oct 2010 14:03:40 +0900 Message-Id: <1287464627-12302-3-git-send-email-iwamatsu@nigauri.org> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1287464627-12302-1-git-send-email-iwamatsu@nigauri.org> References: <1287464627-12302-1-git-send-email-iwamatsu@nigauri.org> Cc: biggerbadderben@gmail.com Subject: [U-Boot] [PATCH 03/10 v2] net: dc2114x: Add initialized eth_device structure X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de X-Virus-Scanned: by amavisd-new at m-online.net dc2114x driver does not have write_hwaddr function. However, eth stuff executes write_hwaddr function because eth_device structure has not been initialized. Signed-off-by: Nobuhiro Iwamatsu CC: Ben Warren --- drivers/net/dc2114x.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net/dc2114x.c b/drivers/net/dc2114x.c index 5ae53e8..9fd0ec8 100644 --- a/drivers/net/dc2114x.c +++ b/drivers/net/dc2114x.c @@ -279,6 +279,12 @@ int dc21x4x_initialize(bd_t *bis) debug ("dc21x4x: DEC 21142 PCI Device @0x%x\n", iobase); dev = (struct eth_device*) malloc(sizeof *dev); + + if (!dev) { + printf("Can not allocalte memory of dc21x4x\n"); + break; + } + memset(dev, 0, sizeof(*dev)); #ifdef CONFIG_TULIP_FIX_DAVICOM sprintf(dev->name, "Davicom#%d", card_number);