From patchwork Thu Apr 15 15:16:25 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 71762 X-Patchwork-Delegate: info@emk-elektronik.de Return-Path: X-Original-To: wd@gemini.denx.de Delivered-To: wd@gemini.denx.de Received: from diddl.denx.de (diddl.denx.de [10.0.0.6]) by gemini.denx.de (Postfix) with ESMTP id 80848EEE8D9 for ; Thu, 15 Apr 2010 17:47:28 +0200 (CEST) Received: from diddl.denx.de (localhost.localdomain [127.0.0.1]) by diddl.denx.de (Postfix) with ESMTP id 6FF6FC913130 for ; Thu, 15 Apr 2010 17:47:28 +0200 (CEST) Received: from pop.mnet-online.de by diddl.denx.de with POP3 (fetchmail-6.3.9) for (single-drop); Thu, 15 Apr 2010 17:47:28 +0200 (CEST) Received: from murder (svr19.m-online.net [192.168.3.147]) by backend2 (Cyrus v2.2.12) with LMTPA; Thu, 15 Apr 2010 17:44:45 +0200 X-Sieve: CMU Sieve 2.2 Received: from mail.m-online.net (localhost [127.0.0.1]) by frontend3.pop.m-online.net (Cyrus v2.2.13) with LMTPA; Thu, 15 Apr 2010 17:44:44 +0200 Received: from scanner-2.m-online.net (unknown [192.168.8.166]) by mail.m-online.net (Postfix) with ESMTP id 6655820033C; Thu, 15 Apr 2010 17:44:44 +0200 (CEST) Received: from mxin-1.m-online.net ([192.168.6.164]) by scanner-2.m-online.net (scanner-2.m-online.net [192.168.8.166]) (amavisd-new, port 10026) with ESMTP id 03304-04-2; Thu, 15 Apr 2010 17:44:43 +0200 (CEST) Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by mxin-1.m-online.net (Postfix) with ESMTP id 68A6146C0BC; Thu, 15 Apr 2010 17:44:42 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6143F280DC; Thu, 15 Apr 2010 17:44:36 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n14WTyzHP-B3; Thu, 15 Apr 2010 17:44:36 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C602B280DD; Thu, 15 Apr 2010 17:44:31 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2E2CF280D5 for ; Thu, 15 Apr 2010 17:44:29 +0200 (CEST) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rY-z6huvj+zX for ; Thu, 15 Apr 2010 17:44:27 +0200 (CEST) X-Greylist: delayed 1666 seconds by postgrey-1.27 at theia; Thu, 15 Apr 2010 17:44:25 CEST X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from webbox687.server-home.net (webbox687.server-home.net [195.149.74.151]) by theia.denx.de (Postfix) with ESMTP id 07BC0280D1 for ; Thu, 15 Apr 2010 17:44:25 +0200 (CEST) Received: from comm.systec-electronic.de (dialbs-088-079-124-015.static.arcor-ip.net [88.79.124.15]) by webbox687.server-home.net (Postfix) with ESMTP id 07C371104F for ; Thu, 15 Apr 2010 17:16:38 +0200 (CEST) Received: from localhost.localdomain (ws-stein.systec-electronic.de [192.168.10.93]) by comm.systec-electronic.de (Postfix) with ESMTP id 08C3197C068; Thu, 15 Apr 2010 17:16:39 +0200 (CEST) From: Alexander Stein To: u-boot@lists.denx.de Date: Thu, 15 Apr 2010 17:16:25 +0200 Message-Id: <1271344585-23124-1-git-send-email-alexander.stein@systec-electronic.com> X-Mailer: git-send-email 1.6.4.4 Subject: [U-Boot] [PATCH RFC] possible typo in atmel_lcdfb.c X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de X-Virus-Scanned: by amavisd-new at m-online.net This may be a typo inside the driver, but HFP is subtracted by 2 instead of 1 like the other variables in the register. This is stated in AT91SAM9263 Summary 6249H–ATARM–27-Jul-09 p. 940 HFP: Horizontal Front Porch in LCDTIM2 So the driver should also subtract 2 to achieve the correct and exptected behavior. Of cource, in this case all sources which use already this variable must be adjusted to reflect this. Kind regards, Alexander --- drivers/video/atmel_lcdfb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c index c02ffd8..b2b7b8c 100644 --- a/drivers/video/atmel_lcdfb.c +++ b/drivers/video/atmel_lcdfb.c @@ -121,7 +121,7 @@ void lcd_ctrl_init(void *lcdbase) lcdc_writel(panel_info.mmio, ATMEL_LCDC_TIM1, value); /* Horizontal timing */ - value = (panel_info.vl_right_margin - 1) << ATMEL_LCDC_HFP_OFFSET; + value = (panel_info.vl_right_margin - 2) << ATMEL_LCDC_HFP_OFFSET; value |= (panel_info.vl_hsync_len - 1) << ATMEL_LCDC_HPW_OFFSET; value |= (panel_info.vl_left_margin - 1); lcdc_writel(panel_info.mmio, ATMEL_LCDC_TIM2, value);