From patchwork Mon Sep 9 07:57:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Heider X-Patchwork-Id: 1159624 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qS40QlLC"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 46RgW34gXRz9s4Y for ; Mon, 9 Sep 2019 17:57:33 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id E3AFDC21D9A; Mon, 9 Sep 2019 07:57:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 4F834C21C6A; Mon, 9 Sep 2019 07:57:27 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id A6F0AC21C27; Mon, 9 Sep 2019 07:57:25 +0000 (UTC) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by lists.denx.de (Postfix) with ESMTPS id 561D0C21BE5 for ; Mon, 9 Sep 2019 07:57:25 +0000 (UTC) Received: by mail-wm1-f50.google.com with SMTP id y135so12240195wmc.1 for ; Mon, 09 Sep 2019 00:57:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=ZMje0ywB9iBLU+hFXnW3qoZUrwK6dxu5f2A3tMxwA4E=; b=qS40QlLCe/Bz99puRasZ6rTIjtlZ8kmqOMcGLBHB9e4RccswXPwwpzXNmqj/h7Kr1G nxX1VYqcQH1KzY1jKl7URHheAvMzKbVp0a6uisZ2r+izKFyieQ4Fd7KF2jk431N2Hs9W ZkBRp4hqU4bU1W8ni7/yTXw2TucA6nRqvvYN8dfSpsqaUmp6RWaK6mU9h3jV27c1F96t Ax2IeeKXpmeKTCgfPrLSooEi261AyTycNgjZgwMz4M0dHsKgll7uaFcyXdWpzF4HS60Y bQtEBUIQYvH0KpUrr16/fVqkIzISsHnZeAbraohetvuYNrg4XvDxoNX6PSsgYngtIc3L yKlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=ZMje0ywB9iBLU+hFXnW3qoZUrwK6dxu5f2A3tMxwA4E=; b=nX77HNz2fzAHh+rDMBWQpGEUjJaFhXBITQ0doW/SCqhvmRPaGAfwrJFSP8DXCZLplp yDv6DuE6DQ7OsDyZZICM54w7rjADQnJtwqz5/ZwlDs5D16MBo109fofHQefICV1G/05W CS1HHMTINwIFlaB1lD1pzvGoquEO66ydoPE15p2OnaxnM/pJf2ztXT12bkeRrgrTt7DK EBk3Vej9D2u4+RhQQoYNxI7UgQ0SaQ1BwQj8mvIT4FpGgVFDoX2vDb55ucpAwx3PRfwJ QBPOpjfCF6z5UHuNvLgO9YYbyPnRakdWQIpQBXqv7SdSAlmKAubXVmNJNtNPjQB/rBZv kRUg== X-Gm-Message-State: APjAAAU4g26C+vqD/+hzmVaCRi3aUs5u8TaUHcjOOwfujj4aqdMdYJ6T Vwp3X4WvClBIyDKoeXlInoE= X-Google-Smtp-Source: APXvYqxuYzP1xqBxg2bRUrdxVlJuUwjCfRO3T0It2k2munfOFhIBZgSd0T3H8j6mRxfnfL8VDA5Pxg== X-Received: by 2002:a1c:5f0b:: with SMTP id t11mr17514364wmb.76.1568015844999; Mon, 09 Sep 2019 00:57:24 -0700 (PDT) Received: from mamamia.internal (a89-182-91-61.net-htp.de. [89.182.91.61]) by smtp.gmail.com with ESMTPSA id i73sm19495026wmg.33.2019.09.09.00.57.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Sep 2019 00:57:24 -0700 (PDT) From: Andre Heider To: U-Boot Mailing List Message-ID: <0faa10c4-0b53-de53-f5df-a64db5aae83a@gmail.com> Date: Mon, 9 Sep 2019 09:57:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Language: en-US Cc: =?utf-8?q?Nuno_Gon=C3=A7alves?= Subject: [U-Boot] TI mmc env bug? X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Hi, Nuno, I think I spotted a syntax error in 'mmcboot' while looking at unrelated boot problems on my boneblack: 27e0f3bcf07530a9cd272953797efda54ebb8f5e Totally untested though. In case it's a proper fix, I won't be around this week to send a proper patch to fix the regression fix ;) Thanks, Andre diff --git a/include/environment/ti/mmc.h b/include/environment/ti/mmc.h index ef05376608..bb4af0a3d5 100644 --- a/include/environment/ti/mmc.h +++ b/include/environment/ti/mmc.h @@ -56,7 +56,7 @@ "bootz; " \ "fi;\0" \ "mmcboot=mmc dev ${mmcdev}; " \ - "devnum ${mmcdev}; " \ + "devnum=${mmcdev}; " \ "setenv devtype mmc; " \ "if mmc rescan; then " \ "echo SD/MMC found on device ${mmcdev};" \