From patchwork Mon Aug 7 14:13:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shengyu Qu X-Patchwork-Id: 1818018 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=WwD4WtH9; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4RKJSn3ccvz1yVt for ; Tue, 8 Aug 2023 00:23:05 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E88E88469F; Mon, 7 Aug 2023 16:23:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.b="WwD4WtH9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5012E833F5; Mon, 7 Aug 2023 16:14:28 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from JPN01-TYC-obe.outbound.protection.outlook.com (mail-tycjpn01olkn2082d.outbound.protection.outlook.com [IPv6:2a01:111:f403:7010::82d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 020B980844 for ; Mon, 7 Aug 2023 16:14:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=wiagn233@outlook.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MKYBeiKqapk0ji1+rw1BOxvY46aGnRMrhq1rwbzFv1qXvoXkHzPh4pCeVNgPE7RhQHtlqEoDtqCm3efila36cUNakNu64+p22ZwlIz28dSjDJUe/vYo+XC3VHG/7+1rGT39p6wrfTgdelS64U6h86wXe/cO1nCvet37Rpd0jLmGEs5nvaJ26kyOVWjdTY1c852pO/GYs5lQmlhvn0nQ0xtwwTP7R7oi5R/k9+X3b7Gso4PakJDHKcbbpq5E/qQa8A/gBpOUyLgFmGpJq7RFJ8JU+xE/PVYPujO+KUUyeXScf7uL0vWusTZIdRNadHe0/5EdWXZEaXsJzBuVZSz9jJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XfADYLi1ylj7XNgPlX7K3xNTcnYmYoOIR92zyb0/A3s=; b=k6Y2XLK1fiQws/BXoFN5K6U2iFnirK8ES3ZIijqnuytKHpJtf3MV5TDrpJXNZ6U5Yc7kNncwPCOBJuQ1Ub+xQ0oX4yp8c0GE+IysKseCawRPOVoeT/bt+6oyF0Bf7KIJJ3JxlDA8VLzyKYUV8kP+DqTJp8M9HyAvRSplCSUKAuDTTe1YlG50MEeYDR+WrxruDePhzNZ/reT01E8KEQEjXFbSPRyy3wsR/6KbLjfB8wQhGRg03Kbx9uOiRS6MZXJF1dmTX3qX2mLMDq/2vJllUyiUV+Pnko+0AXrWFiv61odcyyj6puUQkU1hNFDDYbhoQdDSLhKAfKulsvpTfI8Vsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XfADYLi1ylj7XNgPlX7K3xNTcnYmYoOIR92zyb0/A3s=; b=WwD4WtH9FRbZn4rBWz8C9Eirw75dTOMCYs1Uin4DeSM85BEp5E51ZMBpLoFlZNjl/xI2yjfuRXkilSEuXPjAw9x0pi+zlaZU5jfBeaLDRkjuQL5sAZGY7DfSvn9Ks2WY4Dr5nzthMP7j0t+WHpeP3JGtAKy/68mxe0laAS5eYhhiieBHW8jn/29ZU4qzCXAaNdccEFGiHQpfW5ilgIvyk9mQxTTKiAaFD4fMzjnlqlpVPy9Loh3TarskjiGReg1/DmH8yZ7n8EM//M7tulp3l6txw60s+hZCMHi2hV70ef9nkqd07Ogwczq5vx/+yI0QGNqy9Ms/aElXbygpcU8zwA== Received: from TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:23e::10) by TY1P286MB3108.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:326::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Mon, 7 Aug 2023 14:14:19 +0000 Received: from TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM ([fe80::e67d:f61a:b248:f597]) by TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM ([fe80::e67d:f61a:b248:f597%3]) with mapi id 15.20.6652.026; Mon, 7 Aug 2023 14:14:19 +0000 From: Shengyu Qu To: rick@andestech.com, ycliang@andestech.com, bmeng@tinylab.org, ganboing@gmail.com, yanhong.wang@starfivetech.com, n.shubin@yadro.com, u-boot@lists.denx.de Cc: Shengyu Qu Subject: [PATCH v2 0/3] arch: riscv: jh7110: Correctly zero L2 LIM Date: Mon, 7 Aug 2023 22:13:52 +0800 Message-ID: X-Mailer: git-send-email 2.41.0 X-TMN: [sZ1NAJibtXXuKY7YG9l3qVfPDHzvLlav] X-ClientProxiedBy: TYCP286CA0100.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:2b4::7) To TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:23e::10) X-Microsoft-Original-Message-ID: <20230807141354.27841-2-wiagn233@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TY3P286MB2611:EE_|TY1P286MB3108:EE_ X-MS-Office365-Filtering-Correlation-Id: 77edcf96-37c2-41a9-be68-08db97509744 X-MS-Exchange-SLBlob-MailProps: dx7TrgQSB6eaOBfWSYNnkzxGUAdzQuxzJDhRarhVZWNDQlUZEMnqAjoeaolAKIjX5GwDy/UknLxmgxab/bSJJfqtgXj+Vfvna7DlIzicQXAF2vVspa/iL2X+fmFMZvnwMJcra+kQgG+91kutxxHHCRPH/h7zwWp7WUDqh0A3DmC+0YyNlSKKtNN/E0ADvfzroFT64z8BuldwpgoZz5nTFiSiEb0eAQxZL5mGVuBxEqXqrWxfaxCeWd50WHAUIU6FlfYETVantmAL5i47c/TYIbLO7DVFQYDyqW45NAAyallOsVr9sgXwNyJy+ly9crAV14cmwmTIuEFsmdwXvVmwTXmIQrRSMytRzHdzQOj/yZvLCTQkwZVmdz4GRzTFkJx5FYJtR3B+tIw/y93HvoHh59aEqCRFSvxCihVTUgBiXdxckMCVt71POhu8uIL2/Bmi0E6aoRVbxvmDfhmSvK2zks1fKPySJ5BDZyGLoGn5u0ukOpvEmpnZOw7C0DRjGgZs6u7R39n1TppvK0e8AoLo90yM6UXay6D8HNoLVh5F2/lyaEkoxyoQyc49J64yr7lVzrFZtU9XtEs3q9B4v9buCyhFJqp+r0Q1KsJQqBsesJ2mEaiqfa/tclP1LNvQHpQOPU60escwMHdU5zJp7xLryXMztqekwTpaCfdaqNEijQ8rm9LS+z9xMHGv+IzRx9cOceBu3CFpAdUsnbBxqYN6aAXUQLbQ2YPRIcMvA0+7RIDexlOPSPSOcpGpIDS3vuZss5xhgppWUxk= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 74PIH6w3MiBInr7xB4V/FYWhQapJkxk9InA0No+HC/c1VRGlNdKjWoQMwQE+rtqd4QFG+UoR1KEbp2uce3Uy6DxrjsI9I2jeyzlsyp+jGWKUftkHTdd4ln0sY/H2MBZLRlXsRX6e4dW0RGa5MHBfkSK/hh6nn5rHPtXyY7krLr7Ez/tF0qMuptcflACsuWiDP/HN1hQAqxgeGpx6Wn1D3d8zVHXzLuLv4lUfktJJAkzkb4RiUv0A6YwDBWvEXfH2gat04OKp6FqxzTd6Y80nGCiKrOXW+9uGipDWKB+GL6s459LOkeRMIWziy4Cx/4Kkz1ZCfzlCKLZSv79deFXHd0tQAOJ6t0UOuA7Vh68DhS8czQ2nsMtw56dcuG10jMBlLaNS24tD4YeWFCWcFvDdkT9CPsPChd+VuKA9OPJOUgVAjXtXIJ+M5ddEayKGgsCDpRTG5thZNpOgOuTKpL9PJAL7HFLmuICbVKKkNt9A0y3obVLxrsbkiM2dnbIe8ICrB39bP7LMvvkgZSWJPFQkmT5OI2s9zdIZxc7g2r73QqPta5UxPpk0NR7dOn07oPaimMQjc4dvGZQpJSHlQNWH1t30hZP9kLtVrn3mnAq76LXA7kBr3NBIKHpdeyUG/DUQ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oNX2WiYYWf6ifnlq1Xi2EcKt/u72vPjoHrzKRUDn9lEvsyFT7vXpK9T7SCtoMnd/Xlww5jDdEqVuFA7vPc+AlD3L1/+Nlg6F0l3nwjm5wo9pG4dqz+6IhTFi09zOuytVz4qaN/slnMQ8krqgBnxNsfBUWxPekpZPwoN2IcUXBUJJr3eLRL2Z5zPan6GqEux4tSdzJ4U1OQAe59H0zJcimHnA8L2u6YeKQBhgNbHg4o7ZXzFJ3rpVACZ3GKB3XjRqckh8VHoOXa3YuzCyzMS9npS9x2de4cW7C6vGFoA/bkFwk5JYuVRaYqkaxy1umYzZmsw7OFuCcbxk7ZvxWpFhIIOC/kjc33z04c6dLlDqK/IDcdvnWpMsqXy2iNXC2oZua6gI9k0rYzg8Laf2/k/RqwEwBHhrxtngbG4f9kKo8fziIiR0fNPshnsEj1pkR//cCD33UyHNkl8bHBjr6HAevcxx8k+JCJpyYuQY/45lXRSC7iy0iQYY/zLnLLQe3PVIq680G3h3SA3bx0cD3huX0vZt+n/xSgIe8kgpjlwuzbPgQtubwMqGYVOoiGolsm06zT8+V7MG6el1ZsfbAexamSaTnBt8sGq3IPUc8ofXmmlP/slbnM+jAMWh6oW3fyT3UIlEKNa5E9e6yVa03/mD7nnfnq3VXS3NAncKW2jhQKRDOOU+iDlyupctPc728lnVyA42E1DS3IN0EkF9/MS4BNksUP5QRNdCiDkeRj6I1subH+k/0U+kLXLHCLkl2eYW+MDOvDPF4iTyuoKLiQ6JJFPpuNFeOdNly760KyiuoM5kLJwhtUFtqgTotggCAJa10Rtc+IxP3iPGzGV1loa3FHPgeONIvMim03qQlWyqEiPHbKxZuUMjCaEBOhZW13NPC/+mRJwQq0UUIrKKaocYjZDRZ5Q5rXuNjgMVcr6RtzBOmaCrUNHgXeSkIYgSL2Mnt4KW7hPn2gfcSDz5Gxz7V4cIvJptImbowZ/rtBchQGezb8Ghct+2GUkSW/Z/E8Q//j9RojkroBBbD7YEEcsZOi2Lpe+t21h6gPvU9htPcflse9Qc3qa+qrilmYarfmAW4CLni8Rb3gkQfVX2XKo/55ypyLqfssw9BcM3Su3Gd0uvCs+Bhj9ijPzf+gtqtHDJIUNZHCQqVmNTfy/kqYuQo+jpBvaZDkQ5ZFSX5IiamkCirhOiONAeZZV34ubT7+QO7m9RastFe8w1B1ONk08org== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77edcf96-37c2-41a9-be68-08db97509744 X-MS-Exchange-CrossTenant-AuthSource: TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2023 14:14:19.7842 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1P286MB3108 X-Mailman-Approved-At: Mon, 07 Aug 2023 16:22:59 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This series is the second version of Bo Gan's L2 LIM series. Original author hasn't sent v2 for almost 2 months, so I decided to take over this series. Background information: JH7110 SPL runs in L2 LIM (2M in size mapped at 0x8000000). It consists of 16 0x20000 sized regions, each one can be used as either L2 cache way or SRAM (not both). From top to bottom, there're ways 0-15. The way 0 is always enabled, at most 0x1e0000 can be used. In SPL, we don't enable any cache ways, thus all 15 (except way 0) ways can be used. However, due to HW requirement, we must zero the LIM before use. This is because ECC is applied to LIM, and if not cleared first, the ECC part is invalid, which can trigger ECC errors when reading/writing data. There are several issues currently. We clear L2 LIM from __bss_end to 0x81FFFFF in `harts_early_init`. This is wrong because: 1. Each hart (in the middle of a function call) overwriting its own stack and other harts' stacks. (data-race and data-corruption) 2. Lottery winner hart can be doing `board_init_f_init_reserve`, while other harts're in the middle of zeroing L2 LIM. (data-race) Changes since v1: - Seperate single patch into several patches Shengyu Qu (3): riscv: Kconfig: Add SPL_ZERO_MEM_BEFORE_USE riscv: Add ZERO_MEM_BEFORE_USE implementation riscv: cpu: jh7110: Select SPL_ZERO_MEM_BEFORE_USE arch/riscv/Kconfig | 8 ++++++++ arch/riscv/cpu/jh7110/Kconfig | 1 + arch/riscv/cpu/jh7110/spl.c | 25 ------------------------- arch/riscv/cpu/start.S | 12 ++++++++++++ common/init/board_init.c | 3 +++ 5 files changed, 24 insertions(+), 25 deletions(-)