| Message ID | 20241017200039.1235524-1-jonas@kwiboo.se |
|---|---|
| Headers | show |
| Series | rockchip: Add support for FriendlyElec NanoPC-T6 LTS | expand |
Hello Jonas and Marcin, On 2024-10-17 22:00, Jonas Karlman wrote: > This series picks minimum required commits from v6.12-rc1-dts to add > initial support for the FriendlyElec NanoPC-T6 LTS variant. > > The adc-uclass and rockchip-saradc drivers are adopted to support cases > when DM_REGULATOR is disabled and using a fallback voltage reference > from the vdd-microvolts prop in DT. > > Finally board specific code is added to help detect non-LTS vs LTS > variant at runtime and nanopc-t6-rk3588_defconfig is extended to enable > Kconfig options for updated DTs. > > Please note that this has only been runtime tested on a non-LTS variant > of a NanoPC-T6 board. Could you, please, have a look at my patch that I recently submitted to the linux-rockchip mailing list? [1] To sum it up, my patch does some of the same work you did in this series, by resolving the troublesome inclusion of all Rockchip board dts files in one fell swoop, and I'd appreciate if you could review those changes. [1] https://lore.kernel.org/linux-rockchip/f3d789c14fe34a53327cac03cd3837e530e21f5c.1728937091.git.dsimic@manjaro.org/T/#u > Jonas Karlman (4): > rockchip: rk3588-nanopc-t6: Drop upstream props from u-boot.dtsi > adc: Allow use of adc with DM_REGULATOR disabled > adc: rockchip-saradc: Use vdd-microvolts prop as fallback > rockchip: rk3588-nanopc-t6: Add support for NanoPC-T6 LTS > > Marcin Juszkiewicz (4): > arm64: dts: rockchip: prepare NanoPC-T6 for LTS board > arm64: dts: rockchip: move NanoPC-T6 parts to DTS > arm64: dts: rockchip: add NanoPC-T6 LTS > arm64: dts: rockchip: add SPI flash on NanoPC-T6 > > arch/arm/dts/rk3588-nanopc-t6-u-boot.dtsi | 16 +- > board/friendlyelec/nanopc-t6-rk3588/Makefile | 3 + > .../nanopc-t6-rk3588/nanopc-t6-rk3588.c | 59 ++ > configs/nanopc-t6-rk3588_defconfig | 12 + > drivers/adc/adc-uclass.c | 4 +- > drivers/adc/rockchip-saradc.c | 9 +- > .../arm64/rockchip/rk3588-nanopc-t6-lts.dts | 60 ++ > .../src/arm64/rockchip/rk3588-nanopc-t6.dts | 909 +---------------- > .../src/arm64/rockchip/rk3588-nanopc-t6.dtsi | 943 ++++++++++++++++++ > 9 files changed, 1092 insertions(+), 923 deletions(-) > create mode 100644 board/friendlyelec/nanopc-t6-rk3588/Makefile > create mode 100644 > board/friendlyelec/nanopc-t6-rk3588/nanopc-t6-rk3588.c > create mode 100644 > dts/upstream/src/arm64/rockchip/rk3588-nanopc-t6-lts.dts > create mode 100644 > dts/upstream/src/arm64/rockchip/rk3588-nanopc-t6.dtsi
W dniu 17.10.2024 o 22:00, Jonas Karlman pisze: > Finally board specific code is added to help detect non-LTS vs LTS > variant at runtime and nanopc-t6-rk3588_defconfig is extended to enable > Kconfig options for updated DTs. > > Please note that this has only been runtime tested on a non-LTS variant > of a NanoPC-T6 board. As owner of NanoPC-T6 LTS variant I report that it detects it properly: U-Boot 2024.10-01079-g096e83da0bc7 (Oct 18 2024 - 07:31:07 +0200) Model: FriendlyElec NanoPC-T6 LTS DRAM: 16 GiB PMIC: RK806 (on=0x10, off=0x00) Core: 375 devices, 33 uclasses, devicetree: separate MMC: mmc@fe2c0000: 1, mmc@fe2e0000: 0 Loading Environment from nowhere... OK In: serial@feb50000 Out: serial@feb50000 Err: serial@feb50000 Model: FriendlyElec NanoPC-T6 LTS Net: No ethernet found. Hit any key to stop autoboot: 0 => Tested-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>