| Message ID | 20240911-j784s4-esm-enable-v2-0-957f56b588d9@redhat.com |
|---|---|
| Headers | show |
| Series | k3-j784s4-r5-evm: Enable ESMs and related PMIC | expand |
Andrew Thanks, On 9/11/2024 11:09 PM, Andrew Halaney wrote: > NOTE: this relies on the linked devicetree changes to land in Linux > first and get synced here, otherwise the board will fail to boot! > I'm leaving this as a RFC/RFT at this time for that reason until > things get merged and synced over (if there's a faster way to get that > done please let me know, otherwise I'll be patient. Maybe the > cherry-picking described over at > https://docs.u-boot.org/en/latest/develop/devicetree/control.html#resyncing-with-devicetree-rebasing > would be appropriate to do *in* this series after that is merged in > Linux?). > > This enables the ESMs and the associated PMIC. Programming these bits is > a requirement to make the watchdog actually reset the board. > > I've tested this series (with the linked change) on the k3-j784s4-evm, > but not its sibling the k3-am69-sk. I'd appreciate at a minimum someone > to test on that platform to ensure this doesn't break boot. > > Link: https://lore.kernel.org/lkml/20240911-j784s4-tps6594-bootph-v2-0-a83526264ab1@redhat.com/ > Signed-off-by: Andrew Halaney <ahalaney@redhat.com> > --- > Changes in v2: > - Loop over ESMs, only configure if prior was successful > as without all of them they're not useful (Udit) > - Add am69-sk PMIC ESM node (Udit) > - Link to v1: https://lore.kernel.org/r/20240906-j784s4-esm-enable-v1-0-b83b17d5a744@redhat.com LGTM For AM69, please use Tested-by: Udit Kumar <u-kumar1@ti.com> Test logs (WDT working as expected) after locally applying patch https://lore.kernel.org/lkml/20240911-j784s4-tps6594-bootph-v2-0-a83526264ab1@redhat.com/ into u-boot DTS. https://gist.github.com/uditkumarti/3ec9afac94c081d09515b66b7ae6c0e5 > --- > Andrew Halaney (2): > arm: dts: k3-am69-r5-evm: Add the PMIC ESM node > configs: j784s4_evm_r5: Enable ESM related configs > > Keerthy (1): > board: ti: j784s4: Initialize the ESM & PMIC ESM > > Neha Malcom Francis (1): > arm: dts: k3-j784s4-r5-evm: Add the PMIC ESM node > > arch/arm/dts/k3-am69-r5-sk.dts | 7 +++++++ > arch/arm/dts/k3-j784s4-r5-evm.dts | 7 +++++++ > board/ti/j784s4/evm.c | 24 ++++++++++++++++++++++++ > configs/j784s4_evm_r5_defconfig | 7 +++++++ > 4 files changed, 45 insertions(+) > --- > base-commit: 1630ff26cc960439b5949b80cfc604a2c8aa47dd > change-id: 20240906-j784s4-esm-enable-4c4f698fe7c4 > > Best regards,
NOTE: this relies on the linked devicetree changes to land in Linux first and get synced here, otherwise the board will fail to boot! I'm leaving this as a RFC/RFT at this time for that reason until things get merged and synced over (if there's a faster way to get that done please let me know, otherwise I'll be patient. Maybe the cherry-picking described over at https://docs.u-boot.org/en/latest/develop/devicetree/control.html#resyncing-with-devicetree-rebasing would be appropriate to do *in* this series after that is merged in Linux?). This enables the ESMs and the associated PMIC. Programming these bits is a requirement to make the watchdog actually reset the board. I've tested this series (with the linked change) on the k3-j784s4-evm, but not its sibling the k3-am69-sk. I'd appreciate at a minimum someone to test on that platform to ensure this doesn't break boot. Link: https://lore.kernel.org/lkml/20240911-j784s4-tps6594-bootph-v2-0-a83526264ab1@redhat.com/ Signed-off-by: Andrew Halaney <ahalaney@redhat.com> --- Changes in v2: - Loop over ESMs, only configure if prior was successful as without all of them they're not useful (Udit) - Add am69-sk PMIC ESM node (Udit) - Link to v1: https://lore.kernel.org/r/20240906-j784s4-esm-enable-v1-0-b83b17d5a744@redhat.com --- Andrew Halaney (2): arm: dts: k3-am69-r5-evm: Add the PMIC ESM node configs: j784s4_evm_r5: Enable ESM related configs Keerthy (1): board: ti: j784s4: Initialize the ESM & PMIC ESM Neha Malcom Francis (1): arm: dts: k3-j784s4-r5-evm: Add the PMIC ESM node arch/arm/dts/k3-am69-r5-sk.dts | 7 +++++++ arch/arm/dts/k3-j784s4-r5-evm.dts | 7 +++++++ board/ti/j784s4/evm.c | 24 ++++++++++++++++++++++++ configs/j784s4_evm_r5_defconfig | 7 +++++++ 4 files changed, 45 insertions(+) --- base-commit: 1630ff26cc960439b5949b80cfc604a2c8aa47dd change-id: 20240906-j784s4-esm-enable-4c4f698fe7c4 Best regards,