mbox series

[00/15] binman: More patches to support VBE

Message ID 20240826191143.426387-1-sjg@chromium.org
Headers show
Series binman: More patches to support VBE | expand

Message

Simon Glass Aug. 26, 2024, 7:11 p.m. UTC
This series provides a number of patches to make VBE easier to
implement, particularly with the new OF_UPSTREAM option.


Simon Glass (15):
  binman: Fix up test coverage for mkeficapsule
  binman: Correct the comment for fdtgrep
  binman: Tidy up comments for Entry.GetEntryArgsOrProps()
  binman: Tidy up comments and pylint warnings in fit
  binman: Avoid setting the image_pos attribute directly
  binman: Update fdt-list-dir to use the provided directory
  binman: fit: Avoid assuming that a FIT member is a section
  binman: fit: Set the image_pos attributes only once
  binman: fit: Refine handling of devicetrees for OF_UPSTREAM
  binman: Adjust naming for reading symbols
  binman: Add minor improvements to symbol-writing
  binman: Provide a way to set the symbol base address
  binman: Unwind the end-at-4gb special-case a little
  binman: Allow image_pos to be None when writing symbols
  binman: Make a start on an iMX8 test

 tools/binman/binman.rst                       |  19 ++-
 tools/binman/btool/fdtgrep.py                 |   3 +-
 tools/binman/elf.py                           |  14 +-
 tools/binman/elf_test.py                      |   4 +-
 tools/binman/entry.py                         |  25 ++-
 tools/binman/etype/atf_fip.py                 |   2 +-
 tools/binman/etype/blob_phase.py              |   5 +
 tools/binman/etype/cbfs.py                    |   2 +-
 tools/binman/etype/efi_capsule.py             |   2 +
 tools/binman/etype/fit.py                     | 116 ++++++++-----
 tools/binman/etype/nxp_imx8mimage.py          |   3 +-
 tools/binman/etype/section.py                 |  31 ++--
 tools/binman/ftest.py                         | 152 +++++++++++++++---
 tools/binman/image.py                         |  21 ++-
 tools/binman/image_test.py                    |   8 +-
 tools/binman/test/336_symbols_base.dts        |  23 +++
 tools/binman/test/337_symbols_base_expand.dts |  24 +++
 tools/binman/test/338_symbols_comp.dts        |  26 +++
 tools/binman/test/339_nxp_imx8.dts            |  17 ++
 19 files changed, 386 insertions(+), 111 deletions(-)
 create mode 100644 tools/binman/test/336_symbols_base.dts
 create mode 100644 tools/binman/test/337_symbols_base_expand.dts
 create mode 100644 tools/binman/test/338_symbols_comp.dts
 create mode 100644 tools/binman/test/339_nxp_imx8.dts

Comments

Peter Robinson Aug. 28, 2024, 10:01 a.m. UTC | #1
On Mon, 26 Aug 2024 at 20:11, Simon Glass <sjg@chromium.org> wrote:
>
> This series provides a number of patches to make VBE easier to
> implement, particularly with the new OF_UPSTREAM option.

How? They mostly look unrelated to VBE.

>
> Simon Glass (15):
>   binman: Fix up test coverage for mkeficapsule
>   binman: Correct the comment for fdtgrep
>   binman: Tidy up comments for Entry.GetEntryArgsOrProps()
>   binman: Tidy up comments and pylint warnings in fit
>   binman: Avoid setting the image_pos attribute directly
>   binman: Update fdt-list-dir to use the provided directory
>   binman: fit: Avoid assuming that a FIT member is a section
>   binman: fit: Set the image_pos attributes only once
>   binman: fit: Refine handling of devicetrees for OF_UPSTREAM
>   binman: Adjust naming for reading symbols
>   binman: Add minor improvements to symbol-writing
>   binman: Provide a way to set the symbol base address
>   binman: Unwind the end-at-4gb special-case a little
>   binman: Allow image_pos to be None when writing symbols
>   binman: Make a start on an iMX8 test
>
>  tools/binman/binman.rst                       |  19 ++-
>  tools/binman/btool/fdtgrep.py                 |   3 +-
>  tools/binman/elf.py                           |  14 +-
>  tools/binman/elf_test.py                      |   4 +-
>  tools/binman/entry.py                         |  25 ++-
>  tools/binman/etype/atf_fip.py                 |   2 +-
>  tools/binman/etype/blob_phase.py              |   5 +
>  tools/binman/etype/cbfs.py                    |   2 +-
>  tools/binman/etype/efi_capsule.py             |   2 +
>  tools/binman/etype/fit.py                     | 116 ++++++++-----
>  tools/binman/etype/nxp_imx8mimage.py          |   3 +-
>  tools/binman/etype/section.py                 |  31 ++--
>  tools/binman/ftest.py                         | 152 +++++++++++++++---
>  tools/binman/image.py                         |  21 ++-
>  tools/binman/image_test.py                    |   8 +-
>  tools/binman/test/336_symbols_base.dts        |  23 +++
>  tools/binman/test/337_symbols_base_expand.dts |  24 +++
>  tools/binman/test/338_symbols_comp.dts        |  26 +++
>  tools/binman/test/339_nxp_imx8.dts            |  17 ++
>  19 files changed, 386 insertions(+), 111 deletions(-)
>  create mode 100644 tools/binman/test/336_symbols_base.dts
>  create mode 100644 tools/binman/test/337_symbols_base_expand.dts
>  create mode 100644 tools/binman/test/338_symbols_comp.dts
>  create mode 100644 tools/binman/test/339_nxp_imx8.dts
>
> --
> 2.34.1
>
Simon Glass Aug. 29, 2024, 3:01 p.m. UTC | #2
Hi Peter,

On Wed, 28 Aug 2024 at 04:01, Peter Robinson <pbrobinson@gmail.com> wrote:
>
> On Mon, 26 Aug 2024 at 20:11, Simon Glass <sjg@chromium.org> wrote:
> >
> > This series provides a number of patches to make VBE easier to
> > implement, particularly with the new OF_UPSTREAM option.
>
> How? They mostly look unrelated to VBE.

- we need binman symbols which provide a disk offset, not an address
- we need to have a compressed section containing VPL, meaning that
there is no valid image-pos for things within that section
- we need to be able to locate the devicetree when OF_UPSTREAM is used

The iMX8 one is for Marek, as until that is fixed I cannot enable
code-coverage in Binman in CI, which I very-much want to do with VBE.

>
> >
> > Simon Glass (15):
> >   binman: Fix up test coverage for mkeficapsule
> >   binman: Correct the comment for fdtgrep
> >   binman: Tidy up comments for Entry.GetEntryArgsOrProps()
> >   binman: Tidy up comments and pylint warnings in fit
> >   binman: Avoid setting the image_pos attribute directly
> >   binman: Update fdt-list-dir to use the provided directory
> >   binman: fit: Avoid assuming that a FIT member is a section
> >   binman: fit: Set the image_pos attributes only once
> >   binman: fit: Refine handling of devicetrees for OF_UPSTREAM
> >   binman: Adjust naming for reading symbols
> >   binman: Add minor improvements to symbol-writing
> >   binman: Provide a way to set the symbol base address
> >   binman: Unwind the end-at-4gb special-case a little
> >   binman: Allow image_pos to be None when writing symbols
> >   binman: Make a start on an iMX8 test
> >
> >  tools/binman/binman.rst                       |  19 ++-
> >  tools/binman/btool/fdtgrep.py                 |   3 +-
> >  tools/binman/elf.py                           |  14 +-
> >  tools/binman/elf_test.py                      |   4 +-
> >  tools/binman/entry.py                         |  25 ++-
> >  tools/binman/etype/atf_fip.py                 |   2 +-
> >  tools/binman/etype/blob_phase.py              |   5 +
> >  tools/binman/etype/cbfs.py                    |   2 +-
> >  tools/binman/etype/efi_capsule.py             |   2 +
> >  tools/binman/etype/fit.py                     | 116 ++++++++-----
> >  tools/binman/etype/nxp_imx8mimage.py          |   3 +-
> >  tools/binman/etype/section.py                 |  31 ++--
> >  tools/binman/ftest.py                         | 152 +++++++++++++++---
> >  tools/binman/image.py                         |  21 ++-
> >  tools/binman/image_test.py                    |   8 +-
> >  tools/binman/test/336_symbols_base.dts        |  23 +++
> >  tools/binman/test/337_symbols_base_expand.dts |  24 +++
> >  tools/binman/test/338_symbols_comp.dts        |  26 +++
> >  tools/binman/test/339_nxp_imx8.dts            |  17 ++
> >  19 files changed, 386 insertions(+), 111 deletions(-)
> >  create mode 100644 tools/binman/test/336_symbols_base.dts
> >  create mode 100644 tools/binman/test/337_symbols_base_expand.dts
> >  create mode 100644 tools/binman/test/338_symbols_comp.dts
> >  create mode 100644 tools/binman/test/339_nxp_imx8.dts
> >
> > --
> > 2.34.1
> >

Regards,
SImon