mbox series

[v2,0/3] arm: dts: am62-beagleplay: Fix Beagleplay Ethernet

Message ID 20240513-for-2024-07-beagleplay-eth-v2-0-a9bf457c3bb8@kernel.org
Headers show
Series arm: dts: am62-beagleplay: Fix Beagleplay Ethernet | expand

Message

Roger Quadros May 13, 2024, 12:13 p.m. UTC
Sync AM62 device tree files with Linux v6.9 and
add in the missing bits in -u-boot.dtsi to get CPSW
Ethernet working.

CI testing
https://github.com/u-boot/u-boot/pull/534

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---

---
Changes in v2:
- rebase on u-boot/next 13th May 2024
- drop 'not-for-merge' comment for patch 3 as it can now be merged
- Link to v1: https://lore.kernel.org/r/20240425-for-2024-07-beagleplay-eth-v1-0-6c985de1c316@kernel.org

---
Roger Quadros (3):
      arm: dts: k3-am62*: sync with Linux v6.9
      arm: dts: k3-am625-beagleplay: get CPSW Ethernet to work
      arm: dts: k3-am625-beagleplay: Fix Ethernet PHY reset GPIO

 arch/arm/dts/k3-am62-main.dtsi               | 126 ++++++++++++++---
 arch/arm/dts/k3-am62-mcu.dtsi                |   4 +-
 arch/arm/dts/k3-am62-thermal.dtsi            |   5 +-
 arch/arm/dts/k3-am62-wakeup.dtsi             |  38 +++--
 arch/arm/dts/k3-am62.dtsi                    |   4 +-
 arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi |  63 +++++++++
 arch/arm/dts/k3-am625-beagleplay.dts         |  66 ++++-----
 arch/arm/dts/k3-am625-sk.dts                 |   4 +-
 arch/arm/dts/k3-am625.dtsi                   |   4 +-
 arch/arm/dts/k3-am62a-main.dtsi              | 201 +++++++++++++++++++++++++--
 arch/arm/dts/k3-am62a-mcu.dtsi               |   4 +-
 arch/arm/dts/k3-am62a-thermal.dtsi           |   5 +-
 arch/arm/dts/k3-am62a-wakeup.dtsi            |   4 +-
 arch/arm/dts/k3-am62a.dtsi                   |   4 +-
 arch/arm/dts/k3-am62a7-sk.dts                | 162 ++++++++++++++++++++-
 arch/arm/dts/k3-am62a7.dtsi                  |   4 +-
 arch/arm/dts/k3-am62x-sk-common.dtsi         |  24 +++-
 17 files changed, 621 insertions(+), 101 deletions(-)
---
base-commit: c67199962b2a819a4b0ae8d57dc68b7cadee0c9e
change-id: 20240305-for-2024-07-beagleplay-eth-f82a51197937

Best regards,

Comments

Tom Rini May 13, 2024, 5:48 p.m. UTC | #1
On Mon, 13 May 2024 15:13:53 +0300, Roger Quadros wrote:

> Sync AM62 device tree files with Linux v6.9 and
> add in the missing bits in -u-boot.dtsi to get CPSW
> Ethernet working.
> 
> CI testing
> https://github.com/u-boot/u-boot/pull/534
> 
> [...]

Applied to u-boot/master, thanks!
Tom Rini May 20, 2024, 3:56 p.m. UTC | #2
On Mon, 13 May 2024 15:13:53 +0300, Roger Quadros wrote:

> Sync AM62 device tree files with Linux v6.9 and
> add in the missing bits in -u-boot.dtsi to get CPSW
> Ethernet working.
> 
> CI testing
> https://github.com/u-boot/u-boot/pull/534
> 
> [...]

Applied to u-boot/next, thanks!
Roger Quadros May 31, 2024, 4:32 p.m. UTC | #3
Hi Tom,

On 20/05/2024 18:56, Tom Rini wrote:
> On Mon, 13 May 2024 15:13:53 +0300, Roger Quadros wrote:
> 
>> Sync AM62 device tree files with Linux v6.9 and
>> add in the missing bits in -u-boot.dtsi to get CPSW
>> Ethernet working.
>>
>> CI testing
>> https://github.com/u-boot/u-boot/pull/534
>>
>> [...]
> 
> Applied to u-boot/next, thanks!
> 

I see that this series was applied to u-boot master as well
and then later reverted by commit d678a59d2d719da9e807495b4b021501f2836ca5
as it was based on u-boot/next

Can I re-send this series based on u-boot/master so it can be still applied to master?
Without this Ethernet is broken on beagleplay.
Tom Rini May 31, 2024, 4:47 p.m. UTC | #4
On Fri, May 31, 2024 at 07:32:37PM +0300, Roger Quadros wrote:
> Hi Tom,
> 
> On 20/05/2024 18:56, Tom Rini wrote:
> > On Mon, 13 May 2024 15:13:53 +0300, Roger Quadros wrote:
> > 
> >> Sync AM62 device tree files with Linux v6.9 and
> >> add in the missing bits in -u-boot.dtsi to get CPSW
> >> Ethernet working.
> >>
> >> CI testing
> >> https://github.com/u-boot/u-boot/pull/534
> >>
> >> [...]
> > 
> > Applied to u-boot/next, thanks!
> > 
> 
> I see that this series was applied to u-boot master as well
> and then later reverted by commit d678a59d2d719da9e807495b4b021501f2836ca5
> as it was based on u-boot/next
> 
> Can I re-send this series based on u-boot/master so it can be still applied to master?
> Without this Ethernet is broken on beagleplay.

Was ethernet working on v2024.04?
Roger Quadros May 31, 2024, 4:53 p.m. UTC | #5
Tom,

On 31/05/2024 19:32, Roger Quadros wrote:
> Hi Tom,
> 
> On 20/05/2024 18:56, Tom Rini wrote:
>> On Mon, 13 May 2024 15:13:53 +0300, Roger Quadros wrote:
>>
>>> Sync AM62 device tree files with Linux v6.9 and
>>> add in the missing bits in -u-boot.dtsi to get CPSW
>>> Ethernet working.
>>>
>>> CI testing
>>> https://github.com/u-boot/u-boot/pull/534
>>>
>>> [...]
>>
>> Applied to u-boot/next, thanks!
>>
> 
> I see that this series was applied to u-boot master as well
> and then later reverted by commit d678a59d2d719da9e807495b4b021501f2836ca5
> as it was based on u-boot/next
> 
> Can I re-send this series based on u-boot/master so it can be still applied to master?
> Without this Ethernet is broken on beagleplay.
> 

This series apply cleanly on u-boot/master so no need to resend.

I've created a pull request for CI loop testing on u-boot/master.

https://github.com/u-boot/u-boot/pull/572
Roger Quadros May 31, 2024, 4:54 p.m. UTC | #6
On 31/05/2024 19:47, Tom Rini wrote:
> On Fri, May 31, 2024 at 07:32:37PM +0300, Roger Quadros wrote:
>> Hi Tom,
>>
>> On 20/05/2024 18:56, Tom Rini wrote:
>>> On Mon, 13 May 2024 15:13:53 +0300, Roger Quadros wrote:
>>>
>>>> Sync AM62 device tree files with Linux v6.9 and
>>>> add in the missing bits in -u-boot.dtsi to get CPSW
>>>> Ethernet working.
>>>>
>>>> CI testing
>>>> https://github.com/u-boot/u-boot/pull/534
>>>>
>>>> [...]
>>>
>>> Applied to u-boot/next, thanks!
>>>
>>
>> I see that this series was applied to u-boot master as well
>> and then later reverted by commit d678a59d2d719da9e807495b4b021501f2836ca5
>> as it was based on u-boot/next
>>
>> Can I re-send this series based on u-boot/master so it can be still applied to master?
>> Without this Ethernet is broken on beagleplay.
> 
> Was ethernet working on v2024.04?
> 

Ah, probably not.
Tom Rini June 1, 2024, 12:13 a.m. UTC | #7
On Fri, May 31, 2024 at 07:53:24PM +0300, Roger Quadros wrote:
> Tom,
> 
> On 31/05/2024 19:32, Roger Quadros wrote:
> > Hi Tom,
> > 
> > On 20/05/2024 18:56, Tom Rini wrote:
> >> On Mon, 13 May 2024 15:13:53 +0300, Roger Quadros wrote:
> >>
> >>> Sync AM62 device tree files with Linux v6.9 and
> >>> add in the missing bits in -u-boot.dtsi to get CPSW
> >>> Ethernet working.
> >>>
> >>> CI testing
> >>> https://github.com/u-boot/u-boot/pull/534
> >>>
> >>> [...]
> >>
> >> Applied to u-boot/next, thanks!
> >>
> > 
> > I see that this series was applied to u-boot master as well
> > and then later reverted by commit d678a59d2d719da9e807495b4b021501f2836ca5
> > as it was based on u-boot/next
> > 
> > Can I re-send this series based on u-boot/master so it can be still applied to master?
> > Without this Ethernet is broken on beagleplay.
> > 
> 
> This series apply cleanly on u-boot/master so no need to resend.
> 
> I've created a pull request for CI loop testing on u-boot/master.

Note that the base commit was on -next I believe and so that's what lead
b4 to pull in -next changes that I wasn't expecting. I have tooling in
place now to catch this in the future.