mbox series

[0/2] phy: rockchip-inno-usb2: Write to correct GRF

Message ID 20240225221024.1974853-1-jonas@kwiboo.se
Headers show
Series phy: rockchip-inno-usb2: Write to correct GRF | expand

Message

Jonas Karlman Feb. 25, 2024, 10:10 p.m. UTC 
This series fixes an issue where the rockchip-inno-usb2 driver is
writing to wrong GRF reg for RK3328, RK356x and RK3588.

The driver is currently always using the common GRF, something that is
only correct for RK3399. Remaining SoCs have USB2PHY regs in a different
or dedicated usb2phy GRF.

First patch changes to use regmap functions and gets the regmap for
correct GRF, from rockchip,usbgrf phandle or parent device.

Second patch reduces to only configure utmi_suspend_n and utmi_sel bits,
similar to how is done for RK3399.

USB have continued to work in device and host mode on all supported SoCs
with this series applied.

Jonas Karlman (2):
  phy: rockchip-inno-usb2: Write to correct GRF
  phy: rockchip-inno-usb2: Limit changes made to regs

 drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 158 ++++--------------
 1 file changed, 36 insertions(+), 122 deletions(-)