From patchwork Wed Apr 12 10:58:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dhruva Gole X-Patchwork-Id: 1768022 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256 header.s=ti-com-17Q1 header.b=xGY6rLgw; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PxKTm10MLz1yZk for ; Wed, 12 Apr 2023 20:59:22 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A036485F77; Wed, 12 Apr 2023 12:59:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="xGY6rLgw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9E62985F7D; Wed, 12 Apr 2023 12:59:09 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEXHASH_WORD, SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A4E2585F2B for ; Wed, 12 Apr 2023 12:59:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=d-gole@ti.com Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33CAx2fB125605; Wed, 12 Apr 2023 05:59:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1681297142; bh=Eobd/99E1A5cmudEtgvQZF416q3ro2/GQ7sE2LZuO48=; h=From:To:CC:Subject:Date; b=xGY6rLgw2D38iKUVwHIUT/mT8+K+wNVmyI35nJGK0uz8g1xFz3dnGSqW3+L9sEc5f xpB2bt8P+kcNsXaBdY4Zg0168BdUCCJ6vMSacN6JmbyXkQl5rh7ox/Qt0pEB937og+ vOYmypuwBwpsEqAdZh68dBZlKx0hAGif5IKJP84A= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33CAx2V6025071 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 Apr 2023 05:59:02 -0500 Received: from DLEE101.ent.ti.com (157.170.170.31) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Wed, 12 Apr 2023 05:59:02 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE101.ent.ti.com (157.170.170.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Wed, 12 Apr 2023 05:59:01 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33CAx02J018642; Wed, 12 Apr 2023 05:59:01 -0500 From: Dhruva Gole To: Jagan Teki CC: Dhruva Gole , Vaishnav Achath , Pratyush Yadav , Vignesh , Apurva Nandan , Subject: [PATCH V2 0/3] spi: cadence_qspi: Fixes for DTR ops and improve STIG support Date: Wed, 12 Apr 2023 16:28:53 +0530 Message-ID: <20230412105856.3565220-1-d-gole@ti.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This series aims to address some critical bugs in the cadence qspi driver like the need to Flush the CMDCTRL reg after the execution due to a hardware limitation and also fixes the check conditions for DTR ops. previously posted: https://lore.kernel.org/u-boot/20230323164408.1043725-1-d-gole@ti.com/ Changelog: * Preserve Apurva's authorship * Split the cmdctrl reg clearing patch into a seperate one * Address few other comments from Pratyush on the previous series Logs (on AM62x SK EVM): ... U-Boot 2023.04-rc5-00589-g1a9171bfbc66 (Apr 12 2023 - 16:16:19 +0530) SoC: AM62X SR1.0 HS-FS Model: Texas Instruments AM625 SK DRAM: 2 GiB Core: 50 devices, 20 uclasses, devicetree: separate MMC: mmc@fa10000: 0, mmc@fa00000: 1, mmc@fa20000: 2 Loading Environment from nowhere... OK In: serial@2800000 Out: serial@2800000 Err: serial@2800000 Net: eth0: ethernet@8000000port@1 Hit any key to stop autoboot: 0 => => sf probe SF: Detected s28hs512t with page size 256 Bytes, erase size 256 KiB, total 64 MiB => random $loadaddr 0x200000 2097152 bytes filled with random data => sf update $loadaddr 0x0 0x200000 device 0 offset 0x0, size 0x200000 2097152 bytes written, 0 bytes skipped in 13.365s, speed 160643 B/s => sf read 0x90000000 0x0 0x200000 device 0 offset 0x0, size 0x200000 SF: 2097152 bytes @ 0x0 Read: OK => cmp.b $loadaddr 0x90000000 0x200000 Total of 2097152 byte(s) were the same local git log: ... 1a9171bfbc66 (HEAD -> next) spi: cadence-quadspi: Reset CMD_CTRL Reg on cmd r/w completion f60c2702c9df spi: cadence-quadspi: Use STIG mode for all ops with small payload f84f1b610f90 spi: cadence-quadspi: Fix check condition for DTR ops a25dcda452bf (origin/next) Revert "disk: Use a helper function to reduce duplication" ... Apurva Nandan (2): spi: cadence-quadspi: Fix check condition for DTR ops spi: cadence-quadspi: Use STIG mode for all ops with small payload Dhruva Gole (1): spi: cadence-quadspi: Reset CMD_CTRL Reg on cmd r/w completion drivers/spi/cadence_qspi.c | 16 +++++++--- drivers/spi/cadence_qspi_apb.c | 56 +++++++++++++++++++++------------- 2 files changed, 46 insertions(+), 26 deletions(-)