From patchwork Mon Jan 10 20:19:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 1578247 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=WkvF5Rz/; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JXv6k0mhnz9s9c for ; Tue, 11 Jan 2022 13:00:46 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 80BD280FDA; Tue, 11 Jan 2022 03:00:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WkvF5Rz/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5960B83214; Mon, 10 Jan 2022 21:19:30 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DC7BC831CA for ; Mon, 10 Jan 2022 21:19:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=zajec5@gmail.com Received: by mail-lf1-x133.google.com with SMTP id o12so48631228lfk.1 for ; Mon, 10 Jan 2022 12:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WgypDmUvMCz+MZ1ZZHOgHc3jcylSHuXrDAiO+oCGtJU=; b=WkvF5Rz//Ioqrc25mmjtVBcM8z37AVdQPfEKKHhuCNcrjVk4HNu3ZpL46Ltc8OS9Cf smDAZe/0BvjgkH9KZjU81IOrcJ43DeyvMoQBUi2LQs4Clq9g6zqIwsb+w8VUSUnQ89/S QIKYrRttHg/bsXUOuwcEkdh5q0WQ7TZWqPLdBy+M9EQ1DsynLzAq/3Z1dPb0KWZS/pKS 3lW4D5AKZ/XwASGpE1TBJBNXAklW0ECvUV7j3aRyMbft7NKi4H7JgaUDXcSeO28/mL67 V7o8meE+4TBH7jkkdDOJhN9DX8QvZ0j+MeJoSPnOFX96SOlbF8MISDfufTG1+D1q/HlO rwNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WgypDmUvMCz+MZ1ZZHOgHc3jcylSHuXrDAiO+oCGtJU=; b=LIFjPea6eNu+W9bJ2zF8c8V5fn0YA92xtPPSa/ThxeWa1TyCXuJD1/hiNxpjomr3Mb 5dxdLIPNy9ftbr8afC26jn+9doQNT7MIOtJG4FvXYP+vp8NrAusKftW1nT6tjvsT5DZ8 5L/oME3N8cQjt783DpV1RYz94QYyoPExY/Kc1LiTmtlQKPxewqCaDXCiNEbTIZ13lPWS BD6d0QDp4JdqUUwvtB9mynnfm4BZsOCZH3cE4BLpQKLOpPHDa4J4o4j6RKQmU39nlUak OErT/Fz2F3UBU6tIqDmaBksmR0xrUXMRkg7knecPFUYkIuNggs1c29pKjprCeOM7gIVA x3Hw== X-Gm-Message-State: AOAM532+1fjxpVPS5CoGBjkbnJxPurOycv02DgUTZgbjsk2gfZIYLBQu OJnUX6ZY76msqv7DqIHkZdFEzfH2zKs= X-Google-Smtp-Source: ABdhPJynGtK9mKxI9ct45EPTs5sSmdRmpY8k/41aXoPBKUkz+1SDRKMDYpQN0S3nWyqEzJZZtI/cVQ== X-Received: by 2002:a2e:908b:: with SMTP id l11mr739928ljg.305.1641845967303; Mon, 10 Jan 2022 12:19:27 -0800 (PST) Received: from localhost.lan (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.gmail.com with ESMTPSA id a23sm1130389ljk.8.2022.01.10.12.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jan 2022 12:19:27 -0800 (PST) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: u-boot@lists.denx.de Cc: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Subject: [PATCH 0/2] fw_env: two minor code cleanups Date: Mon, 10 Jan 2022 21:19:22 +0100 Message-Id: <20220110201924.9411-1-zajec5@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 11 Jan 2022 03:00:38 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean From: Rafał Miłecki Hi, I'm a long time OpenWrt developer and just recently I started working with some devices using U-Boot. I was trying to understand how environment variables are read in user space and I had some problems understanding fw_env_open() logic. I eventually got it but I thought I may help further developers by simpliifying its code a bit. I hope you may find those patches useful and review / apply them. Rafał Miłecki (2): fw_env: make flash_io() take buffer as an argument fw_env: simplify logic & code paths in the fw_env_open() tools/env/fw_env.c | 104 +++++++++++++++++++-------------------------- 1 file changed, 44 insertions(+), 60 deletions(-)