mbox series

[0/5] Synology DS414 integration mini-review

Message ID 20210303005526.15056-1-phil@nwl.cc
Headers show
Series Synology DS414 integration mini-review | expand

Message

Phil Sutter March 3, 2021, 12:55 a.m. UTC
Board-specific code lacked a Kconfig file defining CONFIG_SYS_BOARD,
CONFIG_SYS_VENDOR, etc - patch 1 fixes that.

I was very pleased to notice the recent changes in PCI/USB code fixed
xhci-pci functionality on DS414, so patch 2 enables XHCI support in
defconfig.

Adjusting DS109 atags code for DS414 allowed to successfully boot vendor
Linux, so I went ahead and generalized the code to support both boards
in patch 3.

Patch 4 introduces a misc_init_r() routine populating environment from
Synology's special flash partition if appropriate - less manual work for
users and no need for random MAC address fallback anymore.

Patch 6 extends the default environment by a command to update u-boot
via tftp.

Phil Sutter (5):
  ds414: Add a Kconfig defining some strings
  configs: ds414: Enable XHCI_PCI by default
  board/Synology: Unify legacy kernel support
  ds414: Auto-populate env if appropriate
  ds414: Add sample u-boot update command

 board/Synology/common/Makefile  |  5 +++
 board/Synology/common/legacy.c  | 75 +++++++++++++++++++++++++++++++++
 board/Synology/common/legacy.h  | 33 +++++++++++++++
 board/Synology/ds109/ds109.c    | 32 --------------
 board/Synology/ds109/ds109.h    | 17 --------
 board/Synology/ds414/Kconfig    | 12 ++++++
 board/Synology/ds414/cmd_syno.c |  2 +-
 board/Synology/ds414/ds414.c    | 13 ++++++
 configs/ds414_defconfig         |  7 ++-
 include/configs/ds109.h         |  3 +-
 include/configs/ds414.h         | 20 ++++++++-
 11 files changed, 163 insertions(+), 56 deletions(-)
 create mode 100644 board/Synology/common/Makefile
 create mode 100644 board/Synology/common/legacy.c
 create mode 100644 board/Synology/common/legacy.h
 create mode 100644 board/Synology/ds414/Kconfig

Comments

Stefan Roese April 8, 2021, 8:52 a.m. UTC | #1
On 03.03.21 01:55, Phil Sutter wrote:
> Board-specific code lacked a Kconfig file defining CONFIG_SYS_BOARD,
> CONFIG_SYS_VENDOR, etc - patch 1 fixes that.
> 
> I was very pleased to notice the recent changes in PCI/USB code fixed
> xhci-pci functionality on DS414, so patch 2 enables XHCI support in
> defconfig.
> 
> Adjusting DS109 atags code for DS414 allowed to successfully boot vendor
> Linux, so I went ahead and generalized the code to support both boards
> in patch 3.
> 
> Patch 4 introduces a misc_init_r() routine populating environment from
> Synology's special flash partition if appropriate - less manual work for
> users and no need for random MAC address fallback anymore.
> 
> Patch 6 extends the default environment by a command to update u-boot
> via tftp.
> 
> Phil Sutter (5):
>    ds414: Add a Kconfig defining some strings
>    configs: ds414: Enable XHCI_PCI by default
>    board/Synology: Unify legacy kernel support
>    ds414: Auto-populate env if appropriate
>    ds414: Add sample u-boot update command
> 
>   board/Synology/common/Makefile  |  5 +++
>   board/Synology/common/legacy.c  | 75 +++++++++++++++++++++++++++++++++
>   board/Synology/common/legacy.h  | 33 +++++++++++++++
>   board/Synology/ds109/ds109.c    | 32 --------------
>   board/Synology/ds109/ds109.h    | 17 --------
>   board/Synology/ds414/Kconfig    | 12 ++++++
>   board/Synology/ds414/cmd_syno.c |  2 +-
>   board/Synology/ds414/ds414.c    | 13 ++++++
>   configs/ds414_defconfig         |  7 ++-
>   include/configs/ds109.h         |  3 +-
>   include/configs/ds414.h         | 20 ++++++++-
>   11 files changed, 163 insertions(+), 56 deletions(-)
>   create mode 100644 board/Synology/common/Makefile
>   create mode 100644 board/Synology/common/legacy.c
>   create mode 100644 board/Synology/common/legacy.h
>   create mode 100644 board/Synology/ds414/Kconfig
> 

Applied to u-boot-marvell/master (whole series)

Thanks,
Stefan