From patchwork Mon Jan 18 23:52:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathew McBride X-Patchwork-Id: 1428340 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=traverse.com.au header.i=@traverse.com.au header.a=rsa-sha256 header.s=fm2 header.b=ctDRHL7I; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=Gd+4fSpX; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4DKTCF0nxxz9sVr for ; Tue, 19 Jan 2021 10:53:56 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 912CB827AD; Tue, 19 Jan 2021 00:53:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=traverse.com.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=traverse.com.au header.i=@traverse.com.au header.b="ctDRHL7I"; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="Gd+4fSpX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 01CE082822; Tue, 19 Jan 2021 00:53:38 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B65BB82793 for ; Tue, 19 Jan 2021 00:53:33 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=traverse.com.au Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=matt@traverse.com.au Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B6ECF5C01F4; Mon, 18 Jan 2021 18:53:32 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 18 Jan 2021 18:53:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=traverse.com.au; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=8pXygnfujbFMQ/WZ4p71SZgl2D 0+sgtvbyf4e9zbqt8=; b=ctDRHL7IsbC5sW3ocFVNKsou8JTGDmUC49yOjJT5wU sw+kTHqCrVrVyNXMqXj6ZiUl3823KFJfYBZg0rvZH+R6Ld8cMX41EDx1/+hztkLU 8l+OoTTSO9PSf24TQECCFZuiHMoEcYgf1DsIe2teQ6F4yLBxaUZfyzKiR/UJL6mc 0PV2avwqbSz+iRhZgf97+MzDdsfptD4mOS1ex9tPb7Y2IampATt43sPLrqLpJ6Ov s34jzj6FdHdSp3DZEtuc+XAd5loeUW1bgSAq87PEQL/vjF80kBAX8Ap0N5cpP4C5 s5mhJ3rYIWtqO/iXRfv7eXyGjJDeMNENyOtMysi0gR8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=8pXygnfujbFMQ/WZ4 p71SZgl2D0+sgtvbyf4e9zbqt8=; b=Gd+4fSpXH/S/Rh3cSSAGRWiCMsL3/uVrj 56V9azgqftJiOdECM4/IWxxUGOM7E+4iGD1dOySgYo6JQLV7n9NrgwVYohxCmBAi ldwFmRDT6sq22AyztyLXZQXJ7F1RuKxHoSGbI1lF8z+0v8W4X1Fd3h4VUtB5pxYh Nzxfp9IjqmWgXKD0Fj9RV6dasUeqHg9E9Xcb1JyGykqKC4k/kaepB52uzRGtLZ21 Ful126iUvXsd9uTLBYHyt1jEjHZuHCXrDcrhn90IhBcrGQTKXECofj7hWneDbHV2 v7fK7jgO5ts2j2xgNkeyFlJXPx6tuIsm/7CjCOcXul4kGex0FfnYA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdelgddugecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgggfestdekredtredttdenucfhrhhomhepofgrthhhvgifucfo tgeurhhiuggvuceomhgrthhtsehtrhgrvhgvrhhsvgdrtghomhdrrghuqeenucggtffrrg htthgvrhhnpefgkeehgfeiheffteduheevveduuedttdetieffuefgveeutddttdegleef keelvdenucfkphepudduledrudejrdduheeirddugedunecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrthhtsehtrhgrvhgvrhhsvgdrtgho mhdrrghu X-ME-Proxy: Received: from localhost.localdomain (119-17-156-141.77119c.mel.static.aussiebb.net [119.17.156.141]) by mail.messagingengine.com (Postfix) with ESMTPA id 3963824005A; Mon, 18 Jan 2021 18:53:28 -0500 (EST) From: Mathew McBride To: Jagan Teki , u-boot@lists.denx.de Cc: Priyanka Jain , Michael Walle , Mathew McBride Subject: [PATCH 0/3] Fixes for SPI-NAND issues on LS1088A Date: Mon, 18 Jan 2021 23:52:53 +0000 Message-Id: <20210118235256.29748-1-matt@traverse.com.au> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean This patchset resolves issues seen when using SPI-NAND with the LS1088A's qspi controller. The main issue seen is data corruption when reading SPI-NAND, due to a controller quirk not being applied. Using the same settings as the LS2088A (the bigger brother of LS1088A) solves this issue. In the course of debugging the above issue, it was found that the fsl_qspi driver was not correctly reporting the operation width (single/dual/quad) configured for the device in DTS. (e.g I configured my device for single-lane reads only but quad operations were being issued) A fix for this issue is already present in Linux and can be adapted for U-Boot, providing a missing export for spi_mem_default_supports_op is added. Mathew McBride (3): mem: spi-mem: define spi_mem_default_supports_op spi: fsl_qspi: Ensure width is respected in spi-mem operations spi: fsl_qspi: apply the same settings for LS1088 as LS208x drivers/spi/fsl_qspi.c | 12 ++---------- include/spi-mem.h | 10 ++++++++++ 2 files changed, 12 insertions(+), 10 deletions(-)