mbox series

[0/3] DM_ETH v mpc83xx fixups

Message ID 20201005131518.10289-1-rasmus.villemoes@prevas.dk
Headers show
Series DM_ETH v mpc83xx fixups | expand

Message

Rasmus Villemoes Oct. 5, 2020, 1:15 p.m. UTC 
Hi Heiko

I finally managed to figure out what was wrong; the fixed-link phy was
simply ignored. This is fixed by the first patch, though I don't know
if that's the proper way to make this work.

While poking around the code I found two minor things that might as
well be fixed.

I'd also like to do a somewhat more extensive change to dm_qe_uec.c: I
find it very confusing with the qe_uec_priv versus uec_priv, so I'd
like to just add a phydev member to struct uec_priv, remove struct
qe_uec_priv, make .priv_auto_alloc_size = sizeof(struct uec_priv), and
eliminate the malloc/free pair in .prove/.remove. It's mostly
mechanical using coccinelle, but WDYT?

Rasmus Villemoes (3):
  mdio-uclass.c: support fixed-link subnodes
  dm_qe_uec.c: fix indentation in uec_set_mac_if_mode()
  uec.h: fix COFIG_DM typo

 drivers/net/qe/dm_qe_uec.c | 4 ++--
 drivers/net/qe/uec.h       | 2 +-
 net/mdio-uclass.c          | 7 +++++++
 3 files changed, 10 insertions(+), 3 deletions(-)

Comments

Heiko Schocher Oct. 6, 2020, 6:14 a.m. UTC | #1 
Hello Rasmus,

Am 05.10.2020 um 15:15 schrieb Rasmus Villemoes:
> Hi Heiko
> 
> I finally managed to figure out what was wrong; the fixed-link phy was
> simply ignored. This is fixed by the first patch, though I don't know
> if that's the proper way to make this work.
> 
> While poking around the code I found two minor things that might as
> well be fixed.

Thanks for the fixes (and testing)!

> I'd also like to do a somewhat more extensive change to dm_qe_uec.c: I
> find it very confusing with the qe_uec_priv versus uec_priv, so I'd
> like to just add a phydev member to struct uec_priv, remove struct
> qe_uec_priv, make .priv_auto_alloc_size = sizeof(struct uec_priv), and
> eliminate the malloc/free pair in .prove/.remove. It's mostly
> mechanical using coccinelle, but WDYT?

Sounds good, so please send a patch... thanks!

bye,
Heiko
> 
> Rasmus Villemoes (3):
>    mdio-uclass.c: support fixed-link subnodes
>    dm_qe_uec.c: fix indentation in uec_set_mac_if_mode()
>    uec.h: fix COFIG_DM typo
> 
>   drivers/net/qe/dm_qe_uec.c | 4 ++--
>   drivers/net/qe/uec.h       | 2 +-
>   net/mdio-uclass.c          | 7 +++++++
>   3 files changed, 10 insertions(+), 3 deletions(-)
>