From patchwork Wed Jul 15 20:11:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 1329786 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=bootlin.com Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4B6T7L4FMBz9sRk for ; Thu, 16 Jul 2020 06:11:58 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4B1DA81B7D; Wed, 15 Jul 2020 22:11:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id C027881B93; Wed, 15 Jul 2020 22:11:51 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from relay10.mail.gandi.net (relay10.mail.gandi.net [217.70.178.230]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 37924819EA for ; Wed, 15 Jul 2020 22:11:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=thomas.petazzoni@bootlin.com Received: from localhost (lfbn-bay-1-589-66.w90-30.abo.wanadoo.fr [90.30.52.66]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id EC173240008; Wed, 15 Jul 2020 20:11:47 +0000 (UTC) From: Thomas Petazzoni To: Joao Marcos Costa Cc: u-boot@lists.denx.de, miquel.raynal@bootlin.com, Thomas Petazzoni Subject: [PATCH 0/3] squashfs fixes Date: Wed, 15 Jul 2020 22:11:40 +0200 Message-Id: <20200715201143.2168632-1-thomas.petazzoni@bootlin.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200709175148.17193-1-joaomarcos.costa@bootlin.com> References: <20200709175148.17193-1-joaomarcos.costa@bootlin.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.3 at phobos.denx.de X-Virus-Status: Clean Hello Joao, As I started reviewing your patch series, I encountered a number of build issues after applying your patches, and building on the latest master. The following patches address the build failures I have encountered. Could you squash them into your commits, so that those fixes are part of your v2 ? Of course, please do some testing, as I have only done build testing so far. Also, even with those fixes in place, I do still get a worrying gcc warning (from gcc 10): fs/squashfs/sqfs_inode.c: In function ‘sqfs_find_inode’: fs/squashfs/sqfs_inode.c:72:34: warning: array subscript l is outside array bounds of ‘struct squashfs_directory_index[0]’ [-Warray-bounds] 72 | index_list_size += ldir.index[l].size + 1; | ~~~~~~~~~~^~~ In file included from fs/squashfs/sqfs_inode.c:16: fs/squashfs/sqfs_filesystem.h:207:34: note: while referencing ‘index’ 207 | struct squashfs_directory_index index[0]; | ^~~~~ fs/squashfs/sqfs_inode.c:31:29: note: defined here ‘ldir’ 31 | struct squashfs_ldir_inode ldir; | ^~~~ Could you investigate this ? Thanks, Thomas Thomas Petazzoni (3): cmd/sqfs.c, include/fs.h: fix build failures, don't expose do_sqfs_*() functions globally fs/squashfs: use "struct disk_partition" instead of "disk_partition_t" fs/squashfs: do not use CMD_RET_* defines in the filesystem code cmd/sqfs.c | 5 ++-- fs/squashfs/sqfs.c | 66 ++++++++++++++++++++-------------------------- include/fs.h | 12 --------- include/squashfs.h | 4 ++- 4 files changed, 34 insertions(+), 53 deletions(-)