mbox series

[0/4] Move eSDHC adapter card code to board files

Message ID 20200617100900.6506-1-yangbo.lu@nxp.com
Headers show
Series Move eSDHC adapter card code to board files | expand

Message

Yangbo Lu June 17, 2020, 10:08 a.m. UTC 
The eSDHC adapter card identification and multiplexing configuration
through FPGA had been implemented in both common mmc driver and
fsl_esdhc driver. However it is proper to move these code to board
files and do it during board initialization. The FPGA registers are
also board specific.

This patch-set is to move eSDHC adapter card identification and
multiplexing configuration from mmc driver to specific board files.
Add eSDHC adapter card identification for LX2 QDS.
And the option CONFIG_FSL_ESDHC_ADAPTER_IDENT is no longer needed.

CI build result
https://travis-ci.org/github/yangbolu1991/u-boot-test/builds/699180417

Yangbo Lu (4):
  Drop global data sdhc_adapter for powerpc
  Move eSDHC adapter card identification to board files
  board: fsl: lx2160aqds: identify SDHC adapter during board init
  configs: lx2160aqds: enable CONFIG_BOARD_EARLY_INIT_R

 arch/powerpc/include/asm/global_data.h       |  4 +--
 board/freescale/common/qixis.h               | 14 +++++++---
 board/freescale/lx2160a/lx2160a.c            | 36 +++++++++++++++++++++++--
 board/freescale/t1040qds/t1040qds.c          | 29 ++++++++++++++++++++-
 board/freescale/t208xqds/t208xqds.c          | 29 ++++++++++++++++++++-
 configs/lx2160aqds_tfa_SECURE_BOOT_defconfig |  1 +
 configs/lx2160aqds_tfa_defconfig             |  1 +
 doc/README.fsl-esdhc                         | 14 ----------
 drivers/mmc/fsl_esdhc.c                      | 39 ----------------------------
 drivers/mmc/mmc-uclass.c                     |  4 +--
 drivers/mmc/mmc.c                            |  7 +----
 drivers/mmc/mmc_legacy.c                     |  7 +----
 drivers/mmc/mmc_private.h                    |  4 +--
 include/configs/T1040QDS.h                   |  1 -
 include/configs/T208xQDS.h                   |  1 -
 include/fsl_esdhc.h                          |  4 ---
 scripts/config_whitelist.txt                 |  1 -
 17 files changed, 108 insertions(+), 88 deletions(-)

Comments

Yangbo Lu July 6, 2020, 2:47 a.m. UTC | #1 
Hi Priyanka,

Any comments on this patch-set?
Thanks a lot.

Best regards,
Yangbo Lu

> -----Original Message-----
> From: Yangbo Lu <yangbo.lu@nxp.com>
> Sent: Wednesday, June 17, 2020 6:09 PM
> To: u-boot@lists.denx.de; Priyanka Jain <priyanka.jain@nxp.com>; Peng Fan
> <peng.fan@nxp.com>
> Cc: Y.b. Lu <yangbo.lu@nxp.com>
> Subject: [PATCH 0/4] Move eSDHC adapter card code to board files
> 
> The eSDHC adapter card identification and multiplexing configuration
> through FPGA had been implemented in both common mmc driver and
> fsl_esdhc driver. However it is proper to move these code to board
> files and do it during board initialization. The FPGA registers are
> also board specific.
> 
> This patch-set is to move eSDHC adapter card identification and
> multiplexing configuration from mmc driver to specific board files.
> Add eSDHC adapter card identification for LX2 QDS.
> And the option CONFIG_FSL_ESDHC_ADAPTER_IDENT is no longer needed.
> 
> CI build result
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci
> .org%2Fgithub%2Fyangbolu1991%2Fu-boot-test%2Fbuilds%2F699180417&a
> mp;data=02%7C01%7Cyangbo.lu%40nxp.com%7C2351c69f76e142be1c4108d
> 812a73fd6%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637279
> 856821151607&amp;sdata=doJR9jInaSGNQHqZlOar%2BKb3kY%2F7xuQzNgA
> 88ADf8B0%3D&amp;reserved=0
> 
> Yangbo Lu (4):
>   Drop global data sdhc_adapter for powerpc
>   Move eSDHC adapter card identification to board files
>   board: fsl: lx2160aqds: identify SDHC adapter during board init
>   configs: lx2160aqds: enable CONFIG_BOARD_EARLY_INIT_R
> 
>  arch/powerpc/include/asm/global_data.h       |  4 +--
>  board/freescale/common/qixis.h               | 14 +++++++---
>  board/freescale/lx2160a/lx2160a.c            | 36
> +++++++++++++++++++++++--
>  board/freescale/t1040qds/t1040qds.c          | 29
> ++++++++++++++++++++-
>  board/freescale/t208xqds/t208xqds.c          | 29
> ++++++++++++++++++++-
>  configs/lx2160aqds_tfa_SECURE_BOOT_defconfig |  1 +
>  configs/lx2160aqds_tfa_defconfig             |  1 +
>  doc/README.fsl-esdhc                         | 14 ----------
>  drivers/mmc/fsl_esdhc.c                      | 39 ----------------------------
>  drivers/mmc/mmc-uclass.c                     |  4 +--
>  drivers/mmc/mmc.c                            |  7 +----
>  drivers/mmc/mmc_legacy.c                     |  7 +----
>  drivers/mmc/mmc_private.h                    |  4 +--
>  include/configs/T1040QDS.h                   |  1 -
>  include/configs/T208xQDS.h                   |  1 -
>  include/fsl_esdhc.h                          |  4 ---
>  scripts/config_whitelist.txt                 |  1 -
>  17 files changed, 108 insertions(+), 88 deletions(-)
> 
> --
> 2.7.4
Yangbo Lu July 8, 2020, 4:33 a.m. UTC | #2 
CC Xiaobo, Jiafei

> -----Original Message-----
> From: Y.b. Lu
> Sent: Monday, July 6, 2020 10:47 AM
> To: u-boot@lists.denx.de; Priyanka Jain <priyanka.jain@nxp.com>; Peng Fan
> <peng.fan@nxp.com>
> Subject: RE: [PATCH 0/4] Move eSDHC adapter card code to board files
> 
> Hi Priyanka,
> 
> Any comments on this patch-set?
> Thanks a lot.
> 
> Best regards,
> Yangbo Lu
> 
> > -----Original Message-----
> > From: Yangbo Lu <yangbo.lu@nxp.com>
> > Sent: Wednesday, June 17, 2020 6:09 PM
> > To: u-boot@lists.denx.de; Priyanka Jain <priyanka.jain@nxp.com>; Peng Fan
> > <peng.fan@nxp.com>
> > Cc: Y.b. Lu <yangbo.lu@nxp.com>
> > Subject: [PATCH 0/4] Move eSDHC adapter card code to board files
> >
> > The eSDHC adapter card identification and multiplexing configuration
> > through FPGA had been implemented in both common mmc driver and
> > fsl_esdhc driver. However it is proper to move these code to board
> > files and do it during board initialization. The FPGA registers are
> > also board specific.
> >
> > This patch-set is to move eSDHC adapter card identification and
> > multiplexing configuration from mmc driver to specific board files.
> > Add eSDHC adapter card identification for LX2 QDS.
> > And the option CONFIG_FSL_ESDHC_ADAPTER_IDENT is no longer needed.
> >
> > CI build result
> >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci
> > .org%2Fgithub%2Fyangbolu1991%2Fu-boot-test%2Fbuilds%2F699180417&
> a
> >
> mp;data=02%7C01%7Cyangbo.lu%40nxp.com%7C2351c69f76e142be1c4108d
> >
> 812a73fd6%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637279
> >
> 856821151607&amp;sdata=doJR9jInaSGNQHqZlOar%2BKb3kY%2F7xuQzNgA
> > 88ADf8B0%3D&amp;reserved=0
> >
> > Yangbo Lu (4):
> >   Drop global data sdhc_adapter for powerpc
> >   Move eSDHC adapter card identification to board files
> >   board: fsl: lx2160aqds: identify SDHC adapter during board init
> >   configs: lx2160aqds: enable CONFIG_BOARD_EARLY_INIT_R
> >
> >  arch/powerpc/include/asm/global_data.h       |  4 +--
> >  board/freescale/common/qixis.h               | 14 +++++++---
> >  board/freescale/lx2160a/lx2160a.c            | 36
> > +++++++++++++++++++++++--
> >  board/freescale/t1040qds/t1040qds.c          | 29
> > ++++++++++++++++++++-
> >  board/freescale/t208xqds/t208xqds.c          | 29
> > ++++++++++++++++++++-
> >  configs/lx2160aqds_tfa_SECURE_BOOT_defconfig |  1 +
> >  configs/lx2160aqds_tfa_defconfig             |  1 +
> >  doc/README.fsl-esdhc                         | 14 ----------
> >  drivers/mmc/fsl_esdhc.c                      | 39 ----------------------------
> >  drivers/mmc/mmc-uclass.c                     |  4 +--
> >  drivers/mmc/mmc.c                            |  7 +----
> >  drivers/mmc/mmc_legacy.c                     |  7 +----
> >  drivers/mmc/mmc_private.h                    |  4 +--
> >  include/configs/T1040QDS.h                   |  1 -
> >  include/configs/T208xQDS.h                   |  1 -
> >  include/fsl_esdhc.h                          |  4 ---
> >  scripts/config_whitelist.txt                 |  1 -
> >  17 files changed, 108 insertions(+), 88 deletions(-)
> >
> > --
> > 2.7.4