mbox series

[U-Boot,v3,0/4] arm64: sun50i: Add support for Orange Pi 3

Message ID 20191203084539.1956677-1-a.heider@gmail.com
Headers show
Series arm64: sun50i: Add support for Orange Pi 3 | expand

Message

Andre Heider Dec. 3, 2019, 8:45 a.m. UTC
Changes since v2:
* drop "sunxi: board: Use eth_env_set_enetaddr_by_index()" as it breaks
  compilation without CONFIG_NET
* add "sunxi: board: extract creating a unique sid into a helper function"
  and use it for the the bdaddr so that it work without ethernet devices
* use `if (CONFIG_FIXUP_BDADDR[0])` as suggested by Ondřej to give the
  compiler a better chance of discarding the function if the knob isn't
  set

Changes since v1:
* add CONFIG_FIXUP_BDADDR so fixing up a bdaddr is reusable
* try to use "bdaddr" first, then fall back to generating an address

Notes:
* the kernel patch for btbcm to accept the "local-bd-address"
  property is on master and will be in v5.5-rc1

Andre Heider (4):
  sunxi: board: extract creating a unique sid into a helper function
  arm: sunxi: add a config option to fixup a Bluetooth address
  arm64: dts: sync Allwinner H6 files
  arm64: dts: sun50i: Add support for Orange Pi 3

 arch/arm/dts/Makefile                  |   1 +
 arch/arm/dts/sun50i-h6-beelink-gs1.dts |  27 +++
 arch/arm/dts/sun50i-h6-orangepi-3.dts  | 287 +++++++++++++++++++++++++
 arch/arm/dts/sun50i-h6-orangepi.dtsi   |   4 +
 arch/arm/dts/sun50i-h6-pine-h64.dts    |   4 +
 arch/arm/dts/sun50i-h6.dtsi            | 137 ++++++++++--
 arch/arm/mach-sunxi/Kconfig            |  11 +
 board/sunxi/MAINTAINERS                |   5 +
 board/sunxi/board.c                    | 139 ++++++++----
 configs/orangepi_3_defconfig           |  18 ++
 10 files changed, 569 insertions(+), 64 deletions(-)
 create mode 100644 arch/arm/dts/sun50i-h6-orangepi-3.dts
 create mode 100644 configs/orangepi_3_defconfig

Comments

Andre Heider Dec. 10, 2019, 3:56 p.m. UTC | #1
On 03/12/2019 09:45, Andre Heider wrote:
> Changes since v2:
> * drop "sunxi: board: Use eth_env_set_enetaddr_by_index()" as it breaks
>    compilation without CONFIG_NET
> * add "sunxi: board: extract creating a unique sid into a helper function"
>    and use it for the the bdaddr so that it work without ethernet devices
> * use `if (CONFIG_FIXUP_BDADDR[0])` as suggested by Ondřej to give the
>    compiler a better chance of discarding the function if the knob isn't
>    set

Jagan, Maxime,

does v3 look okay to you guys? Anything I need to address to get this in?

Thanks!
Andre

> 
> Changes since v1:
> * add CONFIG_FIXUP_BDADDR so fixing up a bdaddr is reusable
> * try to use "bdaddr" first, then fall back to generating an address
> 
> Notes:
> * the kernel patch for btbcm to accept the "local-bd-address"
>    property is on master and will be in v5.5-rc1
> 
> Andre Heider (4):
>    sunxi: board: extract creating a unique sid into a helper function
>    arm: sunxi: add a config option to fixup a Bluetooth address
>    arm64: dts: sync Allwinner H6 files
>    arm64: dts: sun50i: Add support for Orange Pi 3
> 
>   arch/arm/dts/Makefile                  |   1 +
>   arch/arm/dts/sun50i-h6-beelink-gs1.dts |  27 +++
>   arch/arm/dts/sun50i-h6-orangepi-3.dts  | 287 +++++++++++++++++++++++++
>   arch/arm/dts/sun50i-h6-orangepi.dtsi   |   4 +
>   arch/arm/dts/sun50i-h6-pine-h64.dts    |   4 +
>   arch/arm/dts/sun50i-h6.dtsi            | 137 ++++++++++--
>   arch/arm/mach-sunxi/Kconfig            |  11 +
>   board/sunxi/MAINTAINERS                |   5 +
>   board/sunxi/board.c                    | 139 ++++++++----
>   configs/orangepi_3_defconfig           |  18 ++
>   10 files changed, 569 insertions(+), 64 deletions(-)
>   create mode 100644 arch/arm/dts/sun50i-h6-orangepi-3.dts
>   create mode 100644 configs/orangepi_3_defconfig
>
Andre Heider Jan. 6, 2020, 9:27 a.m. UTC | #2
On 10/12/2019 16:56, Andre Heider wrote:
> On 03/12/2019 09:45, Andre Heider wrote:
>> Changes since v2:
>> * drop "sunxi: board: Use eth_env_set_enetaddr_by_index()" as it breaks
>>    compilation without CONFIG_NET
>> * add "sunxi: board: extract creating a unique sid into a helper 
>> function"
>>    and use it for the the bdaddr so that it work without ethernet devices
>> * use `if (CONFIG_FIXUP_BDADDR[0])` as suggested by Ondřej to give the
>>    compiler a better chance of discarding the function if the knob isn't
>>    set
> 
> Jagan, Maxime,
> 
> does v3 look okay to you guys? Anything I need to address to get this in?

How about this year? ;) Anyone? Bueller?

> 
> Thanks!
> Andre
> 
>>
>> Changes since v1:
>> * add CONFIG_FIXUP_BDADDR so fixing up a bdaddr is reusable
>> * try to use "bdaddr" first, then fall back to generating an address
>>
>> Notes:
>> * the kernel patch for btbcm to accept the "local-bd-address"
>>    property is on master and will be in v5.5-rc1
>>
>> Andre Heider (4):
>>    sunxi: board: extract creating a unique sid into a helper function
>>    arm: sunxi: add a config option to fixup a Bluetooth address
>>    arm64: dts: sync Allwinner H6 files
>>    arm64: dts: sun50i: Add support for Orange Pi 3
>>
>>   arch/arm/dts/Makefile                  |   1 +
>>   arch/arm/dts/sun50i-h6-beelink-gs1.dts |  27 +++
>>   arch/arm/dts/sun50i-h6-orangepi-3.dts  | 287 +++++++++++++++++++++++++
>>   arch/arm/dts/sun50i-h6-orangepi.dtsi   |   4 +
>>   arch/arm/dts/sun50i-h6-pine-h64.dts    |   4 +
>>   arch/arm/dts/sun50i-h6.dtsi            | 137 ++++++++++--
>>   arch/arm/mach-sunxi/Kconfig            |  11 +
>>   board/sunxi/MAINTAINERS                |   5 +
>>   board/sunxi/board.c                    | 139 ++++++++----
>>   configs/orangepi_3_defconfig           |  18 ++
>>   10 files changed, 569 insertions(+), 64 deletions(-)
>>   create mode 100644 arch/arm/dts/sun50i-h6-orangepi-3.dts
>>   create mode 100644 configs/orangepi_3_defconfig
>>
>
Maxime Ripard Jan. 6, 2020, 9:48 a.m. UTC | #3
On Tue, Dec 10, 2019 at 04:56:04PM +0100, Andre Heider wrote:
> On 03/12/2019 09:45, Andre Heider wrote:
> > Changes since v2:
> > * drop "sunxi: board: Use eth_env_set_enetaddr_by_index()" as it breaks
> >    compilation without CONFIG_NET
> > * add "sunxi: board: extract creating a unique sid into a helper function"
> >    and use it for the the bdaddr so that it work without ethernet devices
> > * use `if (CONFIG_FIXUP_BDADDR[0])` as suggested by Ondřej to give the
> >    compiler a better chance of discarding the function if the knob isn't
> >    set
>
> Jagan, Maxime,
>
> does v3 look okay to you guys? Anything I need to address to get this in?

Yeah, it looks good to me

Acked-by: Maxime Ripard <mripard@kernel.org>

Maxime