mbox series

[U-Boot,v5,00/10] spi: Add Atmel QuadSPI driver

Message ID 20190618085133.26914-1-tudor.ambarus@microchip.com
Headers show
Series spi: Add Atmel QuadSPI driver | expand

Message

Tudor Ambarus June 18, 2019, 8:51 a.m. UTC 
From: Tudor Ambarus <tudor.ambarus@microchip.com>

Backport the driver from linux v5.1-rc5 and adapt it for u-boot.
Tested on sama5d2_xplained Rev B with mx25l25635e spi-nor flash,
and on sama5d27_som1_ek with sst26vf064b spi-nor flash.

V5: drop struct platform_device *pdev; linux leftover, add 2 new
blank lines

v4: Update Kconfig description

v3: fix following config warnings reported by travis:
./tools/genboardscfg.py
WARNING: no status info for 'sama5d2_xplained_qspiflash'
WARNING: no maintainers for 'sama5d2_xplained_qspiflash'
WARNING: no status info for 'sama5d27_som1_ek_qspiflash'
WARNING: no maintainers for 'sama5d27_som1_ek_qspiflash'

v2: update/add configs and update sama5d2_xplained dts

Cyrille Pitchen (2):
  ARM: dts: at91: sama5d2_xplained: fix QSPI0 node
  ARM: at91: sama5: add common environment for QSPI

Eugen Hristev (1):
  configs: sama5d2_xplained: add support QSPI flash boot

Tudor Ambarus (7):
  dt-bindings: spi: add bindings for Atmel QSPI driver
  spi: Add Atmel QuadSPI driver
  configs: sama5d2_xplained: enable qspi controller and flashes
  configs: sama5d27_som1_ek: enable qspi controller and flashes
  configs: sama5d2_xplained: add qspiflash_defconfig
  configs: sama5d27_som1_ek: add qspiflash_defconfig
  configs: sama5d27_som1_ek: qspi: use common memory layout

 arch/arm/dts/at91-sama5d2_xplained.dts         |  36 +-
 board/atmel/sama5d27_som1_ek/MAINTAINERS       |   1 +
 board/atmel/sama5d2_xplained/MAINTAINERS       |   1 +
 configs/sama5d27_som1_ek_mmc1_defconfig        |   2 +
 configs/sama5d27_som1_ek_mmc_defconfig         |   2 +
 configs/sama5d27_som1_ek_qspiflash_defconfig   | 101 +++++
 configs/sama5d2_xplained_emmc_defconfig        |   5 +
 configs/sama5d2_xplained_mmc_defconfig         |   5 +
 configs/sama5d2_xplained_qspiflash_defconfig   | 101 +++++
 configs/sama5d2_xplained_spiflash_defconfig    |   5 +
 doc/device-tree-bindings/spi/atmel-quadspi.txt |  37 ++
 drivers/spi/Kconfig                            |   8 +
 drivers/spi/Makefile                           |   1 +
 drivers/spi/atmel-quadspi.c                    | 536 +++++++++++++++++++++++++
 include/configs/at91-sama5_common.h            |   8 +
 include/configs/sama5d27_som1_ek.h             |   7 -
 include/configs/sama5d2_xplained.h             |  11 +
 17 files changed, 841 insertions(+), 26 deletions(-)
 create mode 100644 configs/sama5d27_som1_ek_qspiflash_defconfig
 create mode 100644 configs/sama5d2_xplained_qspiflash_defconfig
 create mode 100644 doc/device-tree-bindings/spi/atmel-quadspi.txt
 create mode 100644 drivers/spi/atmel-quadspi.c

Comments

Eugen Hristev June 25, 2019, 11:35 a.m. UTC | #1 
Hello Jagan,

I can only take these patches through u-boot-atmel tree if you 
Ack/Review them.
Otherwise you can consider taking them through u-boot-spi ?

Thanks,
Eugen

On 18.06.2019 11:51, Tudor Ambarus - M18064 wrote:
> From: Tudor Ambarus <tudor.ambarus@microchip.com>
> 
> Backport the driver from linux v5.1-rc5 and adapt it for u-boot.
> Tested on sama5d2_xplained Rev B with mx25l25635e spi-nor flash,
> and on sama5d27_som1_ek with sst26vf064b spi-nor flash.
> 
> V5: drop struct platform_device *pdev; linux leftover, add 2 new
> blank lines
> 
> v4: Update Kconfig description
> 
> v3: fix following config warnings reported by travis:
> ./tools/genboardscfg.py
> WARNING: no status info for 'sama5d2_xplained_qspiflash'
> WARNING: no maintainers for 'sama5d2_xplained_qspiflash'
> WARNING: no status info for 'sama5d27_som1_ek_qspiflash'
> WARNING: no maintainers for 'sama5d27_som1_ek_qspiflash'
> 
> v2: update/add configs and update sama5d2_xplained dts
> 
> Cyrille Pitchen (2):
>    ARM: dts: at91: sama5d2_xplained: fix QSPI0 node
>    ARM: at91: sama5: add common environment for QSPI
> 
> Eugen Hristev (1):
>    configs: sama5d2_xplained: add support QSPI flash boot
> 
> Tudor Ambarus (7):
>    dt-bindings: spi: add bindings for Atmel QSPI driver
>    spi: Add Atmel QuadSPI driver
>    configs: sama5d2_xplained: enable qspi controller and flashes
>    configs: sama5d27_som1_ek: enable qspi controller and flashes
>    configs: sama5d2_xplained: add qspiflash_defconfig
>    configs: sama5d27_som1_ek: add qspiflash_defconfig
>    configs: sama5d27_som1_ek: qspi: use common memory layout
> 
>   arch/arm/dts/at91-sama5d2_xplained.dts         |  36 +-
>   board/atmel/sama5d27_som1_ek/MAINTAINERS       |   1 +
>   board/atmel/sama5d2_xplained/MAINTAINERS       |   1 +
>   configs/sama5d27_som1_ek_mmc1_defconfig        |   2 +
>   configs/sama5d27_som1_ek_mmc_defconfig         |   2 +
>   configs/sama5d27_som1_ek_qspiflash_defconfig   | 101 +++++
>   configs/sama5d2_xplained_emmc_defconfig        |   5 +
>   configs/sama5d2_xplained_mmc_defconfig         |   5 +
>   configs/sama5d2_xplained_qspiflash_defconfig   | 101 +++++
>   configs/sama5d2_xplained_spiflash_defconfig    |   5 +
>   doc/device-tree-bindings/spi/atmel-quadspi.txt |  37 ++
>   drivers/spi/Kconfig                            |   8 +
>   drivers/spi/Makefile                           |   1 +
>   drivers/spi/atmel-quadspi.c                    | 536 +++++++++++++++++++++++++
>   include/configs/at91-sama5_common.h            |   8 +
>   include/configs/sama5d27_som1_ek.h             |   7 -
>   include/configs/sama5d2_xplained.h             |  11 +
>   17 files changed, 841 insertions(+), 26 deletions(-)
>   create mode 100644 configs/sama5d27_som1_ek_qspiflash_defconfig
>   create mode 100644 configs/sama5d2_xplained_qspiflash_defconfig
>   create mode 100644 doc/device-tree-bindings/spi/atmel-quadspi.txt
>   create mode 100644 drivers/spi/atmel-quadspi.c
>
Jagan Teki June 25, 2019, 3:40 p.m. UTC | #2 
On Tue, Jun 25, 2019 at 5:05 PM <Eugen.Hristev@microchip.com> wrote:
>
> Hello Jagan,
>
> I can only take these patches through u-boot-atmel tree if you
> Ack/Review them.
> Otherwise you can consider taking them through u-boot-spi ?

I would need a look on the new version, once ie fine I can pick via
spi tree. if possible please assign me on the patchwork, thanks.
Jagan Teki June 29, 2019, 2:55 p.m. UTC | #3 
Hi Eugen,

On Tue, Jun 25, 2019 at 9:10 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Tue, Jun 25, 2019 at 5:05 PM <Eugen.Hristev@microchip.com> wrote:
> >
> > Hello Jagan,
> >
> > I can only take these patches through u-boot-atmel tree if you
> > Ack/Review them.
> > Otherwise you can consider taking them through u-boot-spi ?
>
> I would need a look on the new version, once ie fine I can pick via
> spi tree. if possible please assign me on the patchwork, thanks.

I have marked my comments,  you can make the decision accordingly. By
the way I assigned them to you as well, thanks.

Jagan.
Eugen Hristev July 8, 2019, 11:40 a.m. UTC | #4 
On 29.06.2019 17:55, Jagan Teki wrote:

> Hi Eugen,
> 
> On Tue, Jun 25, 2019 at 9:10 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>>
>> On Tue, Jun 25, 2019 at 5:05 PM <Eugen.Hristev@microchip.com> wrote:
>>>
>>> Hello Jagan,
>>>
>>> I can only take these patches through u-boot-atmel tree if you
>>> Ack/Review them.
>>> Otherwise you can consider taking them through u-boot-spi ?
>>
>> I would need a look on the new version, once ie fine I can pick via
>> spi tree. if possible please assign me on the patchwork, thanks.
> 
> I have marked my comments,  you can make the decision accordingly. By
> the way I assigned them to you as well, thanks.
> 
> Jagan.
> 

Applied patches 2-10 to u-boot-atmel/next
Dropped patch 1 (dt-bindings) as advised by Jagan.
Will be queued for 2019.10 merge window.

Thanks Tudor and Jagan !

Eugen