From patchwork Sat Feb 9 22:54:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 1039301 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="sR9UlKGw"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43xnRq02f4z9s5c for ; Sun, 10 Feb 2019 09:54:30 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id A4C2FC21FE1; Sat, 9 Feb 2019 22:54:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=KHOP_BIG_TO_CC, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id E73D6C21F3E; Sat, 9 Feb 2019 22:54:24 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 643A2C21F3E; Sat, 9 Feb 2019 22:54:23 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by lists.denx.de (Postfix) with ESMTPS id 9DC52C21C57 for ; Sat, 9 Feb 2019 22:54:22 +0000 (UTC) Received: from localhost.localdomain (unknown [194.230.155.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4E423218D2; Sat, 9 Feb 2019 22:54:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549752861; bh=ss+UR5AyqaM1LcCaiFrub2csrWzHudnZTVDAFciuTp4=; h=From:To:Subject:Date:From; b=sR9UlKGwLP2VsCZLg3Miy7KFgWY9lIIDDmA/FBTjGxITCaU2bCUSeexK5che359PW W8KREPpd126v7jDLKlWnll5J90VwPqr1XYu7Zt6KEFeQnM1TQbe8YLxfnOudZIqepR 8Pi0Aq9wdjWzMfdz3yjmw3USrGUamo1EiJTx80VY= From: Krzysztof Kozlowski To: Albert Aribaud , Jaehoon Chung , Krzysztof Kozlowski , Simon Glass , Minkyu Kang , Marek Szyprowski , Lukasz Majewski , Dirk Meul , Patrice Chotard , Felix Brack , Jack Mitchell , Patrick Delaunay , Lokesh Vutla , u-boot@lists.denx.de Date: Sat, 9 Feb 2019 23:54:03 +0100 Message-Id: <20190209225411.32756-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Subject: [U-Boot] [RFT 0/8] exynos: Fix reboot on Odroid HC1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Hi, Odroid HC1 does not reboot properly (at least from SD card but I do not expect difference on eMMC), if LDO4/VDD_ADC was turned off by Linux kernel. This condition is so far always, because Linux kernel did not enable ADC on ODroid HC1, therefore the VDD_ADC regulator was turned off as unused. The issue is in detection of revision which later is used to load proper DTB. The revision is obtained by ADC read of a voltage depending on VDD_ADC. Therefore: 1. VDD_ADC has to be turned on (but board detection happens before power is initialized), 2. Turning VDD_ADC should wait with ramp delay, 3. Reading the value from ADC should wait for it to stabilize. I must admit I did not test it on other boards because latest U-Boot does not boot from SD card. Commends and testing are welcomed. Best regards, Krzysztof Krzysztof Kozlowski (8): exynos: Redo detection of revision when all resources are ready exynos: Wait till ADC stabilizes before checking Odroid HC1 revision adc: exynos-adc: Fix wrong bit operation used to stop the ADC regulator: Add support for ramp delay power: regulator: s2mps11: Fix step for LDO27 and LDO35 power: regulator: s2mps11: Add enable delay arm: dts: exynos: Add supply for ADC block to Odroid XU3 family arm: dts: exynos: Add ramp delay property to LDO regulators to Odroid XU3 family arch/arm/dts/exynos5422-odroidxu3.dts | 20 +++++++++ board/samsung/common/board.c | 19 ++++++++- board/samsung/common/exynos5-dt-types.c | 34 +++++++++++++++- drivers/adc/exynos-adc.c | 2 +- drivers/power/regulator/regulator-uclass.c | 45 ++++++++++++++++++++- drivers/power/regulator/s2mps11_regulator.c | 13 +++++- include/power/regulator.h | 2 + 7 files changed, 129 insertions(+), 6 deletions(-)