From patchwork Tue Jun 20 10:22:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 778215 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.34.181.88]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wsP6S5sw7z9s4q for ; Tue, 20 Jun 2017 20:22:24 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sourceforge.net header.i=@sourceforge.net header.b="ZGqqaVKz"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sf.net header.i=@sf.net header.b="nAaGx0bB"; dkim-atps=neutral Received: from localhost ([127.0.0.1] helo=sfs-ml-1.v29.ch3.sourceforge.com) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1dNGId-0005xV-1o; Tue, 20 Jun 2017 10:22:19 +0000 Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-1.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1dNGIc-0005xP-GI for tpmdd-devel@lists.sourceforge.net; Tue, 20 Jun 2017 10:22:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From; bh=RHyg/qn4pLBOGmkXN+InGj/SkyVbl1P6c0JwkjaFp3E=; b=ZGqqaVKz8mL1avahedI9VH9FpT1d2qmaMfuncDfYVJAHa2TTnZTWS8aTKvF/MmP81uB4/CfDIcILePnx6WO6YpY4Jd3A+hrXhCLj6J1M4drnvwvj0ktNVp36INDRhs3JLtSau6Ya7eUHW3jJhVijH060s/Elp2Zaj5VXiYo0DjA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject:Cc:To:From; bh=RHyg/qn4pLBOGmkXN+InGj/SkyVbl1P6c0JwkjaFp3E=; b=nAaGx0bBmwT6tCZMvbOew2+F+am4dpI6oQC5fRbY0v7MIQeQnsSi2j2adzKM91qtsvkWFal8N8q0zLtr09B/x2XFHWKYpaas5VpCjQBBN82IkjKf0zAzwJo3oKzxMYlwDEgrTXifPz9JRlR6vBtOWDD6cmfs+FXfjqSoJf+RAy4=; Received: from youngberry.canonical.com ([91.189.89.112]) by sog-mx-4.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1dNGIb-0007AZ-7K for tpmdd-devel@lists.sourceforge.net; Tue, 20 Jun 2017 10:22:18 +0000 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1dNGIN-0006aA-4Y; Tue, 20 Jun 2017 10:22:03 +0000 From: Colin King To: Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net Date: Tue, 20 Jun 2017 11:22:02 +0100 Message-Id: <20170620102202.7132-1-colin.king@canonical.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 X-Spam-Score: -0.0 (/) X-Spam-Report: Spam Filtering performed by mx.sourceforge.net. See http://spamassassin.org/tag/ for more details. -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Headers-End: 1dNGIb-0007AZ-7K Subject: [tpmdd-devel] [PATCH][tpm-next] tpm_tis: make ilb_base_addr static X-BeenThere: tpmdd-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: Tpm Device Driver maintainance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Errors-To: tpmdd-devel-bounces@lists.sourceforge.net From: Colin Ian King The pointer ilb_base_addr does not need to be in global scope, so make it static. Cleans up sparse warning: "symbol 'ilb_base_addr' was not declared. Should it be static?" Signed-off-by: Colin Ian King Reviewed-by: Jarkko Sakkinen --- drivers/char/tpm/tpm_tis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c index 506e62ca3576..c915d65c1909 100644 --- a/drivers/char/tpm/tpm_tis.c +++ b/drivers/char/tpm/tpm_tis.c @@ -138,7 +138,7 @@ static int check_acpi_tpm2(struct device *dev) #define LPC_CNTRL_REG_OFFSET 0x84 #define LPC_CLKRUN_EN (1 << 2) -void __iomem *ilb_base_addr; +static void __iomem *ilb_base_addr; static inline bool is_bsw(void) {