diff mbox

[tpmdd-devel,v2,4/7] tpm/tpm_i2c_atmel: Few code style fixes

Message ID 1458975615-8095-5-git-send-email-christophe-h.ricard@st.com
State New
Headers show

Commit Message

Christophe Ricard March 26, 2016, 7 a.m. UTC
Few code style fixes.

Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
---
 drivers/char/tpm/tpm_i2c_atmel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jarkko Sakkinen March 29, 2016, 2:17 p.m. UTC | #1
On Sat, Mar 26, 2016 at 08:00:12AM +0100, Christophe Ricard wrote:
> Few code style fixes.

Sorry but I don't care to apply this patch as there is much more
This just adds noise and brings almost no benefit.

/Jarkko

> Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
> ---
>  drivers/char/tpm/tpm_i2c_atmel.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c
> index 5426c9d..d357065 100644
> --- a/drivers/char/tpm/tpm_i2c_atmel.c
> +++ b/drivers/char/tpm/tpm_i2c_atmel.c
> @@ -125,8 +125,7 @@ static u8 i2c_atmel_read_status(struct tpm_chip *chip)
>  	/* Once the TPM has completed the command the command remains readable
>  	 * until another command is issued. */
>  	rc = i2c_master_recv(client, priv->buffer, sizeof(priv->buffer));
> -	dev_dbg(&chip->dev,
> -		"%s: sts=%d", __func__, rc);
> +	dev_dbg(&chip->dev, "%s: sts=%d", __func__, rc);
>  	if (rc <= 0)
>  		return 0;
>  
> @@ -192,6 +191,7 @@ static int i2c_atmel_probe(struct i2c_client *client,
>  static int i2c_atmel_remove(struct i2c_client *client)
>  {
>  	struct tpm_chip *chip = i2c_get_clientdata(client);
> +
>  	tpm_chip_unregister(chip);
>  	return 0;
>  }
> -- 
> 2.5.0
> 

------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140
diff mbox

Patch

diff --git a/drivers/char/tpm/tpm_i2c_atmel.c b/drivers/char/tpm/tpm_i2c_atmel.c
index 5426c9d..d357065 100644
--- a/drivers/char/tpm/tpm_i2c_atmel.c
+++ b/drivers/char/tpm/tpm_i2c_atmel.c
@@ -125,8 +125,7 @@  static u8 i2c_atmel_read_status(struct tpm_chip *chip)
 	/* Once the TPM has completed the command the command remains readable
 	 * until another command is issued. */
 	rc = i2c_master_recv(client, priv->buffer, sizeof(priv->buffer));
-	dev_dbg(&chip->dev,
-		"%s: sts=%d", __func__, rc);
+	dev_dbg(&chip->dev, "%s: sts=%d", __func__, rc);
 	if (rc <= 0)
 		return 0;
 
@@ -192,6 +191,7 @@  static int i2c_atmel_probe(struct i2c_client *client,
 static int i2c_atmel_remove(struct i2c_client *client)
 {
 	struct tpm_chip *chip = i2c_get_clientdata(client);
+
 	tpm_chip_unregister(chip);
 	return 0;
 }