From patchwork Sun Jan 10 23:15:17 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Engelhardt X-Patchwork-Id: 42580 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E2D861007D1 for ; Mon, 11 Jan 2010 10:15:22 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754067Ab0AJXPU (ORCPT ); Sun, 10 Jan 2010 18:15:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754163Ab0AJXPU (ORCPT ); Sun, 10 Jan 2010 18:15:20 -0500 Received: from borg.medozas.de ([188.40.89.202]:55838 "EHLO borg.medozas.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754067Ab0AJXPT (ORCPT ); Sun, 10 Jan 2010 18:15:19 -0500 Received: by borg.medozas.de (Postfix, from userid 25121) id C0B80F0C32BA1; Mon, 11 Jan 2010 00:15:17 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by borg.medozas.de (Postfix) with ESMTP id B58FE6BE3; Mon, 11 Jan 2010 00:15:17 +0100 (CET) Date: Mon, 11 Jan 2010 00:15:17 +0100 (CET) From: Jan Engelhardt To: David Miller cc: sparclinux@vger.kernel.org, Linux Kernel Mailing List Subject: Re: fstat seems broken on sparc64 In-Reply-To: <20100110.131158.242584083.davem@davemloft.net> Message-ID: References: <20091214.233840.236673621.davem@davemloft.net> <20100110.131158.242584083.davem@davemloft.net> User-Agent: Alpine 2.01 (LSU 1266 2009-07-14) MIME-Version: 1.0 Sender: sparclinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: sparclinux@vger.kernel.org On Sunday 2010-01-10 22:11, David Miller wrote: > >> libc6 2.10.2-4 > >Perfect, now you just have to audit what changed between the -2 and >the -4 package to find the bug :-) I really do not believe you when you say your glibc is not affected. Maybe some things did not became clear as part of the discussion, so let me quickly restate: - talking about -m64 / libc6-sparc64_2.10.2-*_sparc.deb only - syscall is screwed up. strace outputs: C func | i386 | x86_64 | sparc32 | sparc64 --------+-----------+------------+-----------+--------------- stat | stat64 | stat | stat64 | stat64 lstat | lstat64 | lstat | lstat64 | lstat64 fstatat | fstatat64 | newfstatat | fstatat64 | fstatat64 fstat | fstat64 | fstat | fstat64 | fstat (*) - I now found and fixed the problem, here is the patch for you to study (as code speaks louder) (Hint: Compare with sparc64/lxstat.c) --- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: glibc-2.10.1/sysdeps/unix/sysv/linux/sparc/sparc64/fxstat.c =================================================================== --- glibc-2.10.1.orig/sysdeps/unix/sysv/linux/sparc/sparc64/fxstat.c +++ glibc-2.10.1/sysdeps/unix/sysv/linux/sparc/sparc64/fxstat.c @@ -1 +1 @@ -#include "../../fxstat.c" +#include "../../i386/fxstat.c"