From patchwork Thu Nov 5 16:40:44 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: roel kluin X-Patchwork-Id: 37785 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 262DDB7B99 for ; Fri, 6 Nov 2009 03:29:27 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756733AbZKEQ3P (ORCPT ); Thu, 5 Nov 2009 11:29:15 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756623AbZKEQ3P (ORCPT ); Thu, 5 Nov 2009 11:29:15 -0500 Received: from mail-ew0-f207.google.com ([209.85.219.207]:63228 "EHLO mail-ew0-f207.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755153AbZKEQ3O (ORCPT ); Thu, 5 Nov 2009 11:29:14 -0500 Received: by ewy3 with SMTP id 3so154827ewy.37 for ; Thu, 05 Nov 2009 08:29:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=94SHRAKv92bI2A8VtxlpUsTuxnHhAqPuJPoXVUTYopE=; b=aimLWVhJIzLD0R0rYvXpgMLJrbfaAIkFh2LsH9fYqwa9u5cZOFY3AdceT3hsqnddCf CM1xnlik6ltIDblTkBSbdtECmHTyM+pEZkXioTZPNU4mu0t+Awk0wGQcCCKJ8r/T209O ZQOQ57m7d6fiffjH6R12C4Lrnv//+V1L/fLFk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=etiAWRsjPVyZmNBKWv3LYBjLqKllw9gEKGB5YD8ITq9qLjDjnU7ky2Hz4e1bQZyrC4 p5+aldPeOCbil6orRF3nFtTYM0c4/QYxotDA74pvruPU7Uo6XE/DKMYnZ7zpq1fmq/7q mzraJ2UQPaMG4BqcaIseGTLqlCQwcolXUdR3k= Received: by 10.213.23.210 with SMTP id s18mr3624587ebb.89.1257438558695; Thu, 05 Nov 2009 08:29:18 -0800 (PST) Received: from zoinx.mars (d133062.upc-d.chello.nl [213.46.133.62]) by mx.google.com with ESMTPS id 7sm6776730eyb.32.2009.11.05.08.29.17 (version=SSLv3 cipher=RC4-MD5); Thu, 05 Nov 2009 08:29:18 -0800 (PST) Message-ID: <4AF3000C.8080607@gmail.com> Date: Thu, 05 Nov 2009 17:40:44 +0100 From: Roel Kluin User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Thunderbird/3.0b4 MIME-Version: 1.0 To: "David S. Miller" , sparclinux@vger.kernel.org, Andrew Morton , LKML Subject: [PATCH] sparc,sparc64: replace parentheses in pmul() Sender: sparclinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: sparclinux@vger.kernel.org `>>' has a higher precedence than `?' so src2 evaluated to either 16 or 0 dependent on the bits set in rs2. Signed-off-by: Roel Kluin --- arch/sparc/kernel/visemul.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) I am not 100% sure that the code was incorrect, however, if it was intended I think it is a very strange way to write it. Roel -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/sparc/kernel/visemul.c b/arch/sparc/kernel/visemul.c index b956fd7..d231cbd 100644 --- a/arch/sparc/kernel/visemul.c +++ b/arch/sparc/kernel/visemul.c @@ -617,7 +617,7 @@ static void pmul(struct pt_regs *regs, unsigned int insn, unsigned int opf) rs2 = fps_regval(f, RS2(insn)); rd_val = 0; - src2 = (rs2 >> (opf == FMUL8x16AU_OPF) ? 16 : 0); + src2 = rs2 >> (opf == FMUL8x16AU_OPF ? 16 : 0); for (byte = 0; byte < 4; byte++) { u16 src1 = (rs1 >> (byte * 8)) & 0x00ff; u32 prod = src1 * src2;