From patchwork Fri Jun 19 02:15:18 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Reif X-Patchwork-Id: 28894 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4A809B7249 for ; Fri, 19 Jun 2009 12:15:38 +1000 (EST) Received: by ozlabs.org (Postfix) id 3E511DDD1C; Fri, 19 Jun 2009 12:15:38 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 91F56DDDA0 for ; Fri, 19 Jun 2009 12:15:37 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752693AbZFSCPc (ORCPT ); Thu, 18 Jun 2009 22:15:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753478AbZFSCPc (ORCPT ); Thu, 18 Jun 2009 22:15:32 -0400 Received: from pop-scotia.atl.sa.earthlink.net ([207.69.195.65]:38658 "EHLO pop-scotia.atl.sa.earthlink.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693AbZFSCPb (ORCPT ); Thu, 18 Jun 2009 22:15:31 -0400 Received: from user-142h2k8.cable.mindspring.com ([72.40.138.136] helo=[192.168.0.90]) by pop-scotia.atl.sa.earthlink.net with esmtp (Exim 3.36 #1) id 1MHTdV-0005eQ-00; Thu, 18 Jun 2009 22:15:25 -0400 Message-ID: <4A3AF4B6.60109@earthlink.net> Date: Thu, 18 Jun 2009 22:15:18 -0400 From: Robert Reif User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.21) Gecko/20090303 SeaMonkey/1.1.15 (Ubuntu-1.1.15+nobinonly-0ubuntu2) MIME-Version: 1.0 To: David Miller CC: sam@ravnborg.org, sparclinux@vger.kernel.org, oftedal@gmail.com Subject: Re: [PATCH] sparc: fix tftpboot.img build References: <20090608192043.GA30278@uranus.ravnborg.org> <20090618.024554.104174002.davem@davemloft.net> In-Reply-To: <20090618.024554.104174002.davem@davemloft.net> Sender: sparclinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: sparclinux@vger.kernel.org David Miller wrote: > From: Sam Ravnborg > Date: Mon, 8 Jun 2009 21:20:43 +0200 > > >> Kjetil Oftedal mentioned that piggyback_32 was failing >> when building a sparc image. >> >> I tracked this down to the fact that the kernel no longer >> provided an absolute symbol named "end". >> >> Commit 86ed40bd6fe511d26bb8f3fa65a84cb65c235366 ("sparc: unify sections.h") >> renamed end to _end but failed to update piggyback_32. >> >> Signed-off-by: Sam Ravnborg >> Cc: Kjetil Oftedal >> Cc: Robert Reif >> --- >> >> This is not even build tested - but looks obvious. >> > > I don't even know how to build test this: > > davem@sunset:~/src/GIT/sparc-next-2.6$ make ARCH=sparc tftpboot.img > CHK include/linux/version.h > CHK include/linux/utsrelease.h > SYMLINK include/asm -> include/asm-sparc > CALL scripts/checksyscalls.sh > :1519:2: warning: #warning syscall perf_counter_open not implemented > CHK include/linux/compile.h > make[1]: *** No rule to make target `arch/sparc/boot/piggyback', needed by `arch/sparc/boot/tftpboot.img'. Stop. > make: *** [tftpboot.img] Error 2 > davem@sunset:~/src/GIT/sparc-next-2.6$ > > This patch gets piggyback_32.c compiling but there are other issues: make[1]: *** No rule to make target `arch/sparc/boot/System.map', needed by `arch/sparc/boot/tftpboot.img'. Stop. make[1]: *** Waiting for unfinished jobs.... HOSTCC arch/sparc/boot/piggyback_32 make: *** [tftpboot.img] Error 2 --- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/sparc/boot/Makefile b/arch/sparc/boot/Makefile index 96041a8..5e2caeb 100644 --- a/arch/sparc/boot/Makefile +++ b/arch/sparc/boot/Makefile @@ -58,7 +58,7 @@ $(obj)/image: $(obj)/btfix.o FORCE $(obj)/zImage: $(obj)/image $(call if_changed,strip) -$(obj)/tftpboot.img: $(obj)/piggyback $(obj)/System.map $(obj)/image FORCE +$(obj)/tftpboot.img: $(obj)/piggyback_32 $(obj)/System.map $(obj)/image FORCE $(call if_changed,elftoaout) $(call if_changed,piggy) HOSTCC arch/sparc/boot/piggyback_32 arch/sparc/boot/piggyback_32.c: In function ‘main’: arch/sparc/boot/piggyback_32.c:84: warning: pointer targets in passing argument 1 of ‘fgets’ differ in signedness arch/sparc/boot/piggyback_32.c:85: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness arch/sparc/boot/piggyback_32.c:85: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:85: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness arch/sparc/boot/piggyback_32.c:85: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:85: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:85: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:85: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness arch/sparc/boot/piggyback_32.c:85: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:85: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness arch/sparc/boot/piggyback_32.c:85: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:85: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:85: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:86: warning: pointer targets in passing argument 1 of ‘strtoul’ differ in signedness arch/sparc/boot/piggyback_32.c:87: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness arch/sparc/boot/piggyback_32.c:87: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:87: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness arch/sparc/boot/piggyback_32.c:87: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:87: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:87: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:87: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness arch/sparc/boot/piggyback_32.c:87: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:87: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness arch/sparc/boot/piggyback_32.c:87: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:87: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:87: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness arch/sparc/boot/piggyback_32.c:88: warning: pointer targets in passing argument 1 of ‘strtoul’ differ in signedness arch/sparc/boot/piggyback_32.c:98: warning: pointer targets in passing argument 1 of ‘ld4’ differ in signedness arch/sparc/boot/piggyback_32.c:99: warning: pointer targets in passing argument 1 of ‘ld4’ differ in signedness arch/sparc/boot/piggyback_32.c:99: warning: pointer targets in passing argument 1 of ‘ld4’ differ in signedness arch/sparc/boot/piggyback_32.c:99: warning: pointer targets in passing argument 1 of ‘ld4’ differ in signedness arch/sparc/boot/piggyback_32.c:110: warning: pointer targets in passing argument 1 of ‘ld2’ differ in signedness arch/sparc/boot/piggyback_32.c:124: warning: pointer targets in passing argument 1 of ‘st4’ differ in signedness arch/sparc/boot/piggyback_32.c:125: warning: pointer targets in passing argument 1 of ‘st4’ differ in signedness arch/sparc/boot/piggyback_32.c:126: warning: pointer targets in passing argument 1 of ‘st4’ differ in signedness arch/sparc/boot/piggyback_32.c:127: warning: pointer targets in passing argument 1 of ‘st4’ differ in signedness make: *** [tftpboot.img] Error 2 This patch fixes the warnings but there are still more issues: diff --git a/arch/sparc/boot/piggyback_32.c b/arch/sparc/boot/piggyback_32.c index c9f500c..3f0f933 100644 --- a/arch/sparc/boot/piggyback_32.c +++ b/arch/sparc/boot/piggyback_32.c @@ -70,7 +70,7 @@ void die(char *str) int main(int argc,char **argv) { static char aout_magic[] = { 0x01, 0x03, 0x01, 0x07 }; - unsigned char buffer[1024], *q, *r; + char buffer[1024], *q, *r; unsigned int i, j, k, start, end, offset; FILE *map; struct stat s;