[v2,12/12] Makefile: Actually compile with -Wextra

Message ID	20210209014457.108301-13-aik@ozlabs.ru
State	Accepted
Headers	show Return-Path: <slof-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> From: Alexey Kardashevskiy <aik@ozlabs.ru> To: slof@lists.ozlabs.org Date: Tue, 9 Feb 2021 12:44:57 +1100 Message-Id: <20210209014457.108301-13-aik@ozlabs.ru> In-Reply-To: <20210209014457.108301-1-aik@ozlabs.ru> References: <20210209014457.108301-1-aik@ozlabs.ru> Subject: [SLOF] [PATCH slof v2 12/12] Makefile: Actually compile with -Wextra Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: slof-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "SLOF" <slof-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>
Series	Compile with -Wextra \| expand [v2,00/12] Compile with -Wextra [v2,01/12] libc: Compile with -Wextra [v2,02/12] elf: Compile with -Wextra [v2,03/12] usb: Compile with -Wextra [v2,04/12] veth: Compile with -Wextra [v2,05/12] virtio: Compile with -Wextra [v2,06/12] e1000: Compile with -Wextra [v2,07/12] libnet: Compile with -Wextra [v2,08/12] libhv: Compile with -Wextra [v2,09/12] libnvram: Compile with -Wextra [v2,10/12] libtpm: Compile with -Wextra [v2,11/12] slof/prim: Compile with -Wextra [v2,12/12] Makefile: Actually compile with -Wextra

Message ID

20210209014457.108301-13-aik@ozlabs.ru

State

Accepted

Headers

From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: slof@lists.ozlabs.org
Date: Tue,  9 Feb 2021 12:44:57 +1100
Message-Id: <20210209014457.108301-13-aik@ozlabs.ru>
In-Reply-To: <20210209014457.108301-1-aik@ozlabs.ru>
References: <20210209014457.108301-1-aik@ozlabs.ru>
Subject: [SLOF] [PATCH slof v2 12/12] Makefile: Actually compile with -Wextra
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: slof-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org
Sender: "SLOF" <slof-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>

Series

Compile with -Wextra | expand

Commit Message

Alexey Kardashevskiy Feb. 9, 2021, 1:44 a.m. UTC

-Wextra enables a bunch of rather useful checks which this fixes.

The only exception is -Wno-unused-parameter, one thing at the time.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 make.rules | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/make.rules b/make.rules
index 3dfbb5b136c2..885eea3f48b0 100644
--- a/make.rules
+++ b/make.rules
@@ -76,7 +76,7 @@  AR		?= $(CROSS)ar
 RANLIB		?= $(CROSS)ranlib
 CPP		?= $(CROSS)cpp
 
-WARNFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -Wformat-security
+WARNFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -Wformat-security -Wextra -Wno-unused-parameter
 CFLAGS ?= -g -O2 -fno-builtin -ffreestanding -nostdinc -msoft-float \
 	  -fno-strict-aliasing -mno-altivec -mabi=no-altivec \
 	  -fno-stack-protector -fno-asynchronous-unwind-tables $(WARNFLAGS)