| Message ID | 20210127085752.120571-10-aik@ozlabs.ru |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Compile with -Wextra | expand |
On 27/01/2021 09.57, Alexey Kardashevskiy wrote: > -Wextra enables a bunch of rather useful checks which this fixes. > > Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> > --- > include/ppcp7/cache.h | 2 +- > lib/libhvcall/rfill.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/ppcp7/cache.h b/include/ppcp7/cache.h > index 3c02bb10de63..611b6a33599e 100644 > --- a/include/ppcp7/cache.h > +++ b/include/ppcp7/cache.h > @@ -124,7 +124,7 @@ static inline void ci_rmove(void *dst, void *src, unsigned long esize, > > #define FAST_MRMOVE(s, d, size) _FASTRMOVE(s, d, size) > > -extern void fast_rfill(char *dst, long size, char pat); > +extern void fast_rfill(char *dst, unsigned long size, char pat); > #define FAST_RFILL(dst, size, pat) fast_rfill(dst, size, pat) > > static inline uint16_t bswap16_load(uint64_t addr) > diff --git a/lib/libhvcall/rfill.c b/lib/libhvcall/rfill.c > index 5407cd2a60e7..377fb892ba60 100644 > --- a/lib/libhvcall/rfill.c > +++ b/lib/libhvcall/rfill.c > @@ -23,7 +23,7 @@ typedef unsigned long type_u; > * local buffer - and that caused stack size problems in engine() when > * we used it directly in the FAST_RFILL macro. > */ > -void fast_rfill(char *dst, long size, char pat) > +void fast_rfill(char *dst, unsigned long size, char pat) > { > type_u buf[64]; > > Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/include/ppcp7/cache.h b/include/ppcp7/cache.h index 3c02bb10de63..611b6a33599e 100644 --- a/include/ppcp7/cache.h +++ b/include/ppcp7/cache.h @@ -124,7 +124,7 @@ static inline void ci_rmove(void *dst, void *src, unsigned long esize, #define FAST_MRMOVE(s, d, size) _FASTRMOVE(s, d, size) -extern void fast_rfill(char *dst, long size, char pat); +extern void fast_rfill(char *dst, unsigned long size, char pat); #define FAST_RFILL(dst, size, pat) fast_rfill(dst, size, pat) static inline uint16_t bswap16_load(uint64_t addr) diff --git a/lib/libhvcall/rfill.c b/lib/libhvcall/rfill.c index 5407cd2a60e7..377fb892ba60 100644 --- a/lib/libhvcall/rfill.c +++ b/lib/libhvcall/rfill.c @@ -23,7 +23,7 @@ typedef unsigned long type_u; * local buffer - and that caused stack size problems in engine() when * we used it directly in the FAST_RFILL macro. */ -void fast_rfill(char *dst, long size, char pat) +void fast_rfill(char *dst, unsigned long size, char pat) { type_u buf[64];
-Wextra enables a bunch of rather useful checks which this fixes. Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> --- include/ppcp7/cache.h | 2 +- lib/libhvcall/rfill.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)