| Message ID | 153555704511.54721.10203772655182378378.stgit@bahia.lan |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pci: use appropriate base class ids | expand |
On 2018-08-29 17:37, Greg Kurz wrote: > This will allow SLOF to print the appropriate name instead of "unknown" > for PCI classes 0xd to 0x11. > > Signed-off-by: Greg Kurz <groug@kaod.org> > --- > slof/fs/pci-class-code-names.fs | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/slof/fs/pci-class-code-names.fs b/slof/fs/pci-class-code-names.fs > index f56d006acc8a..6cf3b8fd083c 100644 > --- a/slof/fs/pci-class-code-names.fs > +++ b/slof/fs/pci-class-code-names.fs > @@ -254,11 +254,11 @@ > 0A OF pci-class-name-0A ENDOF > 0B OF pci-class-name-0B ENDOF > 0C OF pci-class-name-0C ENDOF > - 0C OF pci-class-name-0D ENDOF > - 0C OF pci-class-name-0E ENDOF > - 0C OF pci-class-name-0F ENDOF > - 0C OF pci-class-name-10 ENDOF > - 0C OF pci-class-name-11 ENDOF > + 0D OF pci-class-name-0D ENDOF > + 0E OF pci-class-name-0E ENDOF > + 0F OF pci-class-name-0F ENDOF > + 10 OF pci-class-name-10 ENDOF > + 11 OF pci-class-name-11 ENDOF > dup OF drop s" unknown" ENDOF > ENDCASE > ; Reviewed-by: Thomas Huth <thuth@redhat.com> Did you really find a POWER machine with one of these cards in it? ;-) Thomas
On Thu, 30 Aug 2018 06:44:52 +0200 Thomas Huth <thuth@redhat.com> wrote: > On 2018-08-29 17:37, Greg Kurz wrote: > > This will allow SLOF to print the appropriate name instead of "unknown" > > for PCI classes 0xd to 0x11. > > > > Signed-off-by: Greg Kurz <groug@kaod.org> > > --- > > slof/fs/pci-class-code-names.fs | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/slof/fs/pci-class-code-names.fs b/slof/fs/pci-class-code-names.fs > > index f56d006acc8a..6cf3b8fd083c 100644 > > --- a/slof/fs/pci-class-code-names.fs > > +++ b/slof/fs/pci-class-code-names.fs > > @@ -254,11 +254,11 @@ > > 0A OF pci-class-name-0A ENDOF > > 0B OF pci-class-name-0B ENDOF > > 0C OF pci-class-name-0C ENDOF > > - 0C OF pci-class-name-0D ENDOF > > - 0C OF pci-class-name-0E ENDOF > > - 0C OF pci-class-name-0F ENDOF > > - 0C OF pci-class-name-10 ENDOF > > - 0C OF pci-class-name-11 ENDOF > > + 0D OF pci-class-name-0D ENDOF > > + 0E OF pci-class-name-0E ENDOF > > + 0F OF pci-class-name-0F ENDOF > > + 10 OF pci-class-name-10 ENDOF > > + 11 OF pci-class-name-11 ENDOF > > dup OF drop s" unknown" ENDOF > > ENDCASE > > ; > > Reviewed-by: Thomas Huth <thuth@redhat.com> > > Did you really find a POWER machine with one of these cards in it? ;-) > > Thomas No but I'm currently doing experiments with some HW that belongs to class 0x12 :) Cheers, -- Greg
On 30/08/2018 17:38, Greg Kurz wrote: > On Thu, 30 Aug 2018 06:44:52 +0200 > Thomas Huth <thuth@redhat.com> wrote: >> On 2018-08-29 17:37, Greg Kurz wrote: >>> This will allow SLOF to print the appropriate name instead of "unknown" >>> for PCI classes 0xd to 0x11. >>> >>> Signed-off-by: Greg Kurz <groug@kaod.org> >>> --- >>> slof/fs/pci-class-code-names.fs | 10 +++++----- >>> 1 file changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/slof/fs/pci-class-code-names.fs b/slof/fs/pci-class-code-names.fs >>> index f56d006acc8a..6cf3b8fd083c 100644 >>> --- a/slof/fs/pci-class-code-names.fs >>> +++ b/slof/fs/pci-class-code-names.fs >>> @@ -254,11 +254,11 @@ >>> 0A OF pci-class-name-0A ENDOF >>> 0B OF pci-class-name-0B ENDOF >>> 0C OF pci-class-name-0C ENDOF >>> - 0C OF pci-class-name-0D ENDOF >>> - 0C OF pci-class-name-0E ENDOF >>> - 0C OF pci-class-name-0F ENDOF >>> - 0C OF pci-class-name-10 ENDOF >>> - 0C OF pci-class-name-11 ENDOF >>> + 0D OF pci-class-name-0D ENDOF >>> + 0E OF pci-class-name-0E ENDOF >>> + 0F OF pci-class-name-0F ENDOF >>> + 10 OF pci-class-name-10 ENDOF >>> + 11 OF pci-class-name-11 ENDOF >>> dup OF drop s" unknown" ENDOF >>> ENDCASE >>> ; >> >> Reviewed-by: Thomas Huth <thuth@redhat.com> >> >> Did you really find a POWER machine with one of these cards in it? ;-) >> >> Thomas > > No but I'm currently doing experiments with some HW that belongs > to class 0x12 :) Thanks, applied.
diff --git a/slof/fs/pci-class-code-names.fs b/slof/fs/pci-class-code-names.fs index f56d006acc8a..6cf3b8fd083c 100644 --- a/slof/fs/pci-class-code-names.fs +++ b/slof/fs/pci-class-code-names.fs @@ -254,11 +254,11 @@ 0A OF pci-class-name-0A ENDOF 0B OF pci-class-name-0B ENDOF 0C OF pci-class-name-0C ENDOF - 0C OF pci-class-name-0D ENDOF - 0C OF pci-class-name-0E ENDOF - 0C OF pci-class-name-0F ENDOF - 0C OF pci-class-name-10 ENDOF - 0C OF pci-class-name-11 ENDOF + 0D OF pci-class-name-0D ENDOF + 0E OF pci-class-name-0E ENDOF + 0F OF pci-class-name-0F ENDOF + 10 OF pci-class-name-10 ENDOF + 11 OF pci-class-name-11 ENDOF dup OF drop s" unknown" ENDOF ENDCASE ;
This will allow SLOF to print the appropriate name instead of "unknown" for PCI classes 0xd to 0x11. Signed-off-by: Greg Kurz <groug@kaod.org> --- slof/fs/pci-class-code-names.fs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)