From patchwork Mon Sep 19 08:46:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 1716304 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=KU641u1b; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NY6K108NNz240X for ; Fri, 16 Dec 2022 09:26:29 +1100 (AEDT) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NY6K06Pgrz2yZv for ; Fri, 16 Dec 2022 09:26:28 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=KU641u1b; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::436; helo=mail-pf1-x436.google.com; envelope-from=linmq006@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=KU641u1b; dkim-atps=neutral Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4MWJFJ6tWmz2xMS for ; Mon, 19 Sep 2022 18:46:42 +1000 (AEST) Received: by mail-pf1-x436.google.com with SMTP id y136so27421292pfb.3 for ; Mon, 19 Sep 2022 01:46:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=bzgUrsroAFmtHh2weEjHB/THJP/pixrVn5RvrnA9Hs4=; b=KU641u1budhuNPnWMqWeRMvNpnLpK5PBlOdk4/ev6rFK906m50xt4Vfl7g7evVfBLH dNBH+HpLPLfqXI4kANLj+K9eXk4FGuvBxg8PqstX1wcytDGmjWMGGriEyyG+nV4HllLy lAhIOcOaGk7R8CGw8b7/BqcrlYkBM0TBpRb4+74nmky0AlKBUn3mS83iLFAzDCQMRqw3 HauODqA+cEc86nsJ+UUfKBFHlholGtajoafQ1XjlGa9uwHDcwSxwzRFGufAugELGCBmT VePqos4F8S5PaH3W5m7z7/MXcnsuGDqyMEbGqXq2ptpV0q/hnxNopxnPcnNVqcU6uvno lFkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=bzgUrsroAFmtHh2weEjHB/THJP/pixrVn5RvrnA9Hs4=; b=6RH0Zp1Jk1U3MUAmSRczrBQZ0tGm5WMn55AAuwUuJA6bN/zNaCQzZYwqKOMF0lLoxM /+6nfBanK/eSXpG5fbBczJOe5LKYZOIYHp0/XOTNGiCdZYMzU1jZBf6PxosXAUIMZz4U S9ziY1Cui4hEM21fG+LCz58DR1c43DihT7/53lE1zIw6TpKMYAmVrBJkkSELFgSglddw VccORW0UUIYp+lYqMt9YZZ2GM/NkXqtKyX/U/kG2uXIvoTxss01YIYxOPPPfGyKh3ie4 WtV3f6ThP5smfjIh8QbwTcUaDenhpstrMdfT31am8uvqg9oUTPi63VkOifV6E61pesr8 PRDg== X-Gm-Message-State: ACrzQf2yZWaJNMG9cR54U6FzQy11rkur0iWndOlUo3g3+j/kYOZzSB+6 +NrZ8Eac3ZVImCowSKTJ8dlWgbLWmSwPV5oe X-Google-Smtp-Source: AMsMyM5TysEM43meN1bxAd16IBxwZyZ7WLiY2587T54uN2TccAZD+CU+K9LxGq6MSkRRpjfIG53u7Q== X-Received: by 2002:a05:6a00:8c8:b0:52c:887d:fa25 with SMTP id s8-20020a056a0008c800b0052c887dfa25mr17240913pfu.86.1663577197261; Mon, 19 Sep 2022 01:46:37 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id 129-20020a620487000000b0053e984a887csm20032718pfe.96.2022.09.19.01.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 01:46:36 -0700 (PDT) From: Miaoqian Lin To: skiboot@lists.ozlabs.org Date: Mon, 19 Sep 2022 12:46:10 +0400 Message-Id: <20220919084610.25420-1-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Mailman-Approved-At: Fri, 16 Dec 2022 09:26:16 +1100 Subject: [Skiboot] [PATCH] opal-prd: Fix missing cleanups in chip_init X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Miaoqian Lin Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" 1. The function calls opendir() but missing the corresponding closedir() before exit the function. 2. asprintf() alloc memory for path, we need to free it after use. Add missing closedir() and free() to fix it. Signed-off-by: Miaoqian Lin --- external/opal-prd/opal-prd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c index 1c610da4c0b6..ed47260d23bd 100644 --- a/external/opal-prd/opal-prd.c +++ b/external/opal-prd/opal-prd.c @@ -1290,22 +1290,28 @@ static int chip_init(void) dirent->d_name); if (rc < 0) { pr_log(LOG_ERR, "FW: Failed to create chip-id path"); + closedir(dir); return -1; } rc = open_and_read(path, &buf, &len); if (rc) { pr_log(LOG_ERR, "FW; Failed to read chipid"); + closedir(dir); + free(path); return -1; } chipid = buf; chips[nr_chips++] = be32toh(*chipid); + free(path); } pr_log(LOG_DEBUG, "FW: Chip init"); for (i = 0; i < nr_chips; i++) pr_log(LOG_DEBUG, "FW: Chip 0x%lx", chips[i]); + closedir(dir); + return 0; }