From patchwork Sat May 7 06:36:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Singh Tomar X-Patchwork-Id: 1627840 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=ASA6gyHn; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KwHmV4CXWz9sGV for ; Sat, 7 May 2022 16:37:30 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KwHmV2jGDz3cCJ for ; Sat, 7 May 2022 16:37:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=ASA6gyHn; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=abhishek@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=ASA6gyHn; dkim-atps=neutral Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KwHlp55mnz3c9Q for ; Sat, 7 May 2022 16:36:54 +1000 (AEST) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2476Ejtj011607 for ; Sat, 7 May 2022 06:36:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=CBWs6Cls2RP+qOwHtMV2lgSUOpGL+7XFRCGe4xRnTLc=; b=ASA6gyHnbb5X4NFUQkFD7ezQInBLO6tE+38UUcv3z/mt08sN4ibFCLbeq4BBVY1Gq/JK kZrdIS6EUCFqP/Or0zlrjwyM+bekkbD8izEOT8Ml5isOD7ik6C+VKcjHvne5TKQYoj2v DUZ4+w5Ee6T0zmJFpuPzUbp+pi2lhWxmZLtVWajejZz7WN3y9Zmegz6fzEtCSqrmSS+4 fVyOi6hrZiS2LXIcxsm5gmrcmXrx6IKcHGOF+Q1HRK0GsI5n9e9oI0atDJFiSRWnSNks RoY+RqKCq9DqBo7YPZPHhTCkey+lOZ4J1BR57snEEAJCcBtBfcY9CQsx20P4pbvYrFaW uw== Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fwkb406h7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 07 May 2022 06:36:51 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2476ZJkk002478 for ; Sat, 7 May 2022 06:36:49 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma06ams.nl.ibm.com with ESMTP id 3fwg1j06d5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 07 May 2022 06:36:49 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2476abZt29032758 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 7 May 2022 06:36:37 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 841E85204F; Sat, 7 May 2022 06:36:46 +0000 (GMT) Received: from li-22421c4c-355e-11b2-a85c-fdc6c782cba9.ibm.com.com (unknown [9.43.76.43]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 41A275204E; Sat, 7 May 2022 06:36:44 +0000 (GMT) From: Abhishek Singh Tomar To: skiboot@lists.ozlabs.org Date: Sat, 7 May 2022 12:06:02 +0530 Message-Id: <20220507063602.66309-10-abhishek@linux.ibm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220507063602.66309-1-abhishek@linux.ibm.com> References: <20220507063602.66309-1-abhishek@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: PxPdIcomulCNe52z1cmdeZ4761nH0Xlk X-Proofpoint-GUID: PxPdIcomulCNe52z1cmdeZ4761nH0Xlk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-07_01,2022-05-06_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=999 impostorscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 suspectscore=0 mlxscore=0 adultscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205070041 Subject: [Skiboot] [PATCH v2 9/9] core/pldm/test : pldm FRU implementation to retrieve the bmc information X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Abhishek Singh Tomar Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" This patch do self test to retrive BMC version information Signed-off-by: Abhishek Singh Tomar --- core/pldm/test/test_pldm-fru.c | 118 ++++++++++++++++++++++++++++++++- 1 file changed, 115 insertions(+), 3 deletions(-) diff --git a/core/pldm/test/test_pldm-fru.c b/core/pldm/test/test_pldm-fru.c index 049dbce8..53232399 100644 --- a/core/pldm/test/test_pldm-fru.c +++ b/core/pldm/test/test_pldm-fru.c @@ -124,6 +124,56 @@ int pldm_test_reply_request(void *request_msg, size_t request_len, } +/* + * This function tries to duplicate BMC functionality for Pldm self test + * It generate reply for PLDM_GET_FRU_RECORD_BY_OPTION for self test. + * It generates fru Dta structure with BMC version tlv + */ +int pldm_test_generate_reply_field_type_version(uint8_t record_type, uint8_t field_type, + uint8_t **fru_table, size_t *fru_table_size) +{ + struct pldm_fru_record_tlv *tlv; + int tlv_size, ret; + size_t curr_size = 0; + size_t pad_bytes = 0; + uint32_t checksum; + + if (field_type == PLDM_FRU_FIELD_TYPE_VERSION && + record_type == PLDM_FRU_RECORD_TYPE_GENERAL) { + + tlv_size = sizeof(struct pldm_fru_record_tlv) + strlen(TEST_BMC_VERSION) - 1; + tlv = malloc(tlv_size); + tlv->type = PLDM_FRU_FIELD_TYPE_VERSION; + tlv->length = strlen(TEST_BMC_VERSION); + memcpy(tlv->value, TEST_BMC_VERSION, tlv->length); + *fru_table_size = sizeof(struct pldm_fru_record_data_format) + tlv->length - 1; + + /* Culculate pad bytes in fru */ + if (*fru_table_size % 4) + pad_bytes = 4 - (*fru_table_size % 4); + else + pad_bytes = 0; + + *fru_table = malloc(*fru_table_size + pad_bytes + sizeof(uint32_t)); + ret = encode_fru_record(*fru_table, *fru_table_size, &curr_size, 0, + PLDM_FRU_RECORD_TYPE_GENERAL, 1, 1, (uint8_t *)tlv, tlv_size); + if (ret != PLDM_SUCCESS) + return ret; + *fru_table_size += pad_bytes + sizeof(uint32_t); + + /* Pad with 0 */ + memset(*fru_table + curr_size, 0, pad_bytes); + + checksum = htole32(pldm_crc32(*fru_table, *fru_table_size - sizeof(uint32_t))); + memcpy(*fru_table + curr_size + pad_bytes, (void *)&checksum, sizeof(uint32_t)); + free(tlv); + } else + return OPAL_PARAMETER; + + return PLDM_SUCCESS; +} + + /* * This function tries to duplicate BMC functionality for Pldm self test * it tries to handle PLDM_REQUEST for PLDM_FRU and reply with appropriate @@ -132,12 +182,60 @@ int pldm_test_reply_request(void *request_msg, size_t request_len, int pldm_test_reply_request_fru(void *request_msg, size_t request_len, void **response_msg, size_t *response_len) { + int ret, payload_len = 0; + uint32_t transfer_handle; + uint16_t fru_table_handle; + uint16_t record_set_identifier; + uint8_t record_type; + uint8_t field_type; + uint8_t transfer_op_flag; + uint8_t *fru_ds; + size_t fru_ds_size; + + /* Check PLDM command and reply with appropriate reply */ switch (((struct pldm_msg *)request_msg)->hdr.command) { case PLDM_GET_FRU_RECORD_BY_OPTION: - (void)request_len; - *response_msg = NULL; - *response_len = 0; + payload_len = request_len - sizeof(struct pldm_msg_hdr); + ret = decode_get_fru_record_by_option_req(request_msg, payload_len, + &transfer_handle, &fru_table_handle, &record_set_identifier, + &record_type, &field_type, &transfer_op_flag); + if (ret != PLDM_SUCCESS) + return ret; + /* + * Test if field type and record type is as expected i.e. + * field type = PLDM_FRU_FIELD_TYPE_VERSION and + * record_type == PLDM_FRU_RECORD_TYPE_GENERAL + * else return error + */ + if (field_type == PLDM_FRU_FIELD_TYPE_VERSION && + record_type == PLDM_FRU_RECORD_TYPE_GENERAL) { + + /* + * generate the fru data structure to reply request + * on behalf on BMC for PLDM self test + */ + ret = pldm_test_generate_reply_field_type_version( + PLDM_FRU_RECORD_TYPE_GENERAL, + PLDM_FRU_FIELD_TYPE_VERSION, &fru_ds, &fru_ds_size); + if (ret != PLDM_SUCCESS) + return ret; + + payload_len = fru_ds_size + + sizeof(struct pldm_get_fru_record_by_option_resp) - 1; + *response_len = sizeof(struct pldm_msg_hdr) + payload_len; + *response_msg = malloc(*response_len); + + ret = encode_get_fru_record_by_option_resp( + ((struct pldm_msg *)request_msg)->hdr.instance_id, + PLDM_SUCCESS, PLDM_GET_NEXTPART, PLDM_START_AND_END, + fru_ds, fru_ds_size, *response_msg, payload_len); + if (ret != PLDM_SUCCESS) + return ret; + free(fru_ds); + return PLDM_SUCCESS; + } else + return OPAL_PARAMETER; break; default: return PLDM_ERROR_INVALID_DATA; @@ -199,6 +297,7 @@ int main(void) int ret; void *fru_record_table; uint32_t fru_record_table_size; + struct variable_field fru_structure_data; /* * Trying to get fru table when fru table not created @@ -220,5 +319,18 @@ int main(void) if (ret != PLDM_SUCCESS) return OPAL_PARAMETER; + /* retrieve the bmc information with + * "FRU Field Type": Version + * "FRU Record Set Identifier": 1, + * "FRU Record Type": "General(1)" + */ + ret = pldm_fru_get_record_by_option(0, 1, PLDM_FRU_RECORD_TYPE_GENERAL, + PLDM_FRU_FIELD_TYPE_VERSION, &fru_structure_data); + if (ret != PLDM_SUCCESS) { + perror("encode_get_fru_record_table_metadata_req"); + return ret; + } + + }