From patchwork Fri Dec 17 02:17:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1569674 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=GLwIVT0V; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JFXh42hJbz9t2p for ; Fri, 17 Dec 2021 13:17:56 +1100 (AEDT) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JFXh36k0Rz30JT for ; Fri, 17 Dec 2021 13:17:55 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=GLwIVT0V; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::536; helo=mail-pg1-x536.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=GLwIVT0V; dkim-atps=neutral Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JFXgn4Pf1z3036 for ; Fri, 17 Dec 2021 13:17:41 +1100 (AEDT) Received: by mail-pg1-x536.google.com with SMTP id j11so751741pgs.2 for ; Thu, 16 Dec 2021 18:17:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PXDkixmzzEAPwYJZz+MYwYFRJigA9qSbmmykbS20v3Y=; b=GLwIVT0VsUIGKrGRrqONXl8X7oVATisEiwiEsplGJjcyaeGn0GTTrZsTE2HmGzBCNi MRJJC3qKBBO1ZxbLJCUN3htUlRqJZe8K1w5g/8kIzZpHowH/1/lawgPHNYKyLJ3vaVtB DL/vQkBeODjCGpvy19vaG05B0Hz8lX0g4fqqPP1k7cLwhSNjRsmeGxfwLqNjJFAkeG70 Ck9jHTt4NlOLg2BP9OKmnPUwE8tOctv3xbO3lsehbLnftWiw25+1sN2Nj1H6MV2VBvuo BAVE2TZ454x4AbiX7hCVbCq5+AUfhcVxg8TkhyCUjm2CE9MKhPAb9BCKYqXNNg3zv3Bb 8TWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PXDkixmzzEAPwYJZz+MYwYFRJigA9qSbmmykbS20v3Y=; b=RrpSGvMap2xLCKGH+esoeZp/yvwI1HGfwl6xgeraq+4r8AjrnL7FMYiqwYbJACsXGX HWIf13stnHbOcBmXSjYsAwCd+Ms48gFlv6k1wFF4uio/dsxh2LQ+NXcCO1T+kbNejYQB PcjbFgnvFCVaVIJ3h7dvGV7EEiK9odmcouVhOZF0E/mhAh3WY0rhvDTBQyxNL9WInVN8 +ZVow68gG9RRdsfNCLjSnMKq2NyFFTqQ4lp6fKpEFaNRH8WCgz82A5siLldmWa7H5zV9 bH+w49nXjdWTAHea3QdblcnX94cGgv1xt0pBb2J0F7x74aU0ki/n9NdgsRS8wfnSKTiD DEwQ== X-Gm-Message-State: AOAM53050xzVnefcqH7i1ppWpGsqxhp8JWGqPF7E1iciyjwqVqQ6VswT 4OinG+oI125uQdE9VtNXAcEKC1lAKag= X-Google-Smtp-Source: ABdhPJwVv9LpdW2DZxwdKC3ecpG2wMxH1GTWe/eakG19XwkMEFAgVQAeeuHIxWOjQs22+LZWBNT5uA== X-Received: by 2002:a63:e4f:: with SMTP id 15mr957946pgo.336.1639707457249; Thu, 16 Dec 2021 18:17:37 -0800 (PST) Received: from bobo.ozlabs.ibm.com (203-219-139-206.static.tpgi.com.au. [203.219.139.206]) by smtp.gmail.com with ESMTPSA id k16sm7982639pfu.183.2021.12.16.18.17.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Dec 2021 18:17:37 -0800 (PST) From: Nicholas Piggin To: skiboot@lists.ozlabs.org Date: Fri, 17 Dec 2021 12:17:20 +1000 Message-Id: <20211217021724.709370-3-npiggin@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20211217021724.709370-1-npiggin@gmail.com> References: <20211217021724.709370-1-npiggin@gmail.com> MIME-Version: 1.0 Subject: [Skiboot] [PATCH v2 2/6] core/cpu: remove POWER8 IPI loop X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" POWER8 does not have to loop sending IPIs until the destination wakes up. cpu_wake() only sends IPI so that should be enough here too. This will help the next patch make a common IPI sending function. Signed-off-by: Nicholas Piggin --- core/cpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/core/cpu.c b/core/cpu.c index 1371cd34e..20b3f6af3 100644 --- a/core/cpu.c +++ b/core/cpu.c @@ -609,10 +609,8 @@ static void reconfigure_idle_start(void) if (proc_gen == proc_gen_p8) { for_each_available_cpu(cpu) { - while (cpu->in_sleep || cpu->in_idle) { + if (cpu->in_sleep || cpu->in_idle) icp_kick_cpu(cpu); - cpu_relax(); - } } } else if (proc_gen == proc_gen_p9 || proc_gen == proc_gen_p10) { for_each_available_cpu(cpu) {