Message ID | 20211003012210.1165606-3-npiggin@gmail.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=KYb5PaOT; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=<UNKNOWN>) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HMR0v18hcz9t0p for <incoming@patchwork.ozlabs.org>; Sun, 3 Oct 2021 12:22:39 +1100 (AEDT) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HMR0t6ls8z2yxV for <incoming@patchwork.ozlabs.org>; Sun, 3 Oct 2021 12:22:38 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=KYb5PaOT; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::52a; helo=mail-pg1-x52a.google.com; envelope-from=npiggin@gmail.com; receiver=<UNKNOWN>) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=KYb5PaOT; dkim-atps=neutral Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HMR0Z6JRkz2yHW for <skiboot@lists.ozlabs.org>; Sun, 3 Oct 2021 12:22:22 +1100 (AEDT) Received: by mail-pg1-x52a.google.com with SMTP id r201so7167461pgr.4 for <skiboot@lists.ozlabs.org>; Sat, 02 Oct 2021 18:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=isdCaJheXmSI6QdCv00Bl1gUgLoE2+n4bbHnJ+jVd1E=; b=KYb5PaOTbKzseidvhIOgOb6FtZZ2JdRlbD4lIATki9TpxoujLo/Ro2fmI4Fg/IGd8d CKKRSZ+DNAXo8vYpVQJKon2iaqOjwvZCivFXrGS7zKtO8gq8ViXnVhHSmH/FaCAy8+jt KDjBl3pq8MD/BGWG9ivOFax8rOHADD0kR2fGqD6lOVjKCOhxQ18OI2oaHI5fXvMl/B88 7FvLl3m5cjh1bfOzA/++S+shSjBFHEdxXGyVZbQV4rFxyso2Nk8VtXZxklDiQ/RqjgbJ 2LLmZBQVEBRFAuPc/P108bF7GPXb1eQ5qKEQ6SdqLvNJ9HeyOX2s7yyC9e2oIdv92w10 Azsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=isdCaJheXmSI6QdCv00Bl1gUgLoE2+n4bbHnJ+jVd1E=; b=bXMGIuz7TDx0z+6XPoNcIPlh+exi3XnsTjsQ+v4DSYK5W/YQzBQG9pTOUOOuMfxLq4 TjsNCOAEcolfJYz+6TsnOHBPMcjUvFNDCoZ9cLeviAtC0cxMO24tvcqzkVZ0FC5Gn2Fe Bk0OCt8/cg9SRra8I5jJiO8QfImVsGRyX7mR3k88uqT1j6KFmP5E8i1NFhqqZVmF4uhE tEfEmc25q/NAU6zNw9wHIRTNzS9t6TlszkLbCaRR/Z2ugyq+ezBDI9yri1xDMHXZSa/7 EoefTdLy7rYbyhCGsbK/jQo+cA4iG/rQP5rcpNh5Sv/7fb4kpbd0U/RSjKXmjib250cD YGmw== X-Gm-Message-State: AOAM530cJe2AhiT/wfR4ms93CR2C2PMqrop1pb4Ef7I3nUhxxT/a3epb oUp1K3Ckwo7XNyckkPwKvO0jJQ8Karg= X-Google-Smtp-Source: ABdhPJxLmkNRCUA5PKQFzPVjv+P7IAlgWdR9BzzhAviqO3cCwyncfSeOn4eT2X8D59Nh+0Ib7TFhQg== X-Received: by 2002:a63:da14:: with SMTP id c20mr4962553pgh.155.1633224140288; Sat, 02 Oct 2021 18:22:20 -0700 (PDT) Received: from bobo.ibm.com (115-64-153-41.tpgi.com.au. [115.64.153.41]) by smtp.gmail.com with ESMTPSA id z3sm11158058pfe.78.2021.10.02.18.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Oct 2021 18:22:20 -0700 (PDT) From: Nicholas Piggin <npiggin@gmail.com> To: skiboot@lists.ozlabs.org Date: Sun, 3 Oct 2021 11:22:04 +1000 Message-Id: <20211003012210.1165606-3-npiggin@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20211003012210.1165606-1-npiggin@gmail.com> References: <20211003012210.1165606-1-npiggin@gmail.com> MIME-Version: 1.0 Subject: [Skiboot] [PATCH 2/8] cpu: cpu_idle_job SMT priority fix X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development <skiboot.lists.ozlabs.org> List-Unsubscribe: <https://lists.ozlabs.org/options/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe> List-Archive: <http://lists.ozlabs.org/pipermail/skiboot/> List-Post: <mailto:skiboot@lists.ozlabs.org> List-Help: <mailto:skiboot-request@lists.ozlabs.org?subject=help> List-Subscribe: <https://lists.ozlabs.org/listinfo/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> |
Series |
various fixes
|
expand
|
diff --git a/core/cpu.c b/core/cpu.c index f58aeb27a..5c10fc6e8 100644 --- a/core/cpu.c +++ b/core/cpu.c @@ -547,7 +547,6 @@ void cpu_idle_job(void) while (!cpu_check_jobs(cpu)) { if (pm_enabled) break; - cpu_relax(); barrier(); } smt_medium();
Calling cpu_relax resets the SMT priority to medium, causing the idle loop not to run with lowest priority. Just use barrier() instead, this saves about 3 seconds on a SMT4 systemsim (mambo) boot. Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- core/cpu.c | 1 - 1 file changed, 1 deletion(-)