Message ID | 20210811054851.861482-5-npiggin@gmail.com |
---|---|
State | Superseded |
Headers | show
Return-Path: <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Nje8+8SP; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GkzRF36rhz9sWd for <incoming@patchwork.ozlabs.org>; Wed, 11 Aug 2021 15:49:29 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GkzRF2MX8z3bWJ for <incoming@patchwork.ozlabs.org>; Wed, 11 Aug 2021 15:49:29 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Nje8+8SP; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::102f; helo=mail-pj1-x102f.google.com; envelope-from=npiggin@gmail.com; receiver=<UNKNOWN>) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Nje8+8SP; dkim-atps=neutral Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GkzQr4YnCz30Jj for <skiboot@lists.ozlabs.org>; Wed, 11 Aug 2021 15:49:08 +1000 (AEST) Received: by mail-pj1-x102f.google.com with SMTP id a8so1661285pjk.4 for <skiboot@lists.ozlabs.org>; Tue, 10 Aug 2021 22:49:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xFwpi8KNuaGPZ1V25CnJ1ovqFl4NLgdyLvzr4Ev29go=; b=Nje8+8SP9JkCaA3eDebbA3GTM8ah6hbweBAX+4QS6tK1XNYiL4lUW70jT3yUYTVaBl SBEFG0M4bQ7m9+o/xM/Z8GpWkkjmf5d5KF73Y4xKRHF+PdZlOtL4xfvHZAtPSQtqJICZ o16jPi8ZHPdhJtMWlE7o9cqpxBjrUGbfHuT6SN9FzRhrWCys8euAdSB4cJFC33YhXhc+ z1LQ7ZFilJerS3UCpT1UsfN+gGtgZQWDOJ0G9LK9UooVm0NA7PswREiqrIpa7ry4F6+J nmc8t54+33xdMauN3wVKCurs02pEjTjq280mAHi/HjhgVKd1mvUvoE6CZkVdhQoniJbu DWsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xFwpi8KNuaGPZ1V25CnJ1ovqFl4NLgdyLvzr4Ev29go=; b=mAOg9b/TfTWq3IajIjpe2mpX74gPOWmO//7sqhgk0ZSfDXFt6uAKswqq/bHQ30l+9H PLEyHqjrfonUIA1G1kMPPqGd82TxV+F5URY0TXOSTBeZH3l5hl26CUhHfpXouroTotaf gjRE2UzidtKL2ltSsUTquaG5LUSyg1ijIXQlNrtFzBQL+WObIUhwzH6erFyuz9lUFXeq kkU/QQe3DZrr4XRioEGbg52aDZwVRBvCL+kvx41/NzRBXoQGZ+OsKs8Qb515WyRwzz04 1rhwYRAQdHkOt8cl654wmqmF1lTRdU2QKnhNSVuxlKfTR+yM4javNIxnRD23pXcVbKA0 kvDw== X-Gm-Message-State: AOAM531+/JpNUJP1g61z2UAVb16NT7rCfnXZ145OIRJYnngJby7q1ybx irGEgD1MxLtSAWQU93Im4loDXfCWwZY= X-Google-Smtp-Source: ABdhPJzs1A722l08NtCgcT+uTKObQGAb6zsAuVmxRP/Ec/qHtADTJcL8Q1iXLeBWBmC44vYCONtcYw== X-Received: by 2002:a65:6107:: with SMTP id z7mr133019pgu.43.1628660946013; Tue, 10 Aug 2021 22:49:06 -0700 (PDT) Received: from bobo.ibm.com ([118.210.97.79]) by smtp.gmail.com with ESMTPSA id q1sm1222317pjl.44.2021.08.10.22.49.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 22:49:05 -0700 (PDT) From: Nicholas Piggin <npiggin@gmail.com> To: skiboot@lists.ozlabs.org Date: Wed, 11 Aug 2021 15:48:49 +1000 Message-Id: <20210811054851.861482-5-npiggin@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210811054851.861482-1-npiggin@gmail.com> References: <20210811054851.861482-1-npiggin@gmail.com> MIME-Version: 1.0 Subject: [Skiboot] [PATCH v1 4/6] core/cpu: move cpu_wake out of job_lock X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development <skiboot.lists.ozlabs.org> List-Unsubscribe: <https://lists.ozlabs.org/options/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe> List-Archive: <http://lists.ozlabs.org/pipermail/skiboot/> List-Post: <mailto:skiboot@lists.ozlabs.org> List-Help: <mailto:skiboot-request@lists.ozlabs.org?subject=help> List-Subscribe: <https://lists.ozlabs.org/listinfo/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> |
Series |
idle synchronisation improvements
|
expand
|
diff --git a/core/cpu.c b/core/cpu.c index d77ab7c93..0b05d28c6 100644 --- a/core/cpu.c +++ b/core/cpu.c @@ -192,8 +192,9 @@ static void queue_job_on_cpu(struct cpu_thread *cpu, struct cpu_job *job) cpu->job_has_no_return = true; else cpu->job_count++; - cpu_wake(cpu); unlock(&cpu->job_lock); + + cpu_wake(cpu); } struct cpu_job *__cpu_queue_job(struct cpu_thread *cpu,
There is no need to keep the IPI initiation under the job_lock. If the target does wake after the job is queued and before we can send the IPI, it will check for new jobs. Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- core/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)