From patchwork Tue Jan 21 07:28:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver O'Halloran X-Patchwork-Id: 1226267 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4820XL27Jmz9sPJ for ; Tue, 21 Jan 2020 18:29:06 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=mUg/mou+; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4820XL1cvSzDqTx for ; Tue, 21 Jan 2020 18:29:06 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::444; helo=mail-pf1-x444.google.com; envelope-from=oohall@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=mUg/mou+; dkim-atps=neutral Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4820X75lBTzDqTJ for ; Tue, 21 Jan 2020 18:28:53 +1100 (AEDT) Received: by mail-pf1-x444.google.com with SMTP id i6so1042498pfc.1 for ; Mon, 20 Jan 2020 23:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b9/6clzKCyggaW6BV//9KX6hHKPow/bX4HKCAa7jf8Y=; b=mUg/mou+f87b2+2RXbXLrMaYY4H50eVjdUL74WC5Afdg5Gy9zA9FLgKNQjTfdsXgQ/ VQuMYZTmWeHfLMEnOKoTQTixlX/CPMhM7wuJMwn7jwNF61qPNrM75xOteBw4T57UHD74 cLyVGkyVHvZPWJw3qaJr380I9CtI5oEnHFzbzZig+sDByfTneeBg7+R6EBe69NdfF6yC GNb9j6zQgcEUhexqDognI7ipM9ZZdQG1NJuNM4VluyQ02p+EtEmflfIUZUO5Gv7Hv/ms LXuneicTc7/t7eBSkk9QZWft8jbSc0e1Qr4RXwMYJeKFSChLZjtkQY0Jrf5RmnTFdvDE p/qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=b9/6clzKCyggaW6BV//9KX6hHKPow/bX4HKCAa7jf8Y=; b=ZadQMJkGc6BSTHa2PoNpx7UDoPAaXHN4w2AMwcphdRQxFy6kPMT3ccRFeffrrq10Ri Vq6v7yxi2qezYnDPg9fRdJ7beYnISgMzs6G1LUmvk0qVPcYURho2ID4cFB0JBg7TxfhH mdcyXmCkgAA6WUiZ7QVnXLe/8xyVXUk7mhUgd2e9nn3SaLfnfJ2ZvtV7eIByGh97ryzo 5BDNVSV7QAVBLZIbdnYMDJFI+V4o12z1IE19I4h5lQP0STuJczL4p4wl+pnsBr1A3jXb RitazKeKfxrrRUHcr7Hm1Xd+theVDYMjLE0LE0DRZFK84ambw5rNiGsl4FpQ+CEdP1JH hhTg== X-Gm-Message-State: APjAAAVj3fzm7drbygJgVLHDlKzVc8bUVmXQmvvOViJ/RBNu4EIet0+U 176Sd0mJrPJvKqFAHIdDjdmBuu3w X-Google-Smtp-Source: APXvYqzVvLCjjApuEtZF8ow0nEQDx103kH+AWVYhPID50UWu9uiI3NFpS9i5hi9e1fH3UVddsuQrSA== X-Received: by 2002:a63:3196:: with SMTP id x144mr3924481pgx.319.1579591729729; Mon, 20 Jan 2020 23:28:49 -0800 (PST) Received: from wafer.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id u3sm41027750pga.72.2020.01.20.23.28.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 23:28:49 -0800 (PST) From: Oliver O'Halloran To: skiboot@lists.ozlabs.org Date: Tue, 21 Jan 2020 18:28:34 +1100 Message-Id: <20200121072838.2771-1-oohall@gmail.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Subject: [Skiboot] [PATCH 1/5] hw/phb4: Make error interrupt handler compile X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" When phb4.c was copied from phb3.c the error interrupts were disabled by default and apparently never re-enabled. Remove the #if 0 block and call phb4_set_err_pending() rather than the phb3 version. Signed-off-by: Oliver O'Halloran --- hw/phb4.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/phb4.c b/hw/phb4.c index ed7f4e5c4756..0b7bf778a50e 100644 --- a/hw/phb4.c +++ b/hw/phb4.c @@ -5585,7 +5585,6 @@ static void phb4_err_interrupt(struct irq_source *is, uint32_t isn) PHBDBG(p, "Got interrupt 0x%08x\n", isn); -#if 0 /* Update pending event */ opal_update_pending_evt(OPAL_EVENT_PCI_ERROR, OPAL_EVENT_PCI_ERROR); @@ -5598,8 +5597,7 @@ static void phb4_err_interrupt(struct irq_source *is, uint32_t isn) * Mark the PHB has pending error so that the OS * can handle it at late point. */ - phb3_set_err_pending(p, true); -#endif + phb4_set_err_pending(p, true); } static uint64_t phb4_lsi_attributes(struct irq_source *is __unused,