From patchwork Mon Dec 9 01:14:35 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Oliver O'Halloran X-Patchwork-Id: 1205829 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47WQJy2n44z9sNH for ; Mon, 9 Dec 2019 12:17:06 +1100 (AEDT) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="vc2bUO7Y"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47WQJy1jcZzDqN3 for ; Mon, 9 Dec 2019 12:17:06 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::444; helo=mail-pf1-x444.google.com; envelope-from=oohall@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="vc2bUO7Y"; dkim-atps=neutral Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47WQGm326JzDqLb for ; Mon, 9 Dec 2019 12:15:12 +1100 (AEDT) Received: by mail-pf1-x444.google.com with SMTP id b19so6351804pfo.2 for ; Sun, 08 Dec 2019 17:15:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PLN1lht5yTvekW1Mdkbi/yGEGYHRVPB9zUfUA1x4hpU=; b=vc2bUO7YveNLV+teV/x0InuwmMnbBczX4QTMW2XROJx+QuKynDPqSH3CXzijJcU1YS 8KXmOtAwgEUK95+vMSddcEQRyf90wa4NryKgUwuTuA0z0thfwLvKe7Tl96y0odknGoeB F/jabqbEMswGR0FdWBU89rHhjPJpc7np/cKp1tbP544VDoE2QAFOvUoIrGVqFXYL5ov2 MkkxkSjEaWzgtAFuILhztqoXdgK6oX3F/Mxt+q7PNzJE34PNHWp/GQu18eSPwXu6OGyN 93ds7KwWrlm4VZ06G1IrBBVS38UV+ZrxXgc11HsMkIzfWxX8RELSxFHQ7NYtHpRh8wjM Gseg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PLN1lht5yTvekW1Mdkbi/yGEGYHRVPB9zUfUA1x4hpU=; b=AeC9SdusdsBDW38dAICqGcb7DgRo45YnwG7dR1baOxns/7qy4oKT33S1+Vz3uetzoL MzGtsRh00I81oKoqE0yJGn+BpWmL1j+MddMabkHi7fknNVHy5zX5JCnCX+G4jTuN7xtX 3IeXZPxh+sLF92MfbGDkGyaOacYMwzjqFcLd61CwYk2/Ra/qjXdiibTWboPJ/XuDBXaL jbj4WZhvWM1g08oVhThse0gw6Uq64ewj7Vg1giLo6D7ZKmRETuFjNWfTC6Ork+UxzTIW OuzkSt5SNMoam0vyYHrPNfryigOgZ6b7dDLntG7yNrTLWqqCM+K4ZZSNtaHxXmRTqEfE /2zg== X-Gm-Message-State: APjAAAVk/oBRU+jPZt+oe9Q55TdfS5QqZdEKuAAoJdipPedL4ewSPRvD Kq7ayPOqE1HdMp+PiM1OAScQBnBI X-Google-Smtp-Source: APXvYqwt+kTW42I+AmjqNaWqkCkzLuy3j1GC5zLhEiVeTFmmdeRGqCQdieuDrQWp85sk2sUx+CxOqw== X-Received: by 2002:a63:d017:: with SMTP id z23mr16197970pgf.110.1575854109430; Sun, 08 Dec 2019 17:15:09 -0800 (PST) Received: from wafer.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id p68sm25529560pfp.149.2019.12.08.17.15.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Dec 2019 17:15:09 -0800 (PST) From: Oliver O'Halloran To: skiboot@lists.ozlabs.org Date: Mon, 9 Dec 2019 12:14:35 +1100 Message-Id: <20191209011448.19319-5-oohall@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191209011448.19319-1-oohall@gmail.com> References: <20191209011448.19319-1-oohall@gmail.com> MIME-Version: 1.0 Subject: [Skiboot] [PATCH 05/18] skiboot v6.3.3 release notes X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" From: Vasant Hegde Signed-off-by: Vasant Hegde [oliver: cherry picked into master, better late than never] Signed-off-by: Oliver O'Halloran --- doc/release-notes/skiboot-6.3.3.rst | 73 +++++++++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 doc/release-notes/skiboot-6.3.3.rst diff --git a/doc/release-notes/skiboot-6.3.3.rst b/doc/release-notes/skiboot-6.3.3.rst new file mode 100644 index 000000000000..c2d21a1f7c33 --- /dev/null +++ b/doc/release-notes/skiboot-6.3.3.rst @@ -0,0 +1,73 @@ +.. _skiboot-6.3.3: + +============== +skiboot-6.3.3 +============== + +skiboot 6.3.3 was released on Wednesday Aug 6th, 2019. It replaces +:ref:`skiboot-6.3.2` as the current stable release in the 6.3.x series. + +It is recommended that 6.3.3 be used instead of any previous 6.3.x version +due to the bug fixes it contains. + +Bug fixes included in this release are: + +- struct p9_sbe_msg doesn't need to be packed + + Only the reg member is sent anywhere (via xscom_write), so the structure + does not need to be packed. + +:: + Fixes GCC9 build problem: + hw/sbe-p9.c: In function ‘p9_sbe_msg_send’: + hw/sbe-p9.c:270:9: error: taking address of packed member of ‘struct p9_sbe_msg’ may result in an unaligned p + ointer value [-Werror=address-of-packed-member] + 270 | data = &msg->reg[0]; + | ^~~~~~~~~~~~ + +- hdata/vpd: fix printing (char*)0x00 + GCC9 now catches this bug: + +:: + In file included from hdata/vpd.c:17: + In function ‘vpd_vini_parse’, + inlined from ‘vpd_data_parse’ at hdata/vpd.c:416:3: + /skiboot/include/skiboot.h:93:31: error: ‘%s’ directive argument is null [-Werror=format-overflow=] + 93 | #define prlog(l, f, ...) do { _prlog(l, pr_fmt(f), ##__VA_ARGS__); } while(0) + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + hdata/vpd.c:390:5: note: in expansion of macro ‘prlog’ + 390 | prlog(PR_WARNING, + | ^~~~~ + hdata/vpd.c: In function ‘vpd_data_parse’: + hdata/vpd.c:391:46: note: format string is defined here + 391 | "VPD: CCIN desc not available for: %s\n", + | ^~ + cc1: all warnings being treated as errors + +- errorlog: Prevent alignment error building with gcc9. + +:: + Fixes this build error: + [ 52s] hw/fsp/fsp-elog-write.c: In function 'opal_elog_read': + [ 52s] hw/fsp/fsp-elog-write.c:213:12: error: taking address of packed member of 'struct errorlog' may result + in an unaligned pointer value [-Werror=address-of-packed-member] + [ 52s] 213 | list_del(&log_data->link); + [ 52s] | ^~~~~~~~~~~~~~~ + +- Support BMC IPMI heartbeat command + + A few years ago, the OpenBMC code added support for a "heartbeat" + command to send to the host. This command is used after the BMC is reset + to check if the host is running. Support was never added to the host + side however so currently when the BMC sends this command, this appears + in the host console: + IPMI: unknown OEM SEL command ff received + + There is no response needed by the host (other then the low level + acknowledge of the command which already occurs). This commit + handles the command so the error is no longer printed (does nothing with + the command though since no action is needed). Here's the tested output + of this patch in the host console (with debug enabled): + IPMI: BMC issued heartbeat command: 00 + +- Add: add mihawk platform file