| Message ID | 20191114035055.23128-1-oohall@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | opal-ci: Remove clang builds on 18.04 | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (d75e82dbfbb9443efeb3f9a5921ac23605aab469) |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco | success | Signed-off-by present |
diff --git a/opal-ci/build-ubuntu-18.04.sh b/opal-ci/build-ubuntu-18.04.sh index 6fd755f3d9f2..48eb825bf40b 100755 --- a/opal-ci/build-ubuntu-18.04.sh +++ b/opal-ci/build-ubuntu-18.04.sh @@ -29,8 +29,3 @@ rm -rf builddir mkdir builddir make SRC=$(pwd) -f ../Makefile -C builddir -j${MAKE_J} make clean - -echo "Building with clang..." -make clean -make -j${MAKE_J} CC=clang -make -j${MAKE_J} CC=clang check
commit 3734172b0f40 ("build: fix non-constant build asserts") added the following check in asm/head.S: .if reset_patch_end - reset_patch_start > 0x100 .error "Reset patch overflow" .endif Some older versions of clang such as the one that ships with ubuntu 18.04 (vlang 6.0.0) don't consider symbol addresses as constant which causes the following error: asm/head.S:578:5: error: expected absolute expression .if reset_patch_end - reset_patch_start > 0x100 ^ asm/head.S:579:2: error: Reset patch overflow .error "Reset patch overflow" This appears to be a bug with the clang assembler that is fixed with versions of clang. Clang support in skiboot is best-effort so removing the clang builds from the Ubuntu 18.04 CI script is preferable to working around the limitations of the older versions of clang. Signed-off-by: Oliver O'Halloran <oohall@gmail.com> --- opal-ci/build-ubuntu-18.04.sh | 5 ----- 1 file changed, 5 deletions(-)