Message ID | 20190613031553.23903-1-stewart@linux.ibm.com |
---|---|
State | Accepted |
Headers | show |
Series | sparse: fix bt_lock should be static | expand |
Context | Check | Description |
---|---|---|
snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (db3929ee4f0a98596938f05da2789686908ebfd4) |
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | fail | Test snowpatch/job/snowpatch-skiboot on branch master |
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco | success | Signed-off-by present |
Stewart Smith <stewart@linux.ibm.com> writes: > Fix this sparse warning: > core/stack.c:123:13: warning: symbol 'bt_lock' was not declared. Should it be static? > > Signed-off-by: Stewart Smith <stewart@linux.ibm.com> > --- > core/stack.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged to master as of 728c73b8efb8dbdec78671b872f3518da59f5804
diff --git a/core/stack.c b/core/stack.c index d33d2fe771f7..b5a352d1ad71 100644 --- a/core/stack.c +++ b/core/stack.c @@ -120,7 +120,7 @@ void backtrace_print(struct bt_entry *entries, struct bt_metadata *metadata, * a backtrace they garble each other. To prevent this we use a seperate * lock to serialise printing of the dumps. */ -struct lock bt_lock = LOCK_UNLOCKED; +static struct lock bt_lock = LOCK_UNLOCKED; void backtrace(void) {
Fix this sparse warning: core/stack.c:123:13: warning: symbol 'bt_lock' was not declared. Should it be static? Signed-off-by: Stewart Smith <stewart@linux.ibm.com> --- core/stack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)