| Message ID | 20190510052155.10558-1-joel@jms.id.au |
|---|---|
| State | Accepted |
| Headers | show |
| Series | devicetree: Don't set path to dtc in makefile | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (e6e70ea51c6594290602e76102149ee6dcfc66ee) |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco | success | Signed-off-by present |
On Fri, May 10, 2019 at 3:22 PM Joel Stanley <joel@jms.id.au> wrote: > > By setting the path we fail to build under buildroot which has it's own > set of host tools in PATH, but not at /usr/bin. > > Keep the variable so it can be set if need be but default to whatever > 'dtc' is in the users path. > > Signed-off-by: Joel Stanley <joel@jms.id.au> Merged to master as of c8b5e8a95caf029ffe73ea18769fdd7f2da48ab4 Thanks! > --- > external/devicetree/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/external/devicetree/Makefile b/external/devicetree/Makefile > index 5a136f49999a..2ce622b0e397 100644 > --- a/external/devicetree/Makefile > +++ b/external/devicetree/Makefile > @@ -1,4 +1,4 @@ > -DTC=/usr/bin/dtc > +DTC=dtc > OUT=p9-simics.dtb > > all: $(OUT) > -- > 2.20.1 > > _______________________________________________ > Skiboot mailing list > Skiboot@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/skiboot
On Mon, 13 May 2019 at 04:02, Oliver <oohall@gmail.com> wrote: > > On Fri, May 10, 2019 at 3:22 PM Joel Stanley <joel@jms.id.au> wrote: > > > > By setting the path we fail to build under buildroot which has it's own > > set of host tools in PATH, but not at /usr/bin. > > > > Keep the variable so it can be set if need be but default to whatever > > 'dtc' is in the users path. > > > > Signed-off-by: Joel Stanley <joel@jms.id.au> > > Merged to master as of c8b5e8a95caf029ffe73ea18769fdd7f2da48ab4 Thanks Oliver. Vasant, can you please cherry pick this over to the 6.3 branch? Cheers, Joel
diff --git a/external/devicetree/Makefile b/external/devicetree/Makefile index 5a136f49999a..2ce622b0e397 100644 --- a/external/devicetree/Makefile +++ b/external/devicetree/Makefile @@ -1,4 +1,4 @@ -DTC=/usr/bin/dtc +DTC=dtc OUT=p9-simics.dtb all: $(OUT)
By setting the path we fail to build under buildroot which has it's own set of host tools in PATH, but not at /usr/bin. Keep the variable so it can be set if need be but default to whatever 'dtc' is in the users path. Signed-off-by: Joel Stanley <joel@jms.id.au> --- external/devicetree/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)