| Message ID | 20190225052436.20770-4-stewart@linux.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/6] sparse: symbol 'sbe_timer_lock' was not declared. Should it be static? | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | master/apply_patch Successfully applied |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
diff --git a/hw/npu-hw-procedures.c b/hw/npu-hw-procedures.c index cabc9c99d8bd..ec1f72b8ee79 100644 --- a/hw/npu-hw-procedures.c +++ b/hw/npu-hw-procedures.c @@ -1,4 +1,4 @@ -/* Copyright 2013-2015 IBM Corp. +/* Copyright 2013-2019 IBM Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -31,7 +31,7 @@ struct procedure { }; #define DEFINE_PROCEDURE(NAME, STEPS...) \ - struct procedure procedure_##NAME = \ + static struct procedure procedure_##NAME = \ {.name = #NAME, .steps = {NAME, ##STEPS}} #define PROCEDURE_INPROGRESS (1 << 31)
Yes they should. Do so by adding static to the macro. Signed-off-by: Stewart Smith <stewart@linux.ibm.com> --- hw/npu-hw-procedures.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)