| Message ID | 20181126232738.28571-1-stewart@linux.ibm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | libpore/fapi_sbe_common.H: remove erroneous "IBM Confidential" | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | master/apply_patch Successfully applied |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
On 27/11/18 10:27 am, Stewart Smith wrote: > Do this by synchronising with the hostboot copy of the code, which > removed the Confidential string when their copyright headers changed for > initial open sourcing of the code back in 2014. See hostboot commit > 3bcf5b7982bb8a2d9227dbff7be4ff2ce5fec05c where the HWP copyright headers > were updated. > > We likely missed this as we did a similar process inside the skiboot > repository, but likely only on the (C) headers themselves. > > Reported-by: Dawn Sylvia <ddzubak@us.ibm.com> > Signed-off-by: Stewart Smith <stewart@linux.ibm.com> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> > --- > libpore/fapi_sbe_common.H | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libpore/fapi_sbe_common.H b/libpore/fapi_sbe_common.H > index fa8cc7107753..cf0e76f92aae 100644 > --- a/libpore/fapi_sbe_common.H > +++ b/libpore/fapi_sbe_common.H > @@ -5,7 +5,9 @@ > /* */ > /* OpenPOWER HostBoot Project */ > /* */ > -/* COPYRIGHT International Business Machines Corp. 2012,2014 */ > +/* Contributors Listed Below - COPYRIGHT 2012,2014 */ > +/* [+] International Business Machines Corp. */ > +/* */ > /* */ > /* Licensed under the Apache License, Version 2.0 (the "License"); */ > /* you may not use this file except in compliance with the License. */ > @@ -28,7 +30,7 @@ > //------------------------------------------------------------------------------ > // *! (C) Copyright International Business Machines Corp. 2011 > // *! All Rights Reserved -- Property of IBM > -// *! *** IBM Confidential *** > +// *! *** *** > //------------------------------------------------------------------------------ > // *! OWNER NAME : Email: > >
Andrew Donnellan <andrew.donnellan@au1.ibm.com> writes: > On 27/11/18 10:27 am, Stewart Smith wrote: >> Do this by synchronising with the hostboot copy of the code, which >> removed the Confidential string when their copyright headers changed for >> initial open sourcing of the code back in 2014. See hostboot commit >> 3bcf5b7982bb8a2d9227dbff7be4ff2ce5fec05c where the HWP copyright headers >> were updated. >> >> We likely missed this as we did a similar process inside the skiboot >> repository, but likely only on the (C) headers themselves. >> >> Reported-by: Dawn Sylvia <ddzubak@us.ibm.com> >> Signed-off-by: Stewart Smith <stewart@linux.ibm.com> > > Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> I've sent a followup that syncs everything with hostboot, including some other files that erroneously had the "IBM Confidential" string hidden in a second copyright header. Want to review it? https://patchwork.ozlabs.org/patch/1003563/
diff --git a/libpore/fapi_sbe_common.H b/libpore/fapi_sbe_common.H index fa8cc7107753..cf0e76f92aae 100644 --- a/libpore/fapi_sbe_common.H +++ b/libpore/fapi_sbe_common.H @@ -5,7 +5,9 @@ /* */ /* OpenPOWER HostBoot Project */ /* */ -/* COPYRIGHT International Business Machines Corp. 2012,2014 */ +/* Contributors Listed Below - COPYRIGHT 2012,2014 */ +/* [+] International Business Machines Corp. */ +/* */ /* */ /* Licensed under the Apache License, Version 2.0 (the "License"); */ /* you may not use this file except in compliance with the License. */ @@ -28,7 +30,7 @@ //------------------------------------------------------------------------------ // *! (C) Copyright International Business Machines Corp. 2011 // *! All Rights Reserved -- Property of IBM -// *! *** IBM Confidential *** +// *! *** *** //------------------------------------------------------------------------------ // *! OWNER NAME : Email:
Do this by synchronising with the hostboot copy of the code, which removed the Confidential string when their copyright headers changed for initial open sourcing of the code back in 2014. See hostboot commit 3bcf5b7982bb8a2d9227dbff7be4ff2ce5fec05c where the HWP copyright headers were updated. We likely missed this as we did a similar process inside the skiboot repository, but likely only on the (C) headers themselves. Reported-by: Dawn Sylvia <ddzubak@us.ibm.com> Signed-off-by: Stewart Smith <stewart@linux.ibm.com> --- libpore/fapi_sbe_common.H | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)