From patchwork Thu Jun 7 13:29:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Balbir Singh X-Patchwork-Id: 926303 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 411mbp5rD7z9s1B for ; Thu, 7 Jun 2018 23:29:26 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XwXa3htW"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 411mbp1tZfzF34g for ; Thu, 7 Jun 2018 23:29:26 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XwXa3htW"; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c01::241; helo=mail-pl0-x241.google.com; envelope-from=bsingharora@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XwXa3htW"; dkim-atps=neutral Received: from mail-pl0-x241.google.com (mail-pl0-x241.google.com [IPv6:2607:f8b0:400e:c01::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 411mbd45zYzF34S for ; Thu, 7 Jun 2018 23:29:16 +1000 (AEST) Received: by mail-pl0-x241.google.com with SMTP id i5-v6so6153145plt.2 for ; Thu, 07 Jun 2018 06:29:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=hURv0gewpST3aBeaDPA3I/O8p9JhmoibtyTEdLrsH5I=; b=XwXa3htWpjyWbb8uxYE/fXx8SErWELHb7Kf4RTQhCNEk3Bt2b1Vc2ZvvnFi0ojpmGY gNAoOwaYLUwwxqEx3hY1sxkas+H2tJf/UBY+Kop4mkm2DbNmn5B0C30BUNLEWJANCt4C 07+qH55u7htec5+IwpMPUUGEo+J5rc8NGZg6vcPPaph5knM2rc5FviBB+ZPzvbkhzF0S ZiuGI2P3MsPhzhsypZz1sjVPgz8MjJ+TJ20eklhhUGqpbItoXn21BcekVDg77TOyGlVM JkiW20qYs4cDXAIZPL/aotvs1BHi7yH0LGA8Fr5Mzk4JBEEB0mDk5FBwfHKjDZ8XAoCK 8Xyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hURv0gewpST3aBeaDPA3I/O8p9JhmoibtyTEdLrsH5I=; b=mTNw8JMM506NlmGGGtiIDvdaByzGhcx49ahDlpZMEbbNFEJwGco6lFRBhPIicjODtw LSbLEkS8RVzFIhhb+wUcDqfqMUJd2zHUDSF/nseXrbPw7+CleQDuiIGjgukxBf4TKDVi yOo64Y6fAP+CBEjfkZz8SuwOKqfsD5KMUP7slLGQ+Vk7P0Dz4Gyjz/ITVQEYoLIXImNL FI4Zx++OfDbluNlzO2jNR3yf1AkBi8hNpplucD7MrpmK/weJWDNj8x8Kc+EzR6BdEvXs ml9LrxozIa34QQKygibBM6HaLkGWN/mwU6b0Kc0as2h+EctVpxWHxxvT3oOEdhewKpky v4Jw== X-Gm-Message-State: APt69E3hxr5v+B1Eah5s3PdG9KPJAaLios8hh7P15HAaH85YiVJfX7md FmAvnDy0XeWUnwBR23eTWIq9Fgmx X-Google-Smtp-Source: ADUXVKITn+1kV96XauPw58URQwYGDm6HgZ57XCxVqRRP2SbLkt/fDTA+QE0Mi7fzbJOyvaj2b/S1qg== X-Received: by 2002:a17:902:5390:: with SMTP id c16-v6mr2150897pli.104.1528378153914; Thu, 07 Jun 2018 06:29:13 -0700 (PDT) Received: from localhost.localdomain (14-202-194-140.static.tpgi.com.au. [14.202.194.140]) by smtp.gmail.com with ESMTPSA id m5-v6sm82965323pfa.93.2018.06.07.06.29.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jun 2018 06:29:13 -0700 (PDT) From: Balbir singh To: skiboot@lists.ozlabs.org Date: Thu, 7 Jun 2018 23:29:03 +1000 Message-Id: <20180607132903.16617-1-bsingharora@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [Skiboot] [PATCH] trival: Remove an extra reg read of VUART1_GCTRLA X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" The comments did not say if the read was needed to ensure the previous write completed, but otherwise the read is followed by a read of VUART1_GCTRLB and the value of v is discarded. Signed-off-by: Balbir singh --- NOTE: As you might suspect I have no way of testing this except for compile testing it hw/ast-bmc/ast-io.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ast-bmc/ast-io.c b/hw/ast-bmc/ast-io.c index 1e826fcc..a07f5822 100644 --- a/hw/ast-bmc/ast-io.c +++ b/hw/ast-bmc/ast-io.c @@ -434,7 +434,6 @@ void ast_setup_vuart1(uint16_t io_base, uint8_t irq) v = bmc_sio_ahb_readl(VUART1_GCTRLA); v = v & ~2u; bmc_sio_ahb_writel(v, VUART1_GCTRLA); - v = bmc_sio_ahb_readl(VUART1_GCTRLA); /* IRQ number */ v = bmc_sio_ahb_readl(VUART1_GCTRLB);