diff mbox series

[01/13] asm: Fix up assembly for clang

Message ID 20180502083753.25090-2-joel@jms.id.au
State Superseded
Headers show
Series Support building with clang | expand

Commit Message

Joel Stanley May 2, 2018, 8:37 a.m. UTC
asm/head.S:766:17: error: unknown operand
 or %r0,%r4,%r5,
                ^
asm/head.S:800:17: error: unknown operand
 or %r0,%r4,%r5,
                ^
Signed-off-by: Joel Stanley <joel@jms.id.au>

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 asm/head.S | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Balbir Singh May 2, 2018, 12:48 p.m. UTC | #1
On Wed, 2018-05-02 at 18:07 +0930, Joel Stanley wrote:
> asm/head.S:766:17: error: unknown operand
>  or %r0,%r4,%r5,
>                 ^
> asm/head.S:800:17: error: unknown operand
>  or %r0,%r4,%r5,
>                 ^
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>

Looks like you squashed two commits and have two
signed-off-by's.

Acked-by: Balbir Singh <bsingharora@gmail.com>

Balbir Singh
diff mbox series

Patch

diff --git a/asm/head.S b/asm/head.S
index 2cf4a6b28310..803fbf1a61ee 100644
--- a/asm/head.S
+++ b/asm/head.S
@@ -763,7 +763,7 @@  init_shared_sprs:
 	li	%r0,1
 	sldi	%r4,%r0,(63-13)
 	sldi	%r5,%r0,(63-19)
-	or	%r0,%r4,%r5,
+	or	%r0,%r4,%r5
 	andc	%r3,%r3,%r0
 	sync
 	mtspr	SPR_HID0,%r3
@@ -797,7 +797,7 @@  init_shared_sprs:
 	li	%r0,1
 	sldi	%r4,%r0,(63-5)
 	sldi	%r5,%r0,(63-4)
-	or	%r0,%r4,%r5,
+	or	%r0,%r4,%r5
 	andc	%r3,%r3,%r0
 	sync
 	mtspr	SPR_HID0,%r3