From patchwork Wed Dec 6 17:39:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Herrenschmidt X-Patchwork-Id: 845276 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ysQsf1hw4z9ryT for ; Thu, 7 Dec 2017 04:41:58 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3ysQsf0RNGzDrpN for ; Thu, 7 Dec 2017 04:41:58 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=permerror (mailfrom) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=benh@kernel.crashing.org; receiver=) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ysQqq60TjzDrnv for ; Thu, 7 Dec 2017 04:40:06 +1100 (AEDT) Received: from pasglop.austin.ibm.com (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id vB6HdhvU020901; Wed, 6 Dec 2017 11:39:44 -0600 From: Benjamin Herrenschmidt To: skiboot@lists.ozlabs.org Date: Wed, 6 Dec 2017 11:39:24 -0600 Message-Id: <20171206173928.25628-2-benh@kernel.crashing.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20171206173928.25628-1-benh@kernel.crashing.org> References: <20171206173928.25628-1-benh@kernel.crashing.org> Subject: [Skiboot] [PATCH 2/6] xive: Do not return a trigger page for an escalation interrupt X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" This is bogus, we don't support them. (Thankfully the callers didn't actually try to use this on escalation interrupts). Signed-off-by: Benjamin Herrenschmidt Tested-by: Oliver O'Halloran --- hw/xive.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xive.c b/hw/xive.c index 364be549..76939b79 100644 --- a/hw/xive.c +++ b/hw/xive.c @@ -2111,8 +2111,8 @@ void *xive_get_trigger_port(uint32_t girq) return NULL; if (GIRQ_IS_ESCALATION(girq)) { - /* Page 2 of the EQ MMIO space is the escalate irq */ - return x->eq_mmio + idx * 0x20000 + 0x10000; + /* There is no trigger page for escalation interrupts */ + return NULL; } else { /* Make sure it's an IPI on that chip */ if (girq < x->int_base ||