diff mbox series

[3/3] hdata/smplink: Increment index of associated PHB

Message ID 20170920094602.4838-3-oohall@gmail.com
State Accepted
Headers show
Series [1/3] npu2: Copy link speed from the npu node | expand

Commit Message

Oliver O'Halloran Sept. 20, 2017, 9:46 a.m. UTC
The PHB number of the NPU device needs to be incremented per-chip or bad
things are going to occur.

Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
---
 hdata/spira.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stewart Smith Sept. 21, 2017, 4:49 a.m. UTC | #1
Oliver O'Halloran <oohall@gmail.com> writes:
> The PHB number of the NPU device needs to be incremented per-chip or bad
> things are going to occur.
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> ---
>  hdata/spira.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hdata/spira.c b/hdata/spira.c
> index 5e3d6ccc05d5..7dc8d5fa061f 100644
> --- a/hdata/spira.c
> +++ b/hdata/spira.c
> @@ -1463,7 +1463,7 @@ static void add_npus(void)
>  
>  		/* some hostboots will give us an empty array */
>  		if (be32_to_cpu(links->ecnt))
> -			add_npu(xscom, links, npu_index, phb_index);
> +			add_npu(xscom, links, npu_index, phb_index++);
>  	}

Series merged to master as of 577b75727d9ee9d57e1468e52275a7d838bbabf0,
with the change discussed on Slack where npu_index++ also
diff mbox series

Patch

diff --git a/hdata/spira.c b/hdata/spira.c
index 5e3d6ccc05d5..7dc8d5fa061f 100644
--- a/hdata/spira.c
+++ b/hdata/spira.c
@@ -1463,7 +1463,7 @@  static void add_npus(void)
 
 		/* some hostboots will give us an empty array */
 		if (be32_to_cpu(links->ecnt))
-			add_npu(xscom, links, npu_index, phb_index);
+			add_npu(xscom, links, npu_index, phb_index++);
 	}
 }