Message ID | 20170816093540.27595-2-cyril.bur@au1.ibm.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xXPQP61xpz9t4Z for <incoming@patchwork.ozlabs.org>; Wed, 16 Aug 2017 19:37:33 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3xXPQP55qgzDrD2 for <incoming@patchwork.ozlabs.org>; Wed, 16 Aug 2017 19:37:33 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xXPQH32mWzDqkv for <skiboot@lists.ozlabs.org>; Wed, 16 Aug 2017 19:37:27 +1000 (AEST) Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v7G9b7uV119349 for <skiboot@lists.ozlabs.org>; Wed, 16 Aug 2017 05:37:25 -0400 Received: from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ccefndtm2-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for <skiboot@lists.ozlabs.org>; Wed, 16 Aug 2017 05:37:24 -0400 Received: from localhost by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for <skiboot@lists.ozlabs.org> from <cyril.bur@au1.ibm.com>; Wed, 16 Aug 2017 19:37:22 +1000 Received: from d23relay09.au.ibm.com (202.81.31.228) by e23smtp06.au.ibm.com (202.81.31.212) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 16 Aug 2017 19:37:20 +1000 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay09.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v7G9a45n39583796 for <skiboot@lists.ozlabs.org>; Wed, 16 Aug 2017 19:36:04 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v7G9a41V007281 for <skiboot@lists.ozlabs.org>; Wed, 16 Aug 2017 19:36:04 +1000 Received: from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id v7G9a4c1007278 for <skiboot@lists.ozlabs.org>; Wed, 16 Aug 2017 19:36:04 +1000 Received: from camb691.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 4C746A0197 for <skiboot@lists.ozlabs.org>; Wed, 16 Aug 2017 19:36:04 +1000 (AEST) From: Cyril Bur <cyril.bur@au1.ibm.com> To: skiboot@lists.ozlabs.org Date: Wed, 16 Aug 2017 19:35:38 +1000 X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170816093540.27595-1-cyril.bur@au1.ibm.com> References: <20170816093540.27595-1-cyril.bur@au1.ibm.com> X-TM-AS-MML: disable x-cbid: 17081609-0040-0000-0000-0000034EC2FE X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17081609-0041-0000-0000-00000CCC70A2 Message-Id: <20170816093540.27595-2-cyril.bur@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-08-16_04:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1708160158 Subject: [Skiboot] [PATCH 2/4] external/pflash: Fix resource leak CID 163742 X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development <skiboot.lists.ozlabs.org> List-Unsubscribe: <https://lists.ozlabs.org/options/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe> List-Archive: <http://lists.ozlabs.org/pipermail/skiboot/> List-Post: <mailto:skiboot@lists.ozlabs.org> List-Help: <mailto:skiboot-request@lists.ozlabs.org?subject=help> List-Subscribe: <https://lists.ozlabs.org/listinfo/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> |
diff --git a/external/pflash/pflash.c b/external/pflash/pflash.c index ed33a6fd..69016578 100644 --- a/external/pflash/pflash.c +++ b/external/pflash/pflash.c @@ -182,6 +182,7 @@ static void print_flash_info(struct flash_details *flash) return; next_toc = print_ffs_info(ffsh, toc); + ffs_close(ffsh); while(next_toc != toc) { struct ffs_handle *next_ffsh;
Thanks Coverity. Fixes: CID 163742 Signed-off-by: Cyril Bur <cyril.bur@au1.ibm.com> --- external/pflash/pflash.c | 1 + 1 file changed, 1 insertion(+)